All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Jason Wang <jasowang@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Samuel Thibault <samuel.thibault@ens-lyon.org>,
	brad@comstyle.com
Subject: Re: [Qemu-devel] [PATCH v2] slirp: Implement RFC2132 TFTP server name
Date: Mon, 27 Aug 2018 15:03:31 +0800	[thread overview]
Message-ID: <20180827070331.GC19413@lemon.usersys.redhat.com> (raw)
In-Reply-To: <bbffc053-985e-3e27-dddf-1146891e0acb@redhat.com>

On Mon, 08/27 08:51, Thomas Huth wrote:
> On 2018-08-27 04:22, Fam Zheng wrote:
> > This new usernet option can be used to add data for option 66 (tftp
> > server name) in the BOOTP reply, which is useful in PXE based automatic
> > OS install such as OpenBSD.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > 
> > v2: - Adjust parameter order and field placement to be closer to other
> > tftp options. [Samuel]
> >     - Drop 'optional'. [Eric]
> > ---
> >  net/slirp.c      | 5 ++++-
> >  qapi/net.json    | 5 ++++-
> >  slirp/bootp.c    | 8 ++++++++
> >  slirp/bootp.h    | 1 +
> >  slirp/libslirp.h | 4 +++-
> >  slirp/slirp.c    | 5 ++++-
> >  slirp/slirp.h    | 1 +
> >  7 files changed, 25 insertions(+), 4 deletions(-)
> 
> Please add information about this new parameter to the documentation in
> qemu-options.hx, too!

Oops, I totally forgot that. Yes!

Fam

      reply	other threads:[~2018-08-27  7:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-27  2:22 [Qemu-devel] [PATCH v2] slirp: Implement RFC2132 TFTP server name Fam Zheng
2018-08-27  6:51 ` Thomas Huth
2018-08-27  7:03   ` Fam Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180827070331.GC19413@lemon.usersys.redhat.com \
    --to=famz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=brad@comstyle.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jasowang@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.