From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 1/2]: perf util: map data buffer for preserving collected data
Date: Mon, 27 Aug 2018 10:33:03 +0200 [thread overview]
Message-ID: <20180827083303.GD24695@krava> (raw)
In-Reply-To: <e5591d27-5386-1d41-b09b-421316f75d07@linux.intel.com>
On Thu, Aug 23, 2018 at 07:42:09PM +0300, Alexey Budankov wrote:
SNIP
> diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c
> index fc832676a798..e71d46cb01cc 100644
> --- a/tools/perf/util/mmap.c
> +++ b/tools/perf/util/mmap.c
> @@ -155,6 +155,10 @@ void __weak auxtrace_mmap_params__set_idx(struct auxtrace_mmap_params *mp __mayb
>
> void perf_mmap__munmap(struct perf_mmap *map)
> {
> + if (map->data != NULL) {
> + munmap(map->data, perf_mmap__mmap_len(map));
> + map->data = NULL;
> + }
> if (map->base != NULL) {
> munmap(map->base, perf_mmap__mmap_len(map));
> map->base = NULL;
> @@ -190,6 +194,14 @@ int perf_mmap__mmap(struct perf_mmap *map, struct mmap_params *mp, int fd)
> map->base = NULL;
> return -1;
> }
> + map->data = mmap(NULL, perf_mmap__mmap_len(map), PROT_READ | PROT_WRITE,
> + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
hum, why does map->data need to be mmap-ed?
jirka
next prev parent reply other threads:[~2018-08-27 8:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 16:33 [PATCH v2 0/2]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-08-23 16:42 ` [PATCH v2 1/2]: perf util: map data buffer for preserving collected data Alexey Budankov
2018-08-27 8:28 ` Jiri Olsa
2018-08-27 8:58 ` Alexey Budankov
2018-08-27 8:33 ` Jiri Olsa [this message]
2018-08-27 9:02 ` Alexey Budankov
2018-08-28 8:45 ` Jiri Olsa
2018-08-28 9:19 ` Alexey Budankov
2018-08-23 16:47 ` [PATCH v2 2/2]: perf record: enable asynchronous trace writing Alexey Budankov
2018-08-27 8:34 ` Jiri Olsa
2018-08-27 9:12 ` Alexey Budankov
2018-08-27 8:38 ` Jiri Olsa
2018-08-27 9:33 ` Alexey Budankov
2018-08-27 10:05 ` Namhyung Kim
2018-08-27 10:25 ` Alexey Budankov
2018-08-27 10:38 ` Jiri Olsa
2018-08-27 10:48 ` Alexey Budankov
2018-08-27 8:43 ` Jiri Olsa
2018-08-27 9:45 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827083303.GD24695@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.