From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] build: declare that libf2fs_format uses the blkid library
Date: Mon, 27 Aug 2018 12:04:59 -0400 [thread overview]
Message-ID: <20180827160459.GH2311@thunk.org> (raw)
In-Reply-To: <20180824072632.23608-1-tytso@mit.edu>
Ping? This bug was noticed when I was repackaging f2fs-tools for
Debian. The problem is that libf2fs_format references the blkid
library, and Debian's shared library auditing tools noticed the
missing library dependency.
- Ted
On Fri, Aug 24, 2018 at 03:26:32AM -0400, Theodore Ts'o wrote:
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> ---
> mkfs/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/Makefile.am b/mkfs/Makefile.am
> index 32996ba..cae2f93 100644
> --- a/mkfs/Makefile.am
> +++ b/mkfs/Makefile.am
> @@ -12,7 +12,7 @@ lib_LTLIBRARIES = libf2fs_format.la
> libf2fs_format_la_SOURCES = f2fs_format_main.c f2fs_format.c f2fs_format_utils.c
> libf2fs_format_la_CFLAGS = -DWITH_BLKDISCARD
> libf2fs_format_la_CPPFLAGS = -I$(top_srcdir)/include
> -libf2fs_format_la_LDFLAGS = -luuid -L$(top_builddir)/lib -lf2fs \
> +libf2fs_format_la_LDFLAGS = -lblkid -luuid -L$(top_builddir)/lib -lf2fs \
> -version-info $(FMT_CURRENT):$(FMT_REVISION):$(FMT_AGE)
>
> install-exec-hook:
> --
> 2.18.0.rc0
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2018-08-27 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 7:26 [PATCH] build: declare that libf2fs_format uses the blkid library Theodore Ts'o
2018-08-27 16:04 ` Theodore Y. Ts'o [this message]
2018-08-27 16:51 ` Jaegeuk Kim
2018-08-28 3:22 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827160459.GH2311@thunk.org \
--to=tytso@mit.edu \
--cc=linux-f2fs-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.