From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:56980 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727716AbeH1RfE (ORCPT ); Tue, 28 Aug 2018 13:35:04 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [PATCH] ath10k: use struct_size() in kzalloc() From: Kalle Valo In-Reply-To: <20180824011247.GA25648@embeddedor.com> References: <20180824011247.GA25648@embeddedor.com> To: "Gustavo A. R. Silva" Cc: "David S. Miller" , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kees Cook , "Gustavo A. R. Silva" Message-Id: <20180828134320.5E6726044E@smtp.codeaurora.org> (sfid-20180828_154333_168442_77D9AA45) Date: Tue, 28 Aug 2018 13:43:20 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: "Gustavo A. R. Silva" wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { > int stuff; > void *entry[]; > }; > > instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); > > Instead of leaving these open-coded and prone to type mistakes, we can > now use the new struct_size() helper: > > instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > Reviewed-by: Kees Cook > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 06ae8dc00433 ath10k: use struct_size() in kzalloc() -- https://patchwork.kernel.org/patch/10574741/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches