From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2] drm: Fix crtc color management when doing suspend/resume Date: Tue, 28 Aug 2018 19:37:03 +0300 Message-ID: <20180828163703.GC5565@intel.com> References: <20180828153320.4725-1-alexandru-cosmin.gheorghe@arm.com> <20180828154607.GB5565@intel.com> <20180828155842.GA5034@e114479-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id A68996E3AD for ; Tue, 28 Aug 2018 16:37:08 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180828155842.GA5034@e114479-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandru-Cosmin Gheorghe Cc: nd@arm.com, airlied@linux.ie, liviu.dudau@arm.com, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, ayan.halder@arm.com List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBdWcgMjgsIDIwMTggYXQgMDQ6NTg6NDJQTSArMDEwMCwgQWxleGFuZHJ1LUNvc21p biBHaGVvcmdoZSB3cm90ZToKPiBPbiBUdWUsIEF1ZyAyOCwgMjAxOCBhdCAwNjo0NjowN1BNICsw MzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBUdWUsIEF1ZyAyOCwgMjAxOCBhdCAw NDozMzoyMFBNICswMTAwLCBBbGV4YW5kcnUgR2hlb3JnaGUgd3JvdGU6Cj4gPiA+IFdoZW4gZG9p bmcgc3VzcGVuZC9yZXN1bWUgZHJpdmVycyB1c3VhbGx5IHVzZSB0aGUKPiA+ID4gZHJtX2F0b21p Y19oZWxwZXJfc3VzcGVuZC9kcm1fYXRvbWljX2hlbHBlcl9yZXN1bWUgcGFpciBmb3Igc2F2aW5n IHRoZQo+ID4gPiBzdGF0ZSBhbmQgdGhlbiByZS1jb21pdHRpbmcgaXQuCj4gPiA+IAo+ID4gPiBU aGUgcHJvYmxlbSBpcyB0aGF0IGRybV9jcnRjX3N0YXRlIGhhcyBhIGJvb2wgZmllbGQgY2FsbGVk Cj4gPiA+IGNvbG9yX21nbXRfY2hhbmdlZCwgd2hpY2ggbWFsaS1kcCBhbmQgb3RoZXIgZHJpdmVy cyB1c2VzIGl0IHRvIGRldGVjdAo+ID4gPiBpZiBjb2VmZmljaWVudHMgbmVlZCB0byBiZSByZXBy b2dyYW1tZWQsIGJ1dCB0aGF0IG5ldmVyIGhhcHBlbnMKPiA+ID4gYmVjYXVzZSB0aGUgc2F2ZWQg c3RhdGUgaGFzIGNvbG9yX21nbXRfY2hhbmdlZCBzZXQgdG8gMC4KPiA+ID4gCj4gPiA+IEZpeCB0 aGF0IGJ5IHNldHRpbmcgY29sb3JfbWdtdF9jaGFuZ2VkIHRvIHRydWUgaW4KPiA+ID4gZHJtX2F0 b21pY19oZWxwZXJfY2hlY2tfbW9kZXNldCB3aGVuIGF0IGxlYXN0IG9uZSBvZiBnYW1tYV9sdXQs Cj4gPiA+IGRlZ2FtbWFfbHV0LCBjdG0gaXMgZGlmZmVyZW50IGJldHdlZW4gdGhlIG5ldyBhbmQg dGhlIG9sZCBjcnRjIHN0YXRlLgo+ID4gPiAKPiA+ID4gQWxzbywgdGhpcyBtYWtlcyB1bm5lY2Vz c2FyeSB0aGUgc2V0dGluZyBvZiBjb2xvcl9tZ210X2NoYW5nZWQgaW4KPiA+ID4gcGxhY2VzIHdo ZXJlIGdhbW1hX2x1dC9kZWdhbW1hX2x1dC9jdG0gYXJlIHNldCBpbiB0aGUgbmV3IGNydGNfc3Rh dGUuCj4gPiAKPiA+IERvIGFsbCBjdXJyZW50IGRyaXZlcnMgYWN0dWFsbHkgY2FsbCBkcm1fYXRv bWljX2hlbHBlcl9jaGVja19tb2Rlc2V0KCkKPiA+IGZvciBldmVyeSBjb21taXQ/Cj4gCj4gWWVz LCBhbGwgZHJpdmVycyB0aGF0IHVzZSBjb2xvcl9tZ210X2NoYW5nZWQgZWl0aGVyIGNhbGwgZGly ZWN0bHkKPiBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rlc2V0IG9yIHRoZXkgdXNlIGRybV9h dG9taWNfaGVscGVyX2NoZWNrCj4gd2hpY2ggY2FsbHMgZHJtX2F0b21pY19oZWxwZXJfY2hlY2tf bW9kZXNldC4KCkF3ZXNvbWUuCgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gCj4gPiAKPiA+ID4gCj4gPiA+IENoYW5nZXMgc2lu Y2UgdjI6Cj4gPiA+ICAgLSBJbnN0ZWFkIG9mIHNldHRpbmcgY29sb3JfbWdtdF9jaGFuZ2VkIGlu IGNvbW1pdF9kdXBsaWNhdGVkX3NldAo+ID4gPiAgICAganVzdCBzZXQgaXQgaW4gY2hlY2tfbW9k ZXNldCBhbmQgY2xlYW4gdXAgb3RoZXIgcGxhY2Ugd2hlcmUgaXQgd2FzCj4gPiA+ICAgICBzZXQs IHN1Z2dlc3RlZCBieSBNYWFydGVuIExhbmtob3JzdC4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYt Ynk6IEFsZXhhbmRydSBHaGVvcmdoZSA8YWxleGFuZHJ1LWNvc21pbi5naGVvcmdoZUBhcm0uY29t Pgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgICAgICAgIHwg MTIgKysrLS0tLS0tLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIu YyB8ICA4ICsrKysrKystCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jICAg ICB8ICAxIC0KPiA+ID4gIDMgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMTEgZGVs ZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9h dG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiA+ID4gaW5kZXggZDA0Nzhh YmMwMWJkLi45YmNhZGEzYzI5OWUgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fYXRvbWljLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ID4g PiBAQCAtNTU0LDI5ICs1NTQsMjMgQEAgaW50IGRybV9hdG9taWNfY3J0Y19zZXRfcHJvcGVydHko c3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gPiAgCQlkcm1fcHJvcGVydHlfYmxvYl9wdXQobW9k ZSk7Cj4gPiA+ICAJCXJldHVybiByZXQ7Cj4gPiA+ICAJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBj b25maWctPmRlZ2FtbWFfbHV0X3Byb3BlcnR5KSB7Cj4gPiA+IC0JCXJldCA9IGRybV9hdG9taWNf cmVwbGFjZV9wcm9wZXJ0eV9ibG9iX2Zyb21faWQoZGV2LAo+ID4gPiArCQlyZXR1cm4gZHJtX2F0 b21pY19yZXBsYWNlX3Byb3BlcnR5X2Jsb2JfZnJvbV9pZChkZXYsCj4gPiA+ICAJCQkJCSZzdGF0 ZS0+ZGVnYW1tYV9sdXQsCj4gPiA+ICAJCQkJCXZhbCwKPiA+ID4gIAkJCQkJLTEsIHNpemVvZihz dHJ1Y3QgZHJtX2NvbG9yX2x1dCksCj4gPiA+ICAJCQkJCSZyZXBsYWNlZCk7Cj4gPiA+IC0JCXN0 YXRlLT5jb2xvcl9tZ210X2NoYW5nZWQgfD0gcmVwbGFjZWQ7Cj4gPiA+IC0JCXJldHVybiByZXQ7 Cj4gPiA+ICAJfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBjb25maWctPmN0bV9wcm9wZXJ0eSkgewo+ ID4gPiAtCQlyZXQgPSBkcm1fYXRvbWljX3JlcGxhY2VfcHJvcGVydHlfYmxvYl9mcm9tX2lkKGRl diwKPiA+ID4gKwkJcmV0dXJuIGRybV9hdG9taWNfcmVwbGFjZV9wcm9wZXJ0eV9ibG9iX2Zyb21f aWQoZGV2LAo+ID4gPiAgCQkJCQkmc3RhdGUtPmN0bSwKPiA+ID4gIAkJCQkJdmFsLAo+ID4gPiAg CQkJCQlzaXplb2Yoc3RydWN0IGRybV9jb2xvcl9jdG0pLCAtMSwKPiA+ID4gIAkJCQkJJnJlcGxh Y2VkKTsKPiA+ID4gLQkJc3RhdGUtPmNvbG9yX21nbXRfY2hhbmdlZCB8PSByZXBsYWNlZDsKPiA+ ID4gLQkJcmV0dXJuIHJldDsKPiA+ID4gIAl9IGVsc2UgaWYgKHByb3BlcnR5ID09IGNvbmZpZy0+ Z2FtbWFfbHV0X3Byb3BlcnR5KSB7Cj4gPiA+IC0JCXJldCA9IGRybV9hdG9taWNfcmVwbGFjZV9w cm9wZXJ0eV9ibG9iX2Zyb21faWQoZGV2LAo+ID4gPiArCQlyZXR1cm4gZHJtX2F0b21pY19yZXBs YWNlX3Byb3BlcnR5X2Jsb2JfZnJvbV9pZChkZXYsCj4gPiA+ICAJCQkJCSZzdGF0ZS0+Z2FtbWFf bHV0LAo+ID4gPiAgCQkJCQl2YWwsCj4gPiA+ICAJCQkJCS0xLCBzaXplb2Yoc3RydWN0IGRybV9j b2xvcl9sdXQpLAo+ID4gPiAgCQkJCQkmcmVwbGFjZWQpOwo+ID4gPiAtCQlzdGF0ZS0+Y29sb3Jf bWdtdF9jaGFuZ2VkIHw9IHJlcGxhY2VkOwo+ID4gPiAtCQlyZXR1cm4gcmV0Owo+ID4gPiAgCX0g ZWxzZSBpZiAocHJvcGVydHkgPT0gY29uZmlnLT5wcm9wX291dF9mZW5jZV9wdHIpIHsKPiA+ID4g IAkJczMyIF9fdXNlciAqZmVuY2VfcHRyID0gdTY0X3RvX3VzZXJfcHRyKHZhbCk7Cj4gPiA+ICAK PiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIGIv ZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiA+ID4gaW5kZXggMmMyM2E0ODQ4 MmRhLi5mZTIyZTFhZDQ2OGEgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljX2hlbHBlci5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hl bHBlci5jCj4gPiA+IEBAIC02MTEsNiArNjExLDEzIEBAIGRybV9hdG9taWNfaGVscGVyX2NoZWNr X21vZGVzZXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ID4gIAo+ID4gPiAgCQkJcmV0dXJu IC1FSU5WQUw7Cj4gPiA+ICAJCX0KPiA+ID4gKwkJaWYgKG5ld19jcnRjX3N0YXRlLT5kZWdhbW1h X2x1dCAhPSBvbGRfY3J0Y19zdGF0ZS0+ZGVnYW1tYV9sdXQgfHwKPiA+ID4gKwkJICAgIG5ld19j cnRjX3N0YXRlLT5jdG0gIT0gb2xkX2NydGNfc3RhdGUtPmN0bSB8fAo+ID4gPiArCQkgICAgbmV3 X2NydGNfc3RhdGUtPmdhbW1hX2x1dCAhPSBvbGRfY3J0Y19zdGF0ZS0+Z2FtbWFfbHV0KSB7Cj4g PiA+ICsJCQlEUk1fREVCVUdfQVRPTUlDKCJbQ1JUQzolZDolc10gY29sb3IgbWFuYWdlbWVudCBj aGFuZ2VkXG4iLAo+ID4gPiArCQkJCQkgY3J0Yy0+YmFzZS5pZCwgY3J0Yy0+bmFtZSk7Cj4gPiA+ ICsJCQluZXdfY3J0Y19zdGF0ZS0+Y29sb3JfbWdtdF9jaGFuZ2VkID0gdHJ1ZTsKPiA+ID4gKwkJ fQo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAgCXJldCA9IGhhbmRsZV9jb25mbGljdGluZ19lbmNv ZGVycyhzdGF0ZSwgZmFsc2UpOwo+ID4gPiBAQCAtMzk0Nyw3ICszOTU0LDYgQEAgaW50IGRybV9h dG9taWNfaGVscGVyX2xlZ2FjeV9nYW1tYV9zZXQoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4g PiAgCXJlcGxhY2VkICA9IGRybV9wcm9wZXJ0eV9yZXBsYWNlX2Jsb2IoJmNydGNfc3RhdGUtPmRl Z2FtbWFfbHV0LCBOVUxMKTsKPiA+ID4gIAlyZXBsYWNlZCB8PSBkcm1fcHJvcGVydHlfcmVwbGFj ZV9ibG9iKCZjcnRjX3N0YXRlLT5jdG0sIE5VTEwpOwo+ID4gPiAgCXJlcGxhY2VkIHw9IGRybV9w cm9wZXJ0eV9yZXBsYWNlX2Jsb2IoJmNydGNfc3RhdGUtPmdhbW1hX2x1dCwgYmxvYik7Cj4gPiA+ IC0JY3J0Y19zdGF0ZS0+Y29sb3JfbWdtdF9jaGFuZ2VkIHw9IHJlcGxhY2VkOwo+ID4gPiAgCj4g PiA+ICAJcmV0ID0gZHJtX2F0b21pY19jb21taXQoc3RhdGUpOwo+ID4gPiAgCj4gPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJt L2RybV9mYl9oZWxwZXIuYwo+ID4gPiBpbmRleCA0YjBkZDIwYmNjYjguLjg1NDFlOTVhNTQxMCAx MDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ID4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gPiA+IEBAIC0xNDQyLDcgKzE0 NDIsNiBAQCBzdGF0aWMgaW50IHNldGNtYXBfYXRvbWljKHN0cnVjdCBmYl9jbWFwICpjbWFwLCBz dHJ1Y3QgZmJfaW5mbyAqaW5mbykKPiA+ID4gIAkJcmVwbGFjZWQgfD0gZHJtX3Byb3BlcnR5X3Jl cGxhY2VfYmxvYigmY3J0Y19zdGF0ZS0+Y3RtLCBOVUxMKTsKPiA+ID4gIAkJcmVwbGFjZWQgfD0g ZHJtX3Byb3BlcnR5X3JlcGxhY2VfYmxvYigmY3J0Y19zdGF0ZS0+Z2FtbWFfbHV0LAo+ID4gPiAg CQkJCQkJICAgICAgZ2FtbWFfbHV0KTsKPiA+ID4gLQkJY3J0Y19zdGF0ZS0+Y29sb3JfbWdtdF9j aGFuZ2VkIHw9IHJlcGxhY2VkOwo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAgCXJldCA9IGRybV9h dG9taWNfY29tbWl0KHN0YXRlKTsKPiA+ID4gLS0gCj4gPiA+IDIuMTguMAo+ID4gPiAKPiA+ID4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gZHJp LWRldmVsIG1haWxpbmcgbGlzdAo+ID4gPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCj4gPiAKPiA+IC0tIAo+ID4gVmlsbGUgU3lyasOkbMOkCj4gPiBJbnRlbAo+IAo+IC0t IAo+IENoZWVycywKPiBBbGV4IEcKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==