All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: implement x86-compatible KPTI cmdline options
Date: Tue, 28 Aug 2018 18:40:05 +0100	[thread overview]
Message-ID: <20180828174005.GD20375@arm.com> (raw)
In-Reply-To: <1535110807-9104-1-git-send-email-stanislav.kholmanskikh@oracle.com>

On Fri, Aug 24, 2018 at 02:40:07PM +0300, Stanislav Kholmanskikh wrote:
> Both x86 and arm64 have KPTI. On both the archs the KPTI state
> can be controlled via kernel cmdline, but using different options.
> For x86 there are 'pti' and 'nopti', for arm64 - the undocumented 'kpti'
> option.
> 
> Having two distinct options for one feature seems to be unnecessary,
> and may complicate things a bit in mixed environments, so unification
> here seems to be a good idea.
> 
> I think x86 is a better candidate to serve as the common basis, since
> a) its options are already documented, b) it has KPTI merged earlier,
> c) it's more popular platform.
> 
> This patch implements 'pti' and 'nopti' for arm64, keeping 'kpti'
> for backwards compatibility.
> 
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt |    4 +-
>  arch/arm64/kernel/cpufeature.c                  |   41 +++++++++++++++++++++++
>  2 files changed, 43 insertions(+), 2 deletions(-)

Is there a real need for this? Most architectures don't have parity on
command-line options, and the ship has already sailed for this option.
We didn't deliberately diverge, but by the time we realised that x86 had
chosen 'pti', we'd already grown backports (e.g. Android) using 'kpti'.
For a while we had 'kaiser', but that got changed early enough.

The important thing is that it defaults safe, so I'm not really inclined
to merge this patch.

Will

  reply	other threads:[~2018-08-28 17:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24 11:40 [PATCH] arm64: implement x86-compatible KPTI cmdline options Stanislav Kholmanskikh
2018-08-28 17:40 ` Will Deacon [this message]
2018-10-01 12:48   ` Stanislav Kholmanskikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180828174005.GD20375@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.