From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <ming.lei@redhat.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, Omar Sandoval <osandov@fb.com>,
Christoph Hellwig <hch@lst.de>,
Don Brace <don.brace@microsemi.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Mike Snitzer <snitzer@redhat.com>, Hannes Reinecke <hare@suse.de>,
Laurence Oberman <loberman@redhat.com>,
Bart Van Assche <bart.vanassche@wdc.com>
Subject: Re: [PATCH 0/2] scsi: revert two commits for avoiding host-wide host_busy counter for scsi_mq
Date: Tue, 28 Aug 2018 10:54:16 -0700 [thread overview]
Message-ID: <20180828175416.GA18173@vader> (raw)
In-Reply-To: <a0d4b20a-add0-8f47-b94d-070209477280@kernel.dk>
On Mon, Aug 27, 2018 at 08:52:34AM -0600, Jens Axboe wrote:
> On 8/27/18 1:24 AM, Ming Lei wrote:
> > Hi,
> >
> > There is fundamental issue in commit 328728630d9f2bf1 (scsi: core: avoid
> > host-wide host_busy counter for scsi_mq) because SCSI's host busy counter
> > may not be same with counter of blk-mq's inflight tags, especially in case
> > of none io scheduler.
> >
> > So please revert the two commits.
>
> Please do, they break changing write cache mode on my SATA drives. You
> can add my tested-by and/or reported-by to this.
Jens, how does it break? Could we add a blktest for it?
next prev parent reply other threads:[~2018-08-28 17:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 7:24 [PATCH 0/2] scsi: revert two commits for avoiding host-wide host_busy counter for scsi_mq Ming Lei
2018-08-27 7:24 ` [PATCH 1/2] Revert "scsi: core: fix scsi_host_queue_ready" Ming Lei
2018-08-27 7:24 ` [PATCH 2/2] Revert "scsi: core: avoid host-wide host_busy counter for scsi_mq" Ming Lei
2018-08-27 14:52 ` [PATCH 0/2] scsi: revert two commits for avoiding host-wide host_busy counter for scsi_mq Jens Axboe
2018-08-28 17:54 ` Omar Sandoval [this message]
2018-08-28 17:57 ` Jens Axboe
2018-08-27 17:00 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180828175416.GA18173@vader \
--to=osandov@osandov.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=don.brace@microsemi.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kashyap.desai@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.