From: Arkadiusz Lis <areklis909@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: jfrederich@gmail.com, jon.nettleton@gmail.com, dsd@laptop.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: One Laptop Per Child: add function argument names
Date: Tue, 28 Aug 2018 21:34:57 +0200 [thread overview]
Message-ID: <20180828193457.GA8780@arek-VirtualBox> (raw)
In-Reply-To: <20180827175213.GA27361@kroah.com>
On Mon, Aug 27, 2018 at 07:52:13PM +0200, Greg KH wrote:
> On Thu, Aug 09, 2018 at 06:23:59PM +0200, Arkadiusz Lis wrote:
> > Add function argument names to pointers to functions
> > in struct dcon_platform_data: init, set_dconload and read_status
> > This commit removes checkpatch.pl warning.
> >
> > Signed-off-by: Arkadiusz Lis <areklis909@gmail.com>
> > ---
> > drivers/staging/olpc_dcon/olpc_dcon.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
> > index fa89bb9..0ce1a7a 100644
> > --- a/drivers/staging/olpc_dcon/olpc_dcon.h
> > +++ b/drivers/staging/olpc_dcon/olpc_dcon.h
> > @@ -91,10 +91,10 @@ struct dcon_priv {
> > };
> >
> > struct dcon_platform_data {
> > - int (*init)(struct dcon_priv *);
> > + int (*init)(struct dcon_priv *dcon);
> > void (*bus_stabilize_wiggle)(void);
> > - void (*set_dconload)(int);
> > - int (*read_status)(u8 *);
> > + void (*set_dconload)(int val);
> > + int (*read_status)(u8 *status);
> > };
> >
> > #include <linux/interrupt.h>
> > --
> > 1.9.1
> >
> > _______________________________________________
> > devel mailing list
> > devel@linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
> Patch did not apply to my tree at all. Please rebase against the latest
> linux-next and resend.
>
> thanks,
>
> greg k-h
Hi Greg,
It seems this issue was already fixed with commit 9b59883c14267ccf2c3f9d260bd6fb0dc9478fa1, hence the conflict.
My patch is redundant
Regards,
Arek
prev parent reply other threads:[~2018-08-28 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 16:23 [PATCH] Staging: One Laptop Per Child: add function argument names Arkadiusz Lis
2018-08-27 17:52 ` Greg KH
2018-08-28 19:34 ` Arkadiusz Lis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180828193457.GA8780@arek-VirtualBox \
--to=areklis909@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dsd@laptop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jfrederich@gmail.com \
--cc=jon.nettleton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.