All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jasper Kcoding <jasperkcoding@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] amlogic: board p212: Fix Ethernet PHY init
Date: Tue, 28 Aug 2018 22:26:33 +0200	[thread overview]
Message-ID: <20180828202633.7842-1-jasperkcoding@gmail.com> (raw)

Without this patch the Ethernet PHY on the p212 board does not get fully configured.
When this happens Ethernet does not function.

The similar libretech-cc and khadas-vim boards have this code already.
That's why the Ethernet on these boards do work.
---
 board/amlogic/p212/p212.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/amlogic/p212/p212.c b/board/amlogic/p212/p212.c
index 06c2eaee47..d5ce5397f3 100644
--- a/board/amlogic/p212/p212.c
+++ b/board/amlogic/p212/p212.c
@@ -29,7 +29,7 @@ int misc_init_r(void)
 	char serial[EFUSE_SN_SIZE];
 	ssize_t len;
 
-	meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, 0);
+	meson_gx_eth_init(PHY_INTERFACE_MODE_RMII, MESON_GXL_USE_INTERNAL_RMII_PHY);
 
 	if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
 		len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
-- 
2.11.0

             reply	other threads:[~2018-08-28 20:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 20:26 Jasper Kcoding [this message]
2018-09-03 12:57 ` [U-Boot] [PATCH] amlogic: board p212: Fix Ethernet PHY init Neil Armstrong
2018-09-03 20:14 ` Jasper kcoding
2018-09-06 13:45   ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180828202633.7842-1-jasperkcoding@gmail.com \
    --to=jasperkcoding@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.