From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-watchdog@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [RFC PATCH v2 1/4] watchdog: core: add mechanism to prevent removing if NOWAYOUT
Date: Tue, 28 Aug 2018 13:47:04 -0700 [thread overview]
Message-ID: <20180828204704.GA31691@roeck-us.net> (raw)
In-Reply-To: <20180828200739.ghu5trdp7jq6ixiz@katana>
On Tue, Aug 28, 2018 at 10:07:40PM +0200, Wolfram Sang wrote:
> Hi Guenter,
>
> > > + __driver.remove = NULL; \
> >
> > Does that really do any good ? If I understand correctly, the only
> > impact is that the platform driver remove function will believe that
> > nothing needs to be done on removal. See platform_drv_remove().
>
> This might be biased for my use case. Not calling remove will also leave
> the clock for that module enabled. But true, the platform device will be
> removed and without proper cleanup, there could be dangling pointers.
>
For many drivers the watchdog device would not be removed. That would
indeed be fatal.
> In general, what do you think of this approach if we'd left out the
> above line?
>
LGTM without that line.
Thanks,
Guenter
next prev parent reply other threads:[~2018-08-29 0:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 19:14 [RFC PATCH v2 0/4] watchdog: prevent removing a driver if NOWAYOUT Wolfram Sang
2018-08-28 19:14 ` [RFC PATCH v2 1/4] watchdog: core: add mechanism to prevent removing " Wolfram Sang
2018-08-28 19:33 ` Guenter Roeck
2018-08-28 20:07 ` Wolfram Sang
2018-08-28 20:47 ` Guenter Roeck [this message]
2018-08-28 19:14 ` [RFC PATCH v2 2/4] watchdog: renesas_wdt: avoid " Wolfram Sang
2018-08-28 19:14 ` [RFC PATCH v2 3/4] watchdog: core: add module_watchdog_pci_driver() Wolfram Sang
2018-08-28 19:14 ` [RFC PATCH v2 4/4] watchdog: i6300esb: avoid removing if NOWAYOUT Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180828204704.GA31691@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.