From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fv3eF-0003J8-IA for qemu-devel@nongnu.org; Wed, 29 Aug 2018 12:48:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fv3eB-0005sJ-JW for qemu-devel@nongnu.org; Wed, 29 Aug 2018 12:48:51 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46038 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fv3eB-0005rE-Cs for qemu-devel@nongnu.org; Wed, 29 Aug 2018 12:48:47 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0EB534001868 for ; Wed, 29 Aug 2018 16:48:47 +0000 (UTC) Date: Wed, 29 Aug 2018 17:48:41 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180829164841.GP4199@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180827222322.26009-1-marcandre.lureau@redhat.com> <20180827222322.26009-4-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180827222322.26009-4-marcandre.lureau@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/9] chardev: use a child source for qio input source List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, armbru@redhat.com On Tue, Aug 28, 2018 at 12:23:16AM +0200, Marc-Andr=C3=A9 Lureau wrote: > GLib child source were added with version 2.28. We can use them now > that we bumped our requirement to 2.40. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > chardev/char-io.c | 48 +++++------------------------------------------ > 1 file changed, 5 insertions(+), 43 deletions(-) Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|