From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v4] drm/i915: Re-apply "Perform link quality check, unconditionally during long pulse" Date: Wed, 29 Aug 2018 14:22:35 -0700 Message-ID: <20180829212235.GL6418@intel.com> References: <20180825191035.3945-1-lyude@redhat.com> <871sak5hdu.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lyude Paul Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jan-Marek Glogowski , stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBdWcgMjcsIDIwMTggYXQgMDE6Mzk6MDJQTSAtMDQwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBPbiBNb24sIDIwMTgtMDgtMjcgYXQgMTE6NDMgKzAzMDAsIEphbmkgTmlrdWxhIHdyb3Rl Ogo+ID4gT24gU2F0LCAyNSBBdWcgMjAxOCwgTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4g d3JvdGU6Cj4gPiA+IEZyb206IEphbi1NYXJlayBHbG9nb3dza2kgPGdsb2dvd0BmYmlob21lLmRl Pgo+ID4gPiAKPiA+ID4gVGhpcyByZS1hcHBsaWVzIHRoZSB3b3JrYXJvdW5kIGZvciAic29tZSBE UCBzaW5rcywgW3doaWNoXSBhcmUgYQo+ID4gPiBsaXR0bGUgbnV0cyIgZnJvbSBjb21taXQgMWEz NjE0N2JiOTM5ICgiZHJtL2k5MTU6IFBlcmZvcm0gbGluawo+ID4gPiBxdWFsaXR5IGNoZWNrIHVu Y29uZGl0aW9uYWxseSBkdXJpbmcgbG9uZyBwdWxzZSIpLgo+ID4gPiBJdCBtYWtlcyB0aGUgc2Vj b25kYXJ5IEFPQyBFMjQ2MFAgbW9uaXRvciBjb25uZWN0ZWQgdmlhIERQIHRvIGFuCj4gPiA+IGFj ZXIgVmVyaXRvbiBONDY0MEcgdXNhYmxlIGFnYWluLgo+ID4gPiAKPiA+ID4gVGhpcyBodW5rIHdh cyBkcm9wcGVkIGluIGNvbW1pdCBjODVkMjAwZTgzMjEgKCJkcm0vaTkxNTogTW92ZSBTU1QKPiA+ ID4gRFAgbGluayByZXRyYWluaW5nIGludG8gdGhlIC0+cG9zdF9ob3RwbHVnKCkgaG9vayIpCj4g PiA+IAo+ID4gPiBGaXhlczogYzg1ZDIwMGU4MzIxICgiZHJtL2k5MTU6IE1vdmUgU1NUIERQIGxp bmsgcmV0cmFpbmluZyBpbnRvIHRoZQo+ID4gPiAtPnBvc3RfaG90cGx1ZygpIGhvb2siKQo+ID4g PiBbQ2xlYW5lZCB1cCBjb21taXQgbWVzc2FnZSwgYWRkZWQgc3RhYmxlIGNjXQo+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29tPgo+ID4gPiBTaWduZWQtb2Zm LWJ5OiBKYW4tTWFyZWsgR2xvZ293c2tpIDxnbG9nb3dAZmJpaG9tZS5kZT4KPiA+ID4gQ2M6IHN0 YWJsZUB2Z2VyLmtlcm5lbC5vcmcKPiA+ID4gLS0tCj4gPiA+IFJlc2VuZGluZyB0aGlzIHRvIHVw ZGF0ZSBwYXRjaHdvcms7IHdpbGwgcHVzaCBpbiBhIGxpdHRsZSBiaXQKPiA+IAo+ID4gSXMgdGhl cmUgYSBidWd6aWxsYT8gUmVmZXJlbmNlIHRvIGEgbGlzdCBkaXNjdXNzaW9uPyBTb21ldGhpbmcg d2l0aCBhCj4gPiBkbWVzZyB3aGVyZSBzb21lb25lIGNhbiBhY3R1YWxseSB2ZXJpZnkgdGhpcyBp cyB0aGUgcmlnaHQgZml4Pwo+IFRoaXMgcGF0Y2ggaGFzIGFjdHVhbGx5IGJlZW4gb24gdGhlIGxp c3QgZm9yIGEgd2hpbGUgbm93LUkgaGF2ZSBoYWQgbWRuYXZhcmUKPiB0YWtlIGEgbG9vayBhdCBp dCBhcyB3ZWxsICh0aGV5IHNhaWQgaXQgbG9va2VkIGZpbmUgd2l0aCB0aGUgb25seSBjaGFuZ2Ug YmVpbmcKPiBpbiByZWdhcmRzIHRvIHRoZSBjb21tZW50KSwgYW5kIGl0J2QgYmVlbiBvbiB0aGUg bGlzdCBmb3IgYSB3aGlsZSBhbHJlYWR5Lgo+IAo+ID4gCj4gPiBJTU8gbmVlZHMgYW4gYWNrIGZy b20gVmlsbGUgdG9vLiBIZSBzaG91bGQgYmUgaW4gQ2M6IGluIHRoZSBmaXJzdCBwbGFjZQo+ID4g YXMgdGhlIGF1dGhvciBvZiB0aGUgcmVncmVzc2luZyBjb21taXQuCj4gPiAKPiA+ICdkaW0gZml4 ZXMgYzg1ZDIwMGU4MzIxJyBnaXZlcyB5b3UgdGhlIG91dHB1dDoKPiBhYWFoLUkgaGFkIHRob3Vn aHQgaXQgd2FzIGp1c3QgZm9yIGdlbmVyYXRpbmcgdGhlIEZpeGVzIGxpbmUsIEkgd2lsbCBiZSBt b3JlCj4gY2FyZWZ1bCBhYm91dCB0aGF0IGluIHRoZSBmdXR1cmUKCkhpIEx5dWRlLAoKSSB1bmRl cnN0YW5kIHRoYXQgdGhpcyBwYXRjaCB3YXMgYSB3aGlsZSBvbiB0aGUgbWFpbGluZyBsaXN0IGFu ZCBubwpwcm9wZXIgYXR0ZW50aW9uLCBidXQgYmVzaWRlcyB0aGUgY29tbWl0IG1lc3NhZ2UgaW5m b3JtYXRpb24gdGhhdApkaW0gaXMgZ2VuZXJhdGluZyBJIGhhdmUgYSBmZWVsaW5nIG5vdyB0aGF0 IHRoaXMgcGF0Y2ggd2Fzbid0IHF1aXRlCnJlYWR5IHlldCBhbmQgc2hvdWxkbid0IGJlIHJ1c2hl ZCBpbiBsaWtlIGl0IHdhcy4KClNpbmNlIHlvdSBtb2RpZmllZCBmZXcgdmVyc2lvbnMgaWRlYWxs eSBpdCB3b3VsZCBiZSBnb29kIHRvIGhhdmUgZXh0cmEgZXllcwphbmQgdGhlIG1hbmRhdG9yeSAi UmV2aWV3ZWQtYnkiIHRoZXJlLgoKQWxzbyBpdCBpcyBhIGdvb2QgaWRlYSB0byBnaXZlIGZldyBk YXlzIGZvciBkaWZmZXJlbnQgdGltZXpvbmVzIHRvCmNvbW1lbnQgb3V0IChhZnRlciB0aGUgcmUt c3BpbmcgSSBtZWFuKQoKQW5kIGZpbmFsbHkgYmFzZWQgb24gdGhlIGRpc2N1c3Npb25zIGl0IHNl ZW1zIHRoYXQgdGhlcmUgaXMgc3RpbGwKc29tZSB3b3JrIHRvIGdldCBkb25lIG9yIGEgZGlmZmVy ZW50IHdheSB0byBoYW5kbGUgdGhpcyBvdGhlcgp0aGlzIGJhY2sgYW5kIGZvcnRoIG9mIHJlYXBw bHktcmV2ZXJ0LXJlYXBwbHkuLi4KCkkganVzdCBub3RpY2VkIGl0IHdoZW4gcHJlcGFyaW5nIGRy bS1pbnRlbC1maXhlcyBwdWxsIHJlcXVlc3QuCgpTaW5jZSBJJ20gbm90IDEwMCUgY29uZmlkZW50 IHRoaXMgcGF0Y2ggc2hvdWxkIGJlIGhlcmUgSSdtIHJlbW92aW5nIGl0CmZyb20gdGhpcyB3ZWVr J3MgcHVsbCByZXF1ZXN0LgoKQnV0IHByb2JhYmx5IGFkZGluZyBpdCBuZXh0IHdlZWsgaWYgSmFu aSBhbmQgVmlsbGUgZ2l2ZSBhbmQgYWNrCm9yIGluZGljYXRpb24gdGhhdCBpdCBpcyByaWdodCBv ciBhdCBsZWFzdCBoZSBiZXN0IHdlIGNvdWxkIGRvIG5vdy4KCnRoYW5rcywKUm9kcmlnby4KCgo+ ID4gCj4gPiBGaXhlczogYzg1ZDIwMGU4MzIxICgiZHJtL2k5MTU6IE1vdmUgU1NUIERQIGxpbmsg cmV0cmFpbmluZyBpbnRvIHRoZQo+ID4gLT5wb3N0X2hvdHBsdWcoKSBob29rIikKPiA+IENjOiBN YW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+ID4gQ2M6IE1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBMeXVk ZSBQYXVsIDxseXVkZUByZWRoYXQuY29tPgo+ID4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3Vs YUBsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGlu ZW5AbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGlu dGVsLmNvbT4KPiA+IENjOiBpbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBDYzog PHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgdjQuMTcrCj4gPiAKPiA+IEJSLAo+ID4gSmFuaS4K PiA+IAo+ID4gPiAKPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCAzMyAr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAx OSBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+IGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBpbmRleCBiM2Y2ZjA0YzNjN2QuLmRiODUxNTE3MTI3MCAx MDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+IEBAIC00MzMzLDE4ICs0 MzMzLDYgQEAgaW50ZWxfZHBfbmVlZHNfbGlua19yZXRyYWluKHN0cnVjdCBpbnRlbF9kcAo+ID4g PiAqaW50ZWxfZHApCj4gPiA+ICAJcmV0dXJuICFkcm1fZHBfY2hhbm5lbF9lcV9vayhsaW5rX3N0 YXR1cywgaW50ZWxfZHAtPmxhbmVfY291bnQpOwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+IC0vKgo+ ID4gPiAtICogSWYgZGlzcGxheSBpcyBub3cgY29ubmVjdGVkIGNoZWNrIGxpbmtzIHN0YXR1cywK PiA+ID4gLSAqIHRoZXJlIGhhcyBiZWVuIGtub3duIGlzc3VlcyBvZiBsaW5rIGxvc3MgdHJpZ2dl cmluZwo+ID4gPiAtICogbG9uZyBwdWxzZS4KPiA+ID4gLSAqCj4gPiA+IC0gKiBTb21lIHNpbmtz IChlZy4gQVNVUyBQQjI4N1EpIHNlZW0gdG8gcGVyZm9ybSBzb21lCj4gPiA+IC0gKiB3ZWlyZCBI UEQgcGluZyBwb25nIGR1cmluZyBtb2Rlc2V0cy4gU28gd2UgY2FuIGFwcGFyZW50bHkKPiA+ID4g LSAqIGVuZCB1cCB3aXRoIEhQRCBnb2luZyBsb3cgZHVyaW5nIGEgbW9kZXNldCwgYW5kIHRoZW4K PiA+ID4gLSAqIGdvaW5nIGJhY2sgdXAgc29vbiBhZnRlci4gQW5kIG9uY2UgdGhhdCBoYXBwZW5z IHdlIG11c3QKPiA+ID4gLSAqIHJldHJhaW4gdGhlIGxpbmsgdG8gZ2V0IGEgcGljdHVyZS4gVGhh dCdzIGluIGNhc2Ugbm8KPiA+ID4gLSAqIHVzZXJzcGFjZSBjb21wb25lbnQgcmVhY3RlZCB0byBp bnRlcm1pdHRlbnQgSFBEIGRpcC4KPiA+ID4gLSAqLwo+ID4gPiAgaW50IGludGVsX2RwX3JldHJh aW5fbGluayhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiA+ID4gIAkJCSAgc3RydWN0 IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4ICpjdHgpCj4gPiA+ICB7Cj4gPiA+IEBAIC01MDMxLDcg KzUwMTksOCBAQCBpbnRlbF9kcF91bnNldF9lZGlkKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAp Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gIHN0YXRpYyBpbnQKPiA+ID4gLWludGVsX2RwX2xvbmdf cHVsc2Uoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ID4gPiAraW50ZWxfZHBf bG9uZ19wdWxzZShzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0b3IsCj4gPiA+ICsJCSAg ICBzdHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHggKmN0eCkKPiA+ID4gIHsKPiA+ID4gIAlz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNvbm5lY3Rvci0+YmFz ZS5kZXYpOwo+ID4gPiAgCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAgPSBpbnRlbF9hdHRhY2hl ZF9kcCgmY29ubmVjdG9yLT5iYXNlKTsKPiA+ID4gQEAgLTUwOTAsNiArNTA3OSwyMiBAQCBpbnRl bF9kcF9sb25nX3B1bHNlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IKPiA+ID4gKmNvbm5lY3RvcikK PiA+ID4gIAkJICovCj4gPiA+ICAJCXN0YXR1cyA9IGNvbm5lY3Rvcl9zdGF0dXNfZGlzY29ubmVj dGVkOwo+ID4gPiAgCQlnb3RvIG91dDsKPiA+ID4gKwl9IGVsc2Ugewo+ID4gPiArCQkvKgo+ID4g PiArCQkgKiBJZiBkaXNwbGF5IGlzIG5vdyBjb25uZWN0ZWQgY2hlY2sgbGlua3Mgc3RhdHVzLAo+ ID4gPiArCQkgKiB0aGVyZSBoYXMgYmVlbiBrbm93biBpc3N1ZXMgb2YgbGluayBsb3NzIHRyaWdn ZXJpbmcKPiA+ID4gKwkJICogbG9uZyBwdWxzZS4KPiA+ID4gKwkJICoKPiA+ID4gKwkJICogU29t ZSBzaW5rcyAoZWcuIEFTVVMgUEIyODdRKSBzZWVtIHRvIHBlcmZvcm0gc29tZQo+ID4gPiArCQkg KiB3ZWlyZCBIUEQgcGluZyBwb25nIGR1cmluZyBtb2Rlc2V0cy4gU28gd2UgY2FuIGFwcGFyZW50 bHkKPiA+ID4gKwkJICogZW5kIHVwIHdpdGggSFBEIGdvaW5nIGxvdyBkdXJpbmcgYSBtb2Rlc2V0 LCBhbmQgdGhlbgo+ID4gPiArCQkgKiBnb2luZyBiYWNrIHVwIHNvb24gYWZ0ZXIuIEFuZCBvbmNl IHRoYXQgaGFwcGVucyB3ZSBtdXN0Cj4gPiA+ICsJCSAqIHJldHJhaW4gdGhlIGxpbmsgdG8gZ2V0 IGEgcGljdHVyZS4gVGhhdCdzIGluIGNhc2Ugbm8KPiA+ID4gKwkJICogdXNlcnNwYWNlIGNvbXBv bmVudCByZWFjdGVkIHRvIGludGVybWl0dGVudCBIUEQgZGlwLgo+ID4gPiArCQkgKi8KPiA+ID4g KwkJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIgPSAmZHBfdG9fZGlnX3BvcnQoaW50ZWxf ZHApLQo+ID4gPiA+YmFzZTsKPiA+ID4gKwo+ID4gPiArCQlpbnRlbF9kcF9yZXRyYWluX2xpbmso ZW5jb2RlciwgY3R4KTsKPiA+ID4gIAl9Cj4gPiA+ICAKPiA+ID4gIAkvKgo+ID4gPiBAQCAtNTE1 MSw3ICs1MTU2LDcgQEAgaW50ZWxfZHBfZGV0ZWN0KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25u ZWN0b3IsCj4gPiA+ICAJCQkJcmV0dXJuIHJldDsKPiA+ID4gIAkJfQo+ID4gPiAgCj4gPiA+IC0J CXN0YXR1cyA9IGludGVsX2RwX2xvbmdfcHVsc2UoaW50ZWxfZHAtPmF0dGFjaGVkX2Nvbm5lY3Rv cik7Cj4gPiA+ICsJCXN0YXR1cyA9IGludGVsX2RwX2xvbmdfcHVsc2UoaW50ZWxfZHAtPmF0dGFj aGVkX2Nvbm5lY3RvciwKPiA+ID4gY3R4KTsKPiA+ID4gIAl9Cj4gPiA+ICAKPiA+ID4gIAlpbnRl bF9kcC0+ZGV0ZWN0X2RvbmUgPSBmYWxzZTsKPiA+IAo+ID4gCj4gLS0gCj4gQ2hlZXJzLAo+IAlM eXVkZSBQYXVsCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 904F9C433F5 for ; Wed, 29 Aug 2018 21:24:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 315D6205C9 for ; Wed, 29 Aug 2018 21:24:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 315D6205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728961AbeH3BXe (ORCPT ); Wed, 29 Aug 2018 21:23:34 -0400 Received: from mga18.intel.com ([134.134.136.126]:36968 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727449AbeH3BXe (ORCPT ); Wed, 29 Aug 2018 21:23:34 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2018 14:22:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,304,1531810800"; d="scan'208";a="84479265" Received: from pprajyul-mobl1.amr.corp.intel.com (HELO intel.com) ([10.254.115.13]) by fmsmga004.fm.intel.com with ESMTP; 29 Aug 2018 14:22:35 -0700 Date: Wed, 29 Aug 2018 14:22:35 -0700 From: Rodrigo Vivi To: Lyude Paul Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jan-Marek Glogowski , stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH v4] drm/i915: Re-apply "Perform link quality check, unconditionally during long pulse" Message-ID: <20180829212235.GL6418@intel.com> References: <20180825191035.3945-1-lyude@redhat.com> <871sak5hdu.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 27, 2018 at 01:39:02PM -0400, Lyude Paul wrote: > On Mon, 2018-08-27 at 11:43 +0300, Jani Nikula wrote: > > On Sat, 25 Aug 2018, Lyude Paul wrote: > > > From: Jan-Marek Glogowski > > > > > > This re-applies the workaround for "some DP sinks, [which] are a > > > little nuts" from commit 1a36147bb939 ("drm/i915: Perform link > > > quality check unconditionally during long pulse"). > > > It makes the secondary AOC E2460P monitor connected via DP to an > > > acer Veriton N4640G usable again. > > > > > > This hunk was dropped in commit c85d200e8321 ("drm/i915: Move SST > > > DP link retraining into the ->post_hotplug() hook") > > > > > > Fixes: c85d200e8321 ("drm/i915: Move SST DP link retraining into the > > > ->post_hotplug() hook") > > > [Cleaned up commit message, added stable cc] > > > Signed-off-by: Lyude Paul > > > Signed-off-by: Jan-Marek Glogowski > > > Cc: stable@vger.kernel.org > > > --- > > > Resending this to update patchwork; will push in a little bit > > > > Is there a bugzilla? Reference to a list discussion? Something with a > > dmesg where someone can actually verify this is the right fix? > This patch has actually been on the list for a while now-I have had mdnavare > take a look at it as well (they said it looked fine with the only change being > in regards to the comment), and it'd been on the list for a while already. > > > > > IMO needs an ack from Ville too. He should be in Cc: in the first place > > as the author of the regressing commit. > > > > 'dim fixes c85d200e8321' gives you the output: > aaah-I had thought it was just for generating the Fixes line, I will be more > careful about that in the future Hi Lyude, I understand that this patch was a while on the mailing list and no proper attention, but besides the commit message information that dim is generating I have a feeling now that this patch wasn't quite ready yet and shouldn't be rushed in like it was. Since you modified few versions ideally it would be good to have extra eyes and the mandatory "Reviewed-by" there. Also it is a good idea to give few days for different timezones to comment out (after the re-sping I mean) And finally based on the discussions it seems that there is still some work to get done or a different way to handle this other this back and forth of reapply-revert-reapply... I just noticed it when preparing drm-intel-fixes pull request. Since I'm not 100% confident this patch should be here I'm removing it from this week's pull request. But probably adding it next week if Jani and Ville give and ack or indication that it is right or at least he best we could do now. thanks, Rodrigo. > > > > Fixes: c85d200e8321 ("drm/i915: Move SST DP link retraining into the > > ->post_hotplug() hook") > > Cc: Manasi Navare > > Cc: Maarten Lankhorst > > Cc: Ville Syrjälä > > Cc: Lyude Paul > > Cc: Jani Nikula > > Cc: Joonas Lahtinen > > Cc: Rodrigo Vivi > > Cc: intel-gfx@lists.freedesktop.org > > Cc: # v4.17+ > > > > BR, > > Jani. > > > > > > > > drivers/gpu/drm/i915/intel_dp.c | 33 +++++++++++++++++++-------------- > > > 1 file changed, 19 insertions(+), 14 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c > > > b/drivers/gpu/drm/i915/intel_dp.c > > > index b3f6f04c3c7d..db8515171270 100644 > > > --- a/drivers/gpu/drm/i915/intel_dp.c > > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > > @@ -4333,18 +4333,6 @@ intel_dp_needs_link_retrain(struct intel_dp > > > *intel_dp) > > > return !drm_dp_channel_eq_ok(link_status, intel_dp->lane_count); > > > } > > > > > > -/* > > > - * If display is now connected check links status, > > > - * there has been known issues of link loss triggering > > > - * long pulse. > > > - * > > > - * Some sinks (eg. ASUS PB287Q) seem to perform some > > > - * weird HPD ping pong during modesets. So we can apparently > > > - * end up with HPD going low during a modeset, and then > > > - * going back up soon after. And once that happens we must > > > - * retrain the link to get a picture. That's in case no > > > - * userspace component reacted to intermittent HPD dip. > > > - */ > > > int intel_dp_retrain_link(struct intel_encoder *encoder, > > > struct drm_modeset_acquire_ctx *ctx) > > > { > > > @@ -5031,7 +5019,8 @@ intel_dp_unset_edid(struct intel_dp *intel_dp) > > > } > > > > > > static int > > > -intel_dp_long_pulse(struct intel_connector *connector) > > > +intel_dp_long_pulse(struct intel_connector *connector, > > > + struct drm_modeset_acquire_ctx *ctx) > > > { > > > struct drm_i915_private *dev_priv = to_i915(connector->base.dev); > > > struct intel_dp *intel_dp = intel_attached_dp(&connector->base); > > > @@ -5090,6 +5079,22 @@ intel_dp_long_pulse(struct intel_connector > > > *connector) > > > */ > > > status = connector_status_disconnected; > > > goto out; > > > + } else { > > > + /* > > > + * If display is now connected check links status, > > > + * there has been known issues of link loss triggering > > > + * long pulse. > > > + * > > > + * Some sinks (eg. ASUS PB287Q) seem to perform some > > > + * weird HPD ping pong during modesets. So we can apparently > > > + * end up with HPD going low during a modeset, and then > > > + * going back up soon after. And once that happens we must > > > + * retrain the link to get a picture. That's in case no > > > + * userspace component reacted to intermittent HPD dip. > > > + */ > > > + struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)- > > > >base; > > > + > > > + intel_dp_retrain_link(encoder, ctx); > > > } > > > > > > /* > > > @@ -5151,7 +5156,7 @@ intel_dp_detect(struct drm_connector *connector, > > > return ret; > > > } > > > > > > - status = intel_dp_long_pulse(intel_dp->attached_connector); > > > + status = intel_dp_long_pulse(intel_dp->attached_connector, > > > ctx); > > > } > > > > > > intel_dp->detect_done = false; > > > > > -- > Cheers, > Lyude Paul > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com ([134.134.136.126]:36968 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727449AbeH3BXe (ORCPT ); Wed, 29 Aug 2018 21:23:34 -0400 Date: Wed, 29 Aug 2018 14:22:35 -0700 From: Rodrigo Vivi To: Lyude Paul Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jan-Marek Glogowski , stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH v4] drm/i915: Re-apply "Perform link quality check, unconditionally during long pulse" Message-ID: <20180829212235.GL6418@intel.com> References: <20180825191035.3945-1-lyude@redhat.com> <871sak5hdu.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Mon, Aug 27, 2018 at 01:39:02PM -0400, Lyude Paul wrote: > On Mon, 2018-08-27 at 11:43 +0300, Jani Nikula wrote: > > On Sat, 25 Aug 2018, Lyude Paul wrote: > > > From: Jan-Marek Glogowski > > > > > > This re-applies the workaround for "some DP sinks, [which] are a > > > little nuts" from commit 1a36147bb939 ("drm/i915: Perform link > > > quality check unconditionally during long pulse"). > > > It makes the secondary AOC E2460P monitor connected via DP to an > > > acer Veriton N4640G usable again. > > > > > > This hunk was dropped in commit c85d200e8321 ("drm/i915: Move SST > > > DP link retraining into the ->post_hotplug() hook") > > > > > > Fixes: c85d200e8321 ("drm/i915: Move SST DP link retraining into the > > > ->post_hotplug() hook") > > > [Cleaned up commit message, added stable cc] > > > Signed-off-by: Lyude Paul > > > Signed-off-by: Jan-Marek Glogowski > > > Cc: stable@vger.kernel.org > > > --- > > > Resending this to update patchwork; will push in a little bit > > > > Is there a bugzilla? Reference to a list discussion? Something with a > > dmesg where someone can actually verify this is the right fix? > This patch has actually been on the list for a while now-I have had mdnavare > take a look at it as well (they said it looked fine with the only change being > in regards to the comment), and it'd been on the list for a while already. > > > > > IMO needs an ack from Ville too. He should be in Cc: in the first place > > as the author of the regressing commit. > > > > 'dim fixes c85d200e8321' gives you the output: > aaah-I had thought it was just for generating the Fixes line, I will be more > careful about that in the future Hi Lyude, I understand that this patch was a while on the mailing list and no proper attention, but besides the commit message information that dim is generating I have a feeling now that this patch wasn't quite ready yet and shouldn't be rushed in like it was. Since you modified few versions ideally it would be good to have extra eyes and the mandatory "Reviewed-by" there. Also it is a good idea to give few days for different timezones to comment out (after the re-sping I mean) And finally based on the discussions it seems that there is still some work to get done or a different way to handle this other this back and forth of reapply-revert-reapply... I just noticed it when preparing drm-intel-fixes pull request. Since I'm not 100% confident this patch should be here I'm removing it from this week's pull request. But probably adding it next week if Jani and Ville give and ack or indication that it is right or at least he best we could do now. thanks, Rodrigo. > > > > Fixes: c85d200e8321 ("drm/i915: Move SST DP link retraining into the > > ->post_hotplug() hook") > > Cc: Manasi Navare > > Cc: Maarten Lankhorst > > Cc: Ville Syrj�l� > > Cc: Lyude Paul > > Cc: Jani Nikula > > Cc: Joonas Lahtinen > > Cc: Rodrigo Vivi > > Cc: intel-gfx@lists.freedesktop.org > > Cc: # v4.17+ > > > > BR, > > Jani. > > > > > > > > drivers/gpu/drm/i915/intel_dp.c | 33 +++++++++++++++++++-------------- > > > 1 file changed, 19 insertions(+), 14 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c > > > b/drivers/gpu/drm/i915/intel_dp.c > > > index b3f6f04c3c7d..db8515171270 100644 > > > --- a/drivers/gpu/drm/i915/intel_dp.c > > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > > @@ -4333,18 +4333,6 @@ intel_dp_needs_link_retrain(struct intel_dp > > > *intel_dp) > > > return !drm_dp_channel_eq_ok(link_status, intel_dp->lane_count); > > > } > > > > > > -/* > > > - * If display is now connected check links status, > > > - * there has been known issues of link loss triggering > > > - * long pulse. > > > - * > > > - * Some sinks (eg. ASUS PB287Q) seem to perform some > > > - * weird HPD ping pong during modesets. So we can apparently > > > - * end up with HPD going low during a modeset, and then > > > - * going back up soon after. And once that happens we must > > > - * retrain the link to get a picture. That's in case no > > > - * userspace component reacted to intermittent HPD dip. > > > - */ > > > int intel_dp_retrain_link(struct intel_encoder *encoder, > > > struct drm_modeset_acquire_ctx *ctx) > > > { > > > @@ -5031,7 +5019,8 @@ intel_dp_unset_edid(struct intel_dp *intel_dp) > > > } > > > > > > static int > > > -intel_dp_long_pulse(struct intel_connector *connector) > > > +intel_dp_long_pulse(struct intel_connector *connector, > > > + struct drm_modeset_acquire_ctx *ctx) > > > { > > > struct drm_i915_private *dev_priv = to_i915(connector->base.dev); > > > struct intel_dp *intel_dp = intel_attached_dp(&connector->base); > > > @@ -5090,6 +5079,22 @@ intel_dp_long_pulse(struct intel_connector > > > *connector) > > > */ > > > status = connector_status_disconnected; > > > goto out; > > > + } else { > > > + /* > > > + * If display is now connected check links status, > > > + * there has been known issues of link loss triggering > > > + * long pulse. > > > + * > > > + * Some sinks (eg. ASUS PB287Q) seem to perform some > > > + * weird HPD ping pong during modesets. So we can apparently > > > + * end up with HPD going low during a modeset, and then > > > + * going back up soon after. And once that happens we must > > > + * retrain the link to get a picture. That's in case no > > > + * userspace component reacted to intermittent HPD dip. > > > + */ > > > + struct intel_encoder *encoder = &dp_to_dig_port(intel_dp)- > > > >base; > > > + > > > + intel_dp_retrain_link(encoder, ctx); > > > } > > > > > > /* > > > @@ -5151,7 +5156,7 @@ intel_dp_detect(struct drm_connector *connector, > > > return ret; > > > } > > > > > > - status = intel_dp_long_pulse(intel_dp->attached_connector); > > > + status = intel_dp_long_pulse(intel_dp->attached_connector, > > > ctx); > > > } > > > > > > intel_dp->detect_done = false; > > > > > -- > Cheers, > Lyude Paul > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx