From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 29 Aug 2018 21:47:58 +0200 Subject: [Buildroot] [PATCH 2/2] python-falcon: new package In-Reply-To: References: <20180828101618.4746-1-grzegorz@blach.pl> <20180828101618.4746-2-grzegorz@blach.pl> Message-ID: <20180829214758.718d5e7f@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Joseph, On Tue, 28 Aug 2018 09:34:56 -0700, Joseph Kogut wrote: > I know python-falcon supports compiling itself using Cython, would it > be helpful to do something like: > > ifeq ($(BR2_PACKAGE_HOST_PYTHON_CYTHON),y) > PYTHON_FALCON_DEPENDENCIES += host-cython > endif I am not very familiar with Cython. How does that work, what does that do ? Is it sufficient for Cython to be installed in $(HOST_DIR) to allow python-falcon to detect it and use it ? > So that if host-cython is selected, python-falcon will utilize it during setup? > > It might also be helpful to mention in the help text that the package > will optionally compile with Cython for enhanced performance, though > I'm not sure if that's the Buildroot way of doing things, maybe > someone else can chime in. Yes, if there are some optional dependencies, we can mention them in the package Config.in help text. Could you provide a follow-up adding this Cython support in python-falcon ? Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com