From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH v2 1/3] ASoC: cs4265: SOC_SINGLE register value error fix Date: Thu, 30 Aug 2018 10:11:42 +0100 Message-ID: <20180830091142.GD32322@imbe.wolfsonmicro.main> References: <20180829233802.22032-1-flatmax@flatmax.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) by alsa0.perex.cz (Postfix) with ESMTP id 6776F26781F for ; Thu, 30 Aug 2018 11:11:46 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20180829233802.22032-1-flatmax@flatmax.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Matt Flax Cc: alsa-devel@alsa-project.org, Mark Brown , Brian Austin , Paul Handrigan List-Id: alsa-devel@alsa-project.org On Thu, Aug 30, 2018 at 09:38:00AM +1000, Matt Flax wrote: > The cs4265 driver declares the "MMTLR Data Switch" register setting with > a 0 register value rather then the 0x12 register (CS4265_SPDIF_CTL2). > This incorrect value causes alsamixer to fault with the output : > cannot load mixer controls: Input/output error > > This patch corrects the register value. alsamixer now runs. > > Signed-off-by: Matt Flax > --- > > Acked-by: Paul Handrigan > Reviewed-by: Charles Keepax These wanted to be above the --- so they are added into the commit message when the maintainer applies the commit. Probably not worth resending for it, but keep in mind for future. Thanks, Charles