From: Greg Edwards <gedwards@ddn.com>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH v2] target/iblock: split T10 PI SGL across command bios
Date: Thu, 30 Aug 2018 14:46:59 +0000 [thread overview]
Message-ID: <20180830144659.GA8203@psuche> (raw)
In-Reply-To: <20180829203631.11753-1-gedwards@ddn.com>
On Wed, Aug 29, 2018 at 06:23:52PM -0500, Mike Christie wrote:
>
> Can you still hit the issue where t_prot_nents > BIO_MAX_PAGES so
> bio_integrity_alloc fails or is t_prot_nents always going to be smaller.
> Was wondering why you dropped that from the last patch.
There was a vhost bug that was artificially inflating the size of the
PI SGL by including both the protection and data in the PI SGL [1]. In
testing with that patch applied, I haven't seen the PI SGL get anywhere
close to BIO_MAX_PAGES. That said, you're right, we should probably
retain that safety check. I'll add it back for a v3. Thanks for the
feedback.
Greg
[1] https://lists.linuxfoundation.org/pipermail/virtualization/2018-August/039106.html
prev parent reply other threads:[~2018-08-30 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 20:36 [PATCH v2] target/iblock: split T10 PI SGL across command bios Greg Edwards
2018-08-29 23:23 ` Mike Christie
2018-08-30 14:46 ` Greg Edwards [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830144659.GA8203@psuche \
--to=gedwards@ddn.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.