From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/ringbuffer: Delay after invalidating gen6+ xcs Date: Thu, 30 Aug 2018 18:45:45 +0300 Message-ID: <20180830154545.GN5565@intel.com> References: <20180828170429.28492-1-chris@chris-wilson.co.uk> <20180828170429.28492-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3DF86E12A for ; Thu, 30 Aug 2018 15:45:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180828170429.28492-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMjgsIDIwMTggYXQgMDY6MDQ6MjlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IER1cmluZyBzdHJlc3MgdGVzdGluZyBvZiBmdWxsLXBwZ3R0IChvbiBCYXl0cmFpbCBh dCBsZWFzdCksIHdlIGZvdW5kCj4gdGhhdCB0aGUgaW52YWxpZGF0aW9uIGFyb3VuZCBhIGNvbnRl eHQvbW0gc3dpdGNoIHdhcyBpbnN1ZmZpY2llbnQgKHdyaXRlcwo+IHdvdWxkIGdvIGFzdHJheSku IEFkZGluZyBhIHNlY29uZCBNSV9GTFVTSF9EVyBiYXJyaWVyIHByZXZlbnRzIHRoaXMsIGJ1dAo+ IGl0IGlzIHVuY2xlYXIgYXMgdG8gd2hldGhlciB0aGlzIGlzIG1lcmVseSBhIGRlbGF5aW5nIHRh Y3RpYyBvciBpZiBpdCBpcwo+IHRydWx5IHNlcmlhbGlzaW5nIHdpdGggdGhlIFRMQiBpbnZhbGlk YXRpb24uIEVpdGhlciB3YXksIGl0IGlzCj4gZW1waXJpY2FsbHkgcmVxdWlyZWQuCj4gCj4gQnVn emlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzcx NQo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr Pgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+ Cj4gQ2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IENj OiBNYXR0aGV3IEF1bGQgPG1hdHRoZXcud2lsbGlhbS5hdWxkQGdtYWlsLmNvbT4KPiBDYzogVHZy dGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgMTAxICsrKysrKysrKysrLS0tLS0tLS0t LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNDcgaW5zZXJ0aW9ucygrKSwgNTQgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IGluZGV4IGQ0MGY1 NWE4ZGMzNC4uOTUyYjYyNjliYWIwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3JpbmdidWZmZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Jp bmdidWZmZXIuYwo+IEBAIC0xOTQ0LDQwICsxOTQ0LDYyIEBAIHN0YXRpYyB2b2lkIGdlbjZfYnNk X3N1Ym1pdF9yZXF1ZXN0KHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJlcXVlc3QpCj4gIAlpbnRlbF91 bmNvcmVfZm9yY2V3YWtlX3B1dChkZXZfcHJpdiwgRk9SQ0VXQUtFX0FMTCk7Cj4gIH0KPiAgCj4g LXN0YXRpYyBpbnQgZ2VuNl9ic2RfcmluZ19mbHVzaChzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSwg dTMyIG1vZGUpCj4gK3N0YXRpYyBpbnQgZW1pdF9taV9mbHVzaF9kdyhzdHJ1Y3QgaTkxNV9yZXF1 ZXN0ICpycSwgdTMyIG1vZGUsIHUzMiBpbnZmbGFncykKPiAgewo+ICAJdTMyIGNtZCwgKmNzOwo+ ICAKPiAtCWNzID0gaW50ZWxfcmluZ19iZWdpbihycSwgNCk7Cj4gLQlpZiAoSVNfRVJSKGNzKSkK PiAtCQlyZXR1cm4gUFRSX0VSUihjcyk7Cj4gKwlkbyB7Cj4gKwkJY3MgPSBpbnRlbF9yaW5nX2Jl Z2luKHJxLCA0KTsKPiArCQlpZiAoSVNfRVJSKGNzKSkKPiArCQkJcmV0dXJuIFBUUl9FUlIoY3Mp Owo+ICAKPiAtCWNtZCA9IE1JX0ZMVVNIX0RXOwo+ICsJCWNtZCA9IE1JX0ZMVVNIX0RXOwo+ICAK PiAtCS8qIFdlIGFsd2F5cyByZXF1aXJlIGEgY29tbWFuZCBiYXJyaWVyIHNvIHRoYXQgc3Vic2Vx dWVudAo+IC0JICogY29tbWFuZHMsIHN1Y2ggYXMgYnJlYWRjcnVtYiBpbnRlcnJ1cHRzLCBhcmUg c3RyaWN0bHkgb3JkZXJlZAo+IC0JICogd3J0IHRoZSBjb250ZW50cyBvZiB0aGUgd3JpdGUgY2Fj aGUgYmVpbmcgZmx1c2hlZCB0byBtZW1vcnkKPiAtCSAqIChhbmQgdGh1cyBiZWluZyBjb2hlcmVu dCBmcm9tIHRoZSBDUFUpLgo+IC0JICovCj4gLQljbWQgfD0gTUlfRkxVU0hfRFdfU1RPUkVfSU5E RVggfCBNSV9GTFVTSF9EV19PUF9TVE9SRURXOwo+ICsJCS8qCj4gKwkJICogV2UgYWx3YXlzIHJl cXVpcmUgYSBjb21tYW5kIGJhcnJpZXIgc28gdGhhdCBzdWJzZXF1ZW50Cj4gKwkJICogY29tbWFu ZHMsIHN1Y2ggYXMgYnJlYWRjcnVtYiBpbnRlcnJ1cHRzLCBhcmUgc3RyaWN0bHkgb3JkZXJlZAo+ ICsJCSAqIHdydCB0aGUgY29udGVudHMgb2YgdGhlIHdyaXRlIGNhY2hlIGJlaW5nIGZsdXNoZWQg dG8gbWVtb3J5Cj4gKwkJICogKGFuZCB0aHVzIGJlaW5nIGNvaGVyZW50IGZyb20gdGhlIENQVSku Cj4gKwkJICovCj4gKwkJY21kIHw9IE1JX0ZMVVNIX0RXX1NUT1JFX0lOREVYIHwgTUlfRkxVU0hf RFdfT1BfU1RPUkVEVzsKPiAgCj4gLQkvKgo+IC0JICogQnNwZWMgdm9sIDFjLjUgLSB2aWRlbyBl bmdpbmUgY29tbWFuZCBzdHJlYW1lcjoKPiAtCSAqICJJZiBFTkFCTEVELCBhbGwgVExCcyB3aWxs IGJlIGludmFsaWRhdGVkIG9uY2UgdGhlIGZsdXNoCj4gLQkgKiBvcGVyYXRpb24gaXMgY29tcGxl dGUuIFRoaXMgYml0IGlzIG9ubHkgdmFsaWQgd2hlbiB0aGUKPiAtCSAqIFBvc3QtU3luYyBPcGVy YXRpb24gZmllbGQgaXMgYSB2YWx1ZSBvZiAxaCBvciAzaC4iCj4gLQkgKi8KPiAtCWlmIChtb2Rl ICYgRU1JVF9JTlZBTElEQVRFKQo+IC0JCWNtZCB8PSBNSV9JTlZBTElEQVRFX1RMQiB8IE1JX0lO VkFMSURBVEVfQlNEOwo+ICsJCS8qCj4gKwkJICogQnNwZWMgdm9sIDFjLjMgLSBibGl0dGVyIGVu Z2luZSBjb21tYW5kIHN0cmVhbWVyOgo+ICsJCSAqICJJZiBFTkFCTEVELCBhbGwgVExCcyB3aWxs IGJlIGludmFsaWRhdGVkIG9uY2UgdGhlIGZsdXNoCj4gKwkJICogb3BlcmF0aW9uIGlzIGNvbXBs ZXRlLiBUaGlzIGJpdCBpcyBvbmx5IHZhbGlkIHdoZW4gdGhlCj4gKwkJICogUG9zdC1TeW5jIE9w ZXJhdGlvbiBmaWVsZCBpcyBhIHZhbHVlIG9mIDFoIG9yIDNoLiIKPiArCQkgKi8KPiArCQlpZiAo bW9kZSAmIEVNSVRfSU5WQUxJREFURSkKPiArCQkJY21kIHw9IGludmZsYWdzOwo+ICsJCSpjcysr ID0gY21kOwo+ICsJCSpjcysrID0gSTkxNV9HRU1fSFdTX1NDUkFUQ0hfQUREUiB8IE1JX0ZMVVNI X0RXX1VTRV9HVFQ7Cj4gKwkJKmNzKysgPSAwOwo+ICsJCSpjcysrID0gTUlfTk9PUDsKPiArCQlp bnRlbF9yaW5nX2FkdmFuY2UocnEsIGNzKTsKPiArCj4gKwkJLyoKPiArCQkgKiBOb3Qgb25seSBk byB3ZSBuZWVkIGEgZnVsbCBiYXJyaWVyIChwb3N0LXN5bmMgd3JpdGUpIGFmdGVyCj4gKwkJICog aW52YWxpZGF0aW5nIHRoZSBUTEJzLCBidXQgd2UgbmVlZCB0byB3YWl0IGEgbGl0dGxlIGJpdAo+ ICsJCSAqIGxvbmdlci4gV2hldGhlciB0aGlzIGlzIG1lcmVseSBkZWxheWluZyB1cywgb3IgdGhl Cj4gKwkJICogc3Vic2VxdWVudCBmbHVzaCBpcyBhIGtleSBwYXJ0IG9mIHNlcmlhbGlzaW5nIHdp dGggdGhlCj4gKwkJICogcG9zdC1zeW5jIG9wLCB0aGlzIGV4dHJhIHBhc3MgYXBwZWFycyB2aXRh bCBiZWZvcmUgYQo+ICsJCSAqIG1tIHN3aXRjaCEKPiArCQkgKi8KPiArCQlpZiAoIShtb2RlICYg RU1JVF9JTlZBTElEQVRFKSkKPiArCQkJYnJlYWs7Cj4gKwo+ICsJCW1vZGUgJj0gfkVNSVRfSU5W QUxJREFURTsKPiArCX0gd2hpbGUgKDEpOwoKSSBmaW5kIHRoZSBsb29wIHRoaW5neSBzb21ld2hh dCBoYXJkIHRvIHJlYWQuIEknZCBwcm9iYWJseSBoYXZlCndyaXR0ZW4gaXQgYXMgc29tZXRoaW5n IGxpa2UKCnsKCWlmIChtb2RlICYgRU1JVF9JTlZBTElEQVRFKQoJCW1pX2ZsdXNoKElOVkFMSURB VEVfVExCKTsKCW1pX2ZsdXNoKDApOwp9CgpFaXRoZXIgd2F5IGl0IHNlZW1zIHRvIGRvIHdoYXQg aXQgc2F5cyBzbwpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KCj4gIAo+IC0JKmNzKysgPSBjbWQ7Cj4gLQkqY3MrKyA9IEk5MTVfR0VN X0hXU19TQ1JBVENIX0FERFIgfCBNSV9GTFVTSF9EV19VU0VfR1RUOwo+IC0JKmNzKysgPSAwOwo+ IC0JKmNzKysgPSBNSV9OT09QOwo+IC0JaW50ZWxfcmluZ19hZHZhbmNlKHJxLCBjcyk7Cj4gIAly ZXR1cm4gMDsKPiAgfQo+ICAKPiArc3RhdGljIGludCBnZW42X2JzZF9yaW5nX2ZsdXNoKHN0cnVj dCBpOTE1X3JlcXVlc3QgKnJxLCB1MzIgbW9kZSkKPiArewo+ICsJcmV0dXJuIGVtaXRfbWlfZmx1 c2hfZHcocnEsIG1vZGUsCj4gKwkJCQlNSV9JTlZBTElEQVRFX1RMQiB8IE1JX0lOVkFMSURBVEVf QlNEKTsKPiArfQo+ICsKPiAgc3RhdGljIGludAo+ICBoc3dfZW1pdF9iYl9zdGFydChzdHJ1Y3Qg aTkxNV9yZXF1ZXN0ICpycSwKPiAgCQkgIHU2NCBvZmZzZXQsIHUzMiBsZW4sCj4gQEAgLTIwMjIs MzYgKzIwNDQsNyBAQCBnZW42X2VtaXRfYmJfc3RhcnQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEs Cj4gIAo+ICBzdGF0aWMgaW50IGdlbjZfcmluZ19mbHVzaChzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpy cSwgdTMyIG1vZGUpCj4gIHsKPiAtCXUzMiBjbWQsICpjczsKPiAtCj4gLQljcyA9IGludGVsX3Jp bmdfYmVnaW4ocnEsIDQpOwo+IC0JaWYgKElTX0VSUihjcykpCj4gLQkJcmV0dXJuIFBUUl9FUlIo Y3MpOwo+IC0KPiAtCWNtZCA9IE1JX0ZMVVNIX0RXOwo+IC0KPiAtCS8qIFdlIGFsd2F5cyByZXF1 aXJlIGEgY29tbWFuZCBiYXJyaWVyIHNvIHRoYXQgc3Vic2VxdWVudAo+IC0JICogY29tbWFuZHMs IHN1Y2ggYXMgYnJlYWRjcnVtYiBpbnRlcnJ1cHRzLCBhcmUgc3RyaWN0bHkgb3JkZXJlZAo+IC0J ICogd3J0IHRoZSBjb250ZW50cyBvZiB0aGUgd3JpdGUgY2FjaGUgYmVpbmcgZmx1c2hlZCB0byBt ZW1vcnkKPiAtCSAqIChhbmQgdGh1cyBiZWluZyBjb2hlcmVudCBmcm9tIHRoZSBDUFUpLgo+IC0J ICovCj4gLQljbWQgfD0gTUlfRkxVU0hfRFdfU1RPUkVfSU5ERVggfCBNSV9GTFVTSF9EV19PUF9T VE9SRURXOwo+IC0KPiAtCS8qCj4gLQkgKiBCc3BlYyB2b2wgMWMuMyAtIGJsaXR0ZXIgZW5naW5l IGNvbW1hbmQgc3RyZWFtZXI6Cj4gLQkgKiAiSWYgRU5BQkxFRCwgYWxsIFRMQnMgd2lsbCBiZSBp bnZhbGlkYXRlZCBvbmNlIHRoZSBmbHVzaAo+IC0JICogb3BlcmF0aW9uIGlzIGNvbXBsZXRlLiBU aGlzIGJpdCBpcyBvbmx5IHZhbGlkIHdoZW4gdGhlCj4gLQkgKiBQb3N0LVN5bmMgT3BlcmF0aW9u IGZpZWxkIGlzIGEgdmFsdWUgb2YgMWggb3IgM2guIgo+IC0JICovCj4gLQlpZiAobW9kZSAmIEVN SVRfSU5WQUxJREFURSkKPiAtCQljbWQgfD0gTUlfSU5WQUxJREFURV9UTEI7Cj4gLQkqY3MrKyA9 IGNtZDsKPiAtCSpjcysrID0gSTkxNV9HRU1fSFdTX1NDUkFUQ0hfQUREUiB8IE1JX0ZMVVNIX0RX X1VTRV9HVFQ7Cj4gLQkqY3MrKyA9IDA7Cj4gLQkqY3MrKyA9IE1JX05PT1A7Cj4gLQlpbnRlbF9y aW5nX2FkdmFuY2UocnEsIGNzKTsKPiAtCj4gLQlyZXR1cm4gMDsKPiArCXJldHVybiBlbWl0X21p X2ZsdXNoX2R3KHJxLCBtb2RlLCBNSV9JTlZBTElEQVRFX1RMQik7Cj4gIH0KPiAgCj4gIHN0YXRp YyB2b2lkIGludGVsX3JpbmdfaW5pdF9zZW1hcGhvcmVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiAtLSAKPiAyLjE4LjAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==