From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fvSKV-0008UY-DU for qemu-devel@nongnu.org; Thu, 30 Aug 2018 15:10:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fvSKS-0003NW-Ac for qemu-devel@nongnu.org; Thu, 30 Aug 2018 15:10:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58806) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fvSKS-0003NA-4c for qemu-devel@nongnu.org; Thu, 30 Aug 2018 15:10:04 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5A99830832DC for ; Thu, 30 Aug 2018 19:10:03 +0000 (UTC) Date: Thu, 30 Aug 2018 16:09:58 -0300 From: Eduardo Habkost Message-ID: <20180830190958.GT8359@habkost.net> References: <20180830175019.16939-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180830175019.16939-1-marcandre.lureau@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] hostmem: no need to check for host_memory_backend_mr_inited() in alloc() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: qemu-devel@nongnu.org, imammedo@redhat.com On Thu, Aug 30, 2018 at 07:50:19PM +0200, Marc-Andr=E9 Lureau wrote: > memfd_backend_memory_alloc/file_backend_memory_alloc both needlessly > are are calling host_memory_backend_mr_inited() which creates an > illusion that alloc could be called multiple times but it isn't, it's > called once from UserCreatable complete(). >=20 > Suggested-by: Igor Mammedov > Signed-off-by: Marc-Andr=E9 Lureau If calling the function multiple times is a mistake, should we replace the checks with: assert(!host_memory_backend_mr_inited(backend)); ? > --- > backends/hostmem-file.c | 2 +- > backends/hostmem-memfd.c | 4 ---- > 2 files changed, 1 insertion(+), 5 deletions(-) >=20 > diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c > index 2476dcb435..5cd5fa75a7 100644 > --- a/backends/hostmem-file.c > +++ b/backends/hostmem-file.c > @@ -54,7 +54,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend,= Error **errp) > #ifndef CONFIG_LINUX > error_setg(errp, "-mem-path not supported on this host"); > #else > - if (!host_memory_backend_mr_inited(backend)) { > + { > gchar *path; > backend->force_prealloc =3D mem_prealloc; > path =3D object_get_canonical_path(OBJECT(backend)); > diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c > index abd52364db..7184918112 100644 > --- a/backends/hostmem-memfd.c > +++ b/backends/hostmem-memfd.c > @@ -44,10 +44,6 @@ memfd_backend_memory_alloc(HostMemoryBackend *backen= d, Error **errp) > return; > } > =20 > - if (host_memory_backend_mr_inited(backend)) { > - return; > - } > - > backend->force_prealloc =3D mem_prealloc; > fd =3D qemu_memfd_create(TYPE_MEMORY_BACKEND_MEMFD, backend->size, > m->hugetlb, m->hugetlbsize, m->seal ? > --=20 > 2.19.0.rc0.48.gb9dfa238d5 >=20 --=20 Eduardo