From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:41370 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727200AbeH3XX7 (ORCPT ); Thu, 30 Aug 2018 19:23:59 -0400 Date: Thu, 30 Aug 2018 15:20:12 -0400 From: Jerome Glisse To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates , Christoph Hellwig , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , Dan Williams , Benjamin Herrenschmidt , Alex Williamson , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH v5 00/13] Copy Offload in NVMe Fabrics with P2P PCI Memory Message-ID: <20180830192012.GG3529@redhat.com> References: <20180830185352.3369-1-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <20180830185352.3369-1-logang@deltatee.com> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Thu, Aug 30, 2018 at 12:53:39PM -0600, Logan Gunthorpe wrote: [...] > > When the PCI P2PDMA config option is selected the ACS bits in every > bridge port in the system are turned off to allow traffic to > pass freely behind the root port. At this time, the bit must be disabled > at boot so the IOMMU subsystem can correctly create the groups, though > this could be addressed in the future. There is no way to dynamically > disable the bit and alter the groups. Can you provide an example on how to test this ? Like kernel command line option, the doc patch does not have any such example. It would be nice to add. Maybe i have miss it in some of the patch. I just skimmed over for now. Cheers, J�r�me From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D322D21107828 for ; Thu, 30 Aug 2018 12:20:18 -0700 (PDT) Date: Thu, 30 Aug 2018 15:20:12 -0400 From: Jerome Glisse Subject: Re: [PATCH v5 00/13] Copy Offload in NVMe Fabrics with P2P PCI Memory Message-ID: <20180830192012.GG3529@redhat.com> References: <20180830185352.3369-1-logang@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180830185352.3369-1-logang@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, Alex Williamson , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , Benjamin Herrenschmidt , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-ID: On Thu, Aug 30, 2018 at 12:53:39PM -0600, Logan Gunthorpe wrote: [...] > = > When the PCI P2PDMA config option is selected the ACS bits in every > bridge port in the system are turned off to allow traffic to > pass freely behind the root port. At this time, the bit must be disabled > at boot so the IOMMU subsystem can correctly create the groups, though > this could be addressed in the future. There is no way to dynamically > disable the bit and alter the groups. Can you provide an example on how to test this ? Like kernel command line option, the doc patch does not have any such example. It would be nice to add. Maybe i have miss it in some of the patch. I just skimmed over for now. Cheers, J=E9r=F4me _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: jglisse@redhat.com (Jerome Glisse) Date: Thu, 30 Aug 2018 15:20:12 -0400 Subject: [PATCH v5 00/13] Copy Offload in NVMe Fabrics with P2P PCI Memory In-Reply-To: <20180830185352.3369-1-logang@deltatee.com> References: <20180830185352.3369-1-logang@deltatee.com> Message-ID: <20180830192012.GG3529@redhat.com> On Thu, Aug 30, 2018@12:53:39PM -0600, Logan Gunthorpe wrote: [...] > > When the PCI P2PDMA config option is selected the ACS bits in every > bridge port in the system are turned off to allow traffic to > pass freely behind the root port. At this time, the bit must be disabled > at boot so the IOMMU subsystem can correctly create the groups, though > this could be addressed in the future. There is no way to dynamically > disable the bit and alter the groups. Can you provide an example on how to test this ? Like kernel command line option, the doc patch does not have any such example. It would be nice to add. Maybe i have miss it in some of the patch. I just skimmed over for now. Cheers, J?r?me From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Thu, 30 Aug 2018 15:20:12 -0400 From: Jerome Glisse To: Logan Gunthorpe Subject: Re: [PATCH v5 00/13] Copy Offload in NVMe Fabrics with P2P PCI Memory Message-ID: <20180830192012.GG3529@redhat.com> References: <20180830185352.3369-1-logang@deltatee.com> MIME-Version: 1.0 In-Reply-To: <20180830185352.3369-1-logang@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Sagi Grimberg , linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen Bates , linux-block@vger.kernel.org, Alex Williamson , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , Benjamin Herrenschmidt , Bjorn Helgaas , Max Gurtovoy , Dan Williams , Christoph Hellwig Content-Type: text/plain; charset="iso-8859-1" Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Thu, Aug 30, 2018 at 12:53:39PM -0600, Logan Gunthorpe wrote: [...] > = > When the PCI P2PDMA config option is selected the ACS bits in every > bridge port in the system are turned off to allow traffic to > pass freely behind the root port. At this time, the bit must be disabled > at boot so the IOMMU subsystem can correctly create the groups, though > this could be addressed in the future. There is no way to dynamically > disable the bit and alter the groups. Can you provide an example on how to test this ? Like kernel command line option, the doc patch does not have any such example. It would be nice to add. Maybe i have miss it in some of the patch. I just skimmed over for now. Cheers, J=E9r=F4me _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Glisse Subject: Re: [PATCH v5 00/13] Copy Offload in NVMe Fabrics with P2P PCI Memory Date: Thu, 30 Aug 2018 15:20:12 -0400 Message-ID: <20180830192012.GG3529@redhat.com> References: <20180830185352.3369-1-logang@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20180830185352.3369-1-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alex Williamson , Jason Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= , Benjamin Herrenschmidt , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-Id: linux-rdma@vger.kernel.org On Thu, Aug 30, 2018 at 12:53:39PM -0600, Logan Gunthorpe wrote: [...] > = > When the PCI P2PDMA config option is selected the ACS bits in every > bridge port in the system are turned off to allow traffic to > pass freely behind the root port. At this time, the bit must be disabled > at boot so the IOMMU subsystem can correctly create the groups, though > this could be addressed in the future. There is no way to dynamically > disable the bit and alter the groups. Can you provide an example on how to test this ? Like kernel command line option, the doc patch does not have any such example. It would be nice to add. Maybe i have miss it in some of the patch. I just skimmed over for now. Cheers, J=E9r=F4me From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E522C433F4 for ; Thu, 30 Aug 2018 19:20:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E88112054F for ; Thu, 30 Aug 2018 19:20:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E88112054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727352AbeH3XX7 (ORCPT ); Thu, 30 Aug 2018 19:23:59 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:41370 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727200AbeH3XX7 (ORCPT ); Thu, 30 Aug 2018 19:23:59 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F39EB87A7C; Thu, 30 Aug 2018 19:20:17 +0000 (UTC) Received: from redhat.com (unknown [10.20.6.215]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D6712166BA1; Thu, 30 Aug 2018 19:20:14 +0000 (UTC) Date: Thu, 30 Aug 2018 15:20:12 -0400 From: Jerome Glisse To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-block@vger.kernel.org, Stephen Bates , Christoph Hellwig , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , Dan Williams , Benjamin Herrenschmidt , Alex Williamson , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH v5 00/13] Copy Offload in NVMe Fabrics with P2P PCI Memory Message-ID: <20180830192012.GG3529@redhat.com> References: <20180830185352.3369-1-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180830185352.3369-1-logang@deltatee.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 30 Aug 2018 19:20:18 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Thu, 30 Aug 2018 19:20:18 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jglisse@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 30, 2018 at 12:53:39PM -0600, Logan Gunthorpe wrote: [...] > > When the PCI P2PDMA config option is selected the ACS bits in every > bridge port in the system are turned off to allow traffic to > pass freely behind the root port. At this time, the bit must be disabled > at boot so the IOMMU subsystem can correctly create the groups, though > this could be addressed in the future. There is no way to dynamically > disable the bit and alter the groups. Can you provide an example on how to test this ? Like kernel command line option, the doc patch does not have any such example. It would be nice to add. Maybe i have miss it in some of the patch. I just skimmed over for now. Cheers, Jérôme