From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: [PATCH v8 0/3] Add support rockchip RGB output interface Date: Thu, 30 Aug 2018 23:12:04 +0200 Message-ID: <20180830211207.10480-1-heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: hjc@rock-chips.com Cc: linux-rockchip@lists.infradead.org, seanpaul@chromium.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: linux-rockchip.vger.kernel.org VGhpcyBwYXRjaGVzIGFkZCBzdXBwb3J0IHJvY2tjaGlwIFJHQiBvdXRwdXQsIFNvbWUgUm9ja2No aXAgQ1JUQ3MsIGxpa2UKcnYxMTA4IGFuZCBweDMwIGNhbiBkaXJlY3RseSBvdXRwdXQgcGFyYWxs ZWwgYW5kIHNlcmlhbCBSR0IgZGF0YSB0byBwYW5lbApvciB0byBjb252ZXJzaW9uIGNoaXAuClNv IGFkZCBhIGZlYXR1cmUtYml0IGZvciB2b3BzIHRvIG1hcmsgdGhlIGFiaWxpdHkgZm9yIHRoZXNl IGRpcmVjdCBvdXRwdXRzCmFuZCBhZGQgYW4gaW50ZXJuYWwgZW5jb2RlciBpbiB0aGF0IGNhc2Us IHRoYXQgY2FuIGF0dGFjaCB0byBicmlkZ2UgY2hpcHMKb3IgcGFuZWxzLgoKCkhpIFNhbmR5LAoK d2hpbGUgcmV2aWV3aW5nIG15IG93biBjb2RlIGluIHBhdGNoMSwgSSBmb3VuZCB0aGF0IGl0IHdh cyBtaXNzaW5nCmNvcnJlY3QgcHV0IGNhbGxzIGZvciBub2RlIGFuZCBwZGV2IGFuZCBhbHNvIG1h ZGUgaXQgYmVoYXZlIGJldHRlcgppZiBubyBkZXZpY2UgaXMgcHJlc2VudC4KCldoaWxlIHdlIGRv bid0IG5lZWQgdGhhdCByaWdodCBub3csIGl0IG1ha2VzIGl0IHBvc3NpYmxlIHRvCmRpc3Rpbmd1 aXNoIGJldHdlZW4gc3ViZHJpdmVyLCBleHRlcm5hbCBicmlkZ2Ugb3Igbm8gZGV2aWNlIGxhdGVy Cm9uIGlmIG5lZWRlZC4KCkkndmUgYWxzbyB1cGRhdGVkIHRoZSBkb2N1bWVudGF0aW9uIG9mIHRo ZSBmdW5jdGlvbiBhIGJpdCwgc28gdGhhdApwZW9wbGUgbG9va2luZyBhdCBpdCBjYW4gZ3Jhc3Ag aXQgaG9wZWZ1bGx5IGVhc2llciA6LSkKCkFuZCBmaW5hbGx5IEkndmUgZHJvcHBlZCB0aGUgUmV2 aWV3IHRhZyBmcm9tIE1hcmsuIEhlIGlzbid0IGF0ClJvY2tjaGlwIGZvciBhIHdoaWxlIG5vdyBh bmQgdGhlIGRyaXZlciBkaWQgY2hhbmdlIG92ZXIgdGltZSBhIGJpdC4KClNvIGlmIHlvdSBoYXZl IHRpbWUsIHBsZWFzZSB0YWtlIGEgZmluYWwgbG9vayBhdCBpdC4KClRoYW5rcwpIZWlrbwoKCkhl aWtvIFN0dWVibmVyICgxKToKICBkcm0vcm9ja2NoaXA6IGFkZCBmdW5jdGlvbiB0byBjaGVjayBp ZiBlbmRwb2ludCBpcyBhIHN1YmRyaXZlcgoKU2FuZHkgSHVhbmcgKDIpOgogIGRybS9yb2NrY2hp cDogQWRkIHN1cHBvcnQgZm9yIFJvY2tjaGlwIFNvYyBSR0Igb3V0cHV0IGludGVyZmFjZQogIGRy bS9yb2NrY2hpcDogQWRkIGRpcmVjdGx5IG91dHB1dCByZ2IgZmVhdHVyZSBmb3IgcHgzMAoKIGRy aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnICAgICAgICAgICAgfCAgMTEgKysKIGRyaXZl cnMvZ3B1L2RybS9yb2NrY2hpcC9NYWtlZmlsZSAgICAgICAgICAgfCAgIDEgKwogZHJpdmVycy9n cHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYuYyB8ICA0OCArKysrKysKIGRyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmggfCAgIDEgKwogZHJpdmVycy9ncHUv ZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYyB8ICAxNiArKwogZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuaCB8ICAgMSArCiBkcml2ZXJzL2dwdS9kcm0vcm9j a2NoaXAvcm9ja2NoaXBfcmdiLmMgICAgIHwgMTczICsrKysrKysrKysrKysrKysrKysrCiBkcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfcmdiLmggICAgIHwgIDIwICsrKwogZHJpdmVy cy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX3ZvcF9yZWcuYyB8ICAgMiArCiA5IGZpbGVzIGNo YW5nZWQsIDI3MyBpbnNlcnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUv ZHJtL3JvY2tjaGlwL3JvY2tjaGlwX3JnYi5jCiBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9n cHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX3JnYi5oCgotLSAKMi4xNy4wCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56CFEC433F5 for ; Thu, 30 Aug 2018 21:12:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A36D20835 for ; Thu, 30 Aug 2018 21:12:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A36D20835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727360AbeHaBQ0 (ORCPT ); Thu, 30 Aug 2018 21:16:26 -0400 Received: from gloria.sntech.de ([185.11.138.130]:55358 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726878AbeHaBQ0 (ORCPT ); Thu, 30 Aug 2018 21:16:26 -0400 Received: from ip5f5a866f.dynamic.kabel-deutschland.de ([95.90.134.111] helo=phil.fritz.box) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1fvUEh-00009T-EM; Thu, 30 Aug 2018 23:12:15 +0200 From: Heiko Stuebner To: hjc@rock-chips.com Cc: seanpaul@chromium.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Heiko Stuebner Subject: [PATCH v8 0/3] Add support rockchip RGB output interface Date: Thu, 30 Aug 2018 23:12:04 +0200 Message-Id: <20180830211207.10480-1-heiko@sntech.de> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patches add support rockchip RGB output, Some Rockchip CRTCs, like rv1108 and px30 can directly output parallel and serial RGB data to panel or to conversion chip. So add a feature-bit for vops to mark the ability for these direct outputs and add an internal encoder in that case, that can attach to bridge chips or panels. Hi Sandy, while reviewing my own code in patch1, I found that it was missing correct put calls for node and pdev and also made it behave better if no device is present. While we don't need that right now, it makes it possible to distinguish between subdriver, external bridge or no device later on if needed. I've also updated the documentation of the function a bit, so that people looking at it can grasp it hopefully easier :-) And finally I've dropped the Review tag from Mark. He isn't at Rockchip for a while now and the driver did change over time a bit. So if you have time, please take a final look at it. Thanks Heiko Heiko Stuebner (1): drm/rockchip: add function to check if endpoint is a subdriver Sandy Huang (2): drm/rockchip: Add support for Rockchip Soc RGB output interface drm/rockchip: Add directly output rgb feature for px30 drivers/gpu/drm/rockchip/Kconfig | 11 ++ drivers/gpu/drm/rockchip/Makefile | 1 + drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 48 ++++++ drivers/gpu/drm/rockchip/rockchip_drm_drv.h | 1 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 16 ++ drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/gpu/drm/rockchip/rockchip_rgb.c | 173 ++++++++++++++++++++ drivers/gpu/drm/rockchip/rockchip_rgb.h | 20 +++ drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 + 9 files changed, 273 insertions(+) create mode 100644 drivers/gpu/drm/rockchip/rockchip_rgb.c create mode 100644 drivers/gpu/drm/rockchip/rockchip_rgb.h -- 2.17.0