diff for duplicates of <20180831085303.GA12908@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 1219d4d..9a0baa2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -67,9 +67,9 @@ On Fri, Aug 31, 2018 at 11:40:57AM +0300, Jarkko Sakkinen wrote: > > --- /dev/null > > +++ b/Documentation/security/keys/mktme.rst > > @@ -0,0 +1,69 @@ -> > +===================== +> > +========================================== > > +Keys for Multi-Key Total Memory Encryption -> > +===================== +> > +========================================== > > + > > +Keys for Multi-Key Total Memory Encryption (MKTME) are a new key type > > +added to the existing kernel key ring service. @@ -122,7 +122,7 @@ On Fri, Aug 31, 2018 at 11:40:57AM +0300, Jarkko Sakkinen wrote: > > +Sample usage MK-TME Key Service API with mktme_mprotect() API:: > > + > > + Add a key:: -> > + key = add_key(mktme, name, "userkey" tweakD", strlen(argv[3]), +> > + key = add_key(mktme, name, "userkey=22 tweak=44", strlen(argv[3]), > > + KEY_SPEC_USER_KEYRING); > > + Map memory:: > > + ptr = mmap(NULL, size, prot, MAP_ANONYMOUS, -1, 0); @@ -356,7 +356,7 @@ On Fri, Aug 31, 2018 at 11:40:57AM +0300, Jarkko Sakkinen wrote: > > + int i = mktme_max_keyids; > > + > > + for (i = mktme_max_keyids; i > 0; i--) -> > + if (mktme_map->id[i].serial = serial) +> > + if (mktme_map->id[i].serial == serial) > > + return i; > > + return -EINVAL; > > +} @@ -379,7 +379,7 @@ On Fri, Aug 31, 2018 at 11:40:57AM +0300, Jarkko Sakkinen wrote: > No TODO's allowed. > > > + -> > + if (ret = MKTME_PROG_SUCCESS) { +> > + if (ret == MKTME_PROG_SUCCESS) { > > + mktme_map->id[kprog->keyid].serial = 0; > > + mktme_map->id[kprog->keyid].count = 0; > > + mktme_mapped_keyids--; @@ -454,7 +454,7 @@ On Fri, Aug 31, 2018 at 11:40:57AM +0300, Jarkko Sakkinen wrote: > > + else > > + keyid = mktme_recover_key(); > > + -> > + if (keyid = 0) +> > + if (keyid == 0) > > + return -EDQUOT; > > + > > + kprog->keyid = keyid; @@ -462,7 +462,7 @@ On Fri, Aug 31, 2018 at 11:40:57AM +0300, Jarkko Sakkinen wrote: > > + > > + /* TODO ret = mktme_key_program(kprog); */ > > + ret = MKTME_PROG_SUCCESS; -> > + if (ret = MKTME_PROG_SUCCESS) { +> > + if (ret == MKTME_PROG_SUCCESS) { > > + mktme_map->id[keyid].serial = serial; > > + mktme_map->id[keyid].count = 0; > > + mktme_mapped_keyids++; @@ -560,7 +560,7 @@ On Fri, Aug 31, 2018 at 11:40:57AM +0300, Jarkko Sakkinen wrote: > > + char *p = datablob; > > + > > + while ((p = strsep(&datablob, " \t"))) { -> > + if (*p = '\0' || *p = ' ' || *p = '\t') +> > + if (*p == '\0' || *p == ' ' || *p == '\t') > > + continue; > > + token = match_token(p, mktme_tokens, args); > > + if (test_and_set_bit(token, &token_mask)) @@ -712,7 +712,7 @@ On Fri, Aug 31, 2018 at 11:40:57AM +0300, Jarkko Sakkinen wrote: > > > > -- > > To unsubscribe from this list: send the line "unsubscribe keyrings" in -> > the body of a message to majordomo@vger.kernel.org +> > the body of a message to majordomo at vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Even for RFC you should aim something that could be wrong but you think diff --git a/a/content_digest b/N1/content_digest index 45c0501..e56403e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\020180525233135.GA2774@alison-desk.jf.intel.com\0" "ref\020180831084057.GA9346@linux.intel.com\0" - "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" - "Subject\0Re: [RFC] KEYS: add a new type \"mktme\" to kernel key services\0" - "Date\0Fri, 31 Aug 2018 08:53:03 +0000\0" + "From\0jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)\0" + "Subject\0[RFC] KEYS: add a new type \"mktme\" to kernel key services\0" + "Date\0Fri, 31 Aug 2018 11:53:03 +0300\0" "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" @@ -75,9 +75,9 @@ "> > --- /dev/null\n" "> > +++ b/Documentation/security/keys/mktme.rst\n" "> > @@ -0,0 +1,69 @@\n" - "> > +=====================\n" + "> > +==========================================\n" "> > +Keys for Multi-Key Total Memory Encryption\n" - "> > +=====================\n" + "> > +==========================================\n" "> > +\n" "> > +Keys for Multi-Key Total Memory Encryption (MKTME) are a new key type\n" "> > +added to the existing kernel key ring service.\n" @@ -130,7 +130,7 @@ "> > +Sample usage MK-TME Key Service API with mktme_mprotect() API::\n" "> > +\n" "> > + Add a key::\n" - "> > + key = add_key(mktme, name, \"userkey\" tweakD\", strlen(argv[3]),\n" + "> > + key = add_key(mktme, name, \"userkey=22 tweak=44\", strlen(argv[3]),\n" "> > + KEY_SPEC_USER_KEYRING);\n" "> > + Map memory::\n" "> > + ptr = mmap(NULL, size, prot, MAP_ANONYMOUS, -1, 0);\n" @@ -364,7 +364,7 @@ "> > +\tint i = mktme_max_keyids;\n" "> > +\n" "> > +\tfor (i = mktme_max_keyids; i > 0; i--)\n" - "> > +\t\tif (mktme_map->id[i].serial = serial)\n" + "> > +\t\tif (mktme_map->id[i].serial == serial)\n" "> > +\t\t\treturn i;\n" "> > +\treturn -EINVAL;\n" "> > +}\n" @@ -387,7 +387,7 @@ "> No TODO's allowed.\n" "> \n" "> > +\n" - "> > +\tif (ret = MKTME_PROG_SUCCESS) {\n" + "> > +\tif (ret == MKTME_PROG_SUCCESS) {\n" "> > +\t\tmktme_map->id[kprog->keyid].serial = 0;\n" "> > +\t\tmktme_map->id[kprog->keyid].count = 0;\n" "> > +\t\tmktme_mapped_keyids--;\n" @@ -462,7 +462,7 @@ "> > +\telse\n" "> > +\t\tkeyid = mktme_recover_key();\n" "> > +\n" - "> > +\tif (keyid = 0)\n" + "> > +\tif (keyid == 0)\n" "> > +\t\treturn -EDQUOT;\n" "> > +\n" "> > +\tkprog->keyid = keyid;\n" @@ -470,7 +470,7 @@ "> > +\n" "> > +\t/* TODO ret = mktme_key_program(kprog); */\n" "> > +\tret = MKTME_PROG_SUCCESS;\n" - "> > +\tif (ret = MKTME_PROG_SUCCESS) {\n" + "> > +\tif (ret == MKTME_PROG_SUCCESS) {\n" "> > +\t\tmktme_map->id[keyid].serial = serial;\n" "> > +\t\tmktme_map->id[keyid].count = 0;\n" "> > +\t\tmktme_mapped_keyids++;\n" @@ -568,7 +568,7 @@ "> > +\tchar *p = datablob;\n" "> > +\n" "> > +\twhile ((p = strsep(&datablob, \" \\t\"))) {\n" - "> > +\t\tif (*p = '\\0' || *p = ' ' || *p = '\\t')\n" + "> > +\t\tif (*p == '\\0' || *p == ' ' || *p == '\\t')\n" "> > +\t\t\tcontinue;\n" "> > +\t\ttoken = match_token(p, mktme_tokens, args);\n" "> > +\t\tif (test_and_set_bit(token, &token_mask))\n" @@ -720,7 +720,7 @@ "> > \n" "> > --\n" "> > To unsubscribe from this list: send the line \"unsubscribe keyrings\" in\n" - "> > the body of a message to majordomo@vger.kernel.org\n" + "> > the body of a message to majordomo at vger.kernel.org\n" "> > More majordomo info at http://vger.kernel.org/majordomo-info.html\n" "> \n" "> Even for RFC you should aim something that could be wrong but you think\n" @@ -734,4 +734,4 @@ "\n" /Jarkko -272d52a3eec3552ae0cb88ddbdb46013be319ebd26da3df1046306bfed639e39 +a495404fff00b6b298a3f4f191352aeccdaa6431d612319c30be2ed9d3b53e47
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.