[LTP] [PATCH v1] Testing statx syscall Timestamp fields

[Petr Vorel <pvorel@suse.cz>]

Hi Subash,


> * statx_btime.c:The time before and after the execution of the create
> system call is noted.
> It is checked whether the birth time returned by statx lies in this range.

> * statx_atime.c:The time before and after the execution of the read
> system call is noted.
> It is checked whether the access time returned by statx lies in this range.

> * statx_mtime.c:The time before and after the execution of the write
> system call is noted.
> It is checked whether the modification time returned by statx lies in this range.

> * statx_ctime.c:The time before and after the execution of the chmod
> system call is noted.
> It is checked whether the status change time returned by statx lies in this range.

> Signed-off-by: Subash <subash@zilogic.com>
> Signed-off-by: Vaishnavi.D <vaishnavi.d@zilogic.com>
> ---
>  runtest/syscalls                                   | 10 +++
>  testcases/kernel/syscalls/statx/.gitignore         |  9 ++
>  testcases/kernel/syscalls/statx/Makefile           | 27 ++++++
>  testcases/kernel/syscalls/statx/statx_atime.c      | 96 +++++++++++++++++++++
>  testcases/kernel/syscalls/statx/statx_btime.c      | 90 ++++++++++++++++++++
>  testcases/kernel/syscalls/statx/statx_ctime.c      | 88 ++++++++++++++++++++
>  testcases/kernel/syscalls/statx/statx_mtime.c      | 97 ++++++++++++++++++++++
>  testcases/kernel/syscalls/statx/timestamp_helper.c | 52 ++++++++++++
>  testcases/kernel/syscalls/statx/timestamp_helper.h | 33 ++++++++
>  9 files changed, 502 insertions(+)
Although this patch is smaller that "[v6] Testing statx syscall" [1],
it'd still make sense to split it. Complex/big patchsets it's usually harder to
get merged.

...
> +++ b/runtest/syscalls
> @@ -1287,6 +1287,11 @@ statfs03_64 statfs03_64
>  statvfs01 statvfs01
>  statvfs02 statvfs02

> +statx01 statx01
> +statx02 statx02
> +statx03 statx03
> +statx04 statx04
This shouldn't be here (belongs to "[v6] Testing statx syscall" [1])

...
> +++ b/testcases/kernel/syscalls/statx/.gitignore
> @@ -0,0 +1,9 @@
> +/statx01
> +/statx02
> +/statx03
> +/statx04
The same here.

> +/timestamp_helper
> +/statx_atime
> +/statx_btime
> +/statx_ctime
> +/statx_mtime

....
> +++ b/testcases/kernel/syscalls/statx/statx_btime.c
> @@ -0,0 +1,90 @@
> +// SPDX-License-Identifier: GPL-2.0 or later
...
> +#include <stdio.h>
> +#include "tst_test.h"
> +#include "lapi/stat.h"
So you depend on "[v6] Testing statx syscall" [1].
Please read my comments to it.

> +#include "tst_timer.h"
> +#include "tst_safe_macros.h"
> +#include <sys/mount.h>
> +#include "timestamp_helper.h"
> +
> +#define MOUNT_POINT "mount_ext"
> +#define TEST_FILE MOUNT_POINT"/test_file.txt"
> +
> +static void create_file(void)
> +{
> +	int test_file_fd;
> +
> +	test_file_fd = SAFE_CREAT(TEST_FILE, 0666);
> +	SAFE_CLOSE(test_file_fd);
> +}
> +
> +static void test_statx_btime(void)
> +{
> +	struct statx buff;
> +	struct timespec before_time;
> +	struct timespec after_time;
> +	struct timespec statx_time;
> +
> +	clock_get_time(&before_time);
> +	clock_wait_tick();
> +	create_file();
> +	clock_wait_tick();
> +	clock_get_time(&after_time);
> +
> +	TEST(statx(AT_FDCWD, TEST_FILE, 0, STATX_ALL, &buff));
> +	if (TST_RET != 0)
> +		tst_brk(TFAIL | TTERRNO,
> +			"statx(AT_FDCWD, %s, 0, STATX_ALL, &buff)", TEST_FILE);
> +
> +	statx_timestamp_to_timespec(&buff.stx_btime, &statx_time);
> +
> +	if (tst_timespec_lt(statx_time, before_time))
> +		tst_res(TFAIL, "Birth time < before time");
> +	else if (tst_timespec_lt(after_time, statx_time))
> +		tst_res(TFAIL, "Birth time > after_time");
> +	else
> +		tst_res(TPASS, "Birth Time Passed\n");
> +
> +}
> +
> +void cleanup(void)
> +{
> +	SAFE_UNLINK(TEST_FILE);
> +}
> +
> +static struct tst_test test = {
> +	.test_all = test_statx_btime,
> +	.min_kver = "4.11",
> +	.needs_root = 1,
> +	.needs_tmpdir = 1,
> +	.mntpoint = MOUNT_POINT,
> +	.mount_device = 1,
> +	.dev_fs_type = "ext4",
> +	.dev_min_size = 512,
> +	.mnt_flags = MS_STRICTATIME,
> +	.cleanup = cleanup,
> +};
> diff --git a/testcases/kernel/syscalls/statx/statx_ctime.c b/testcases/kernel/syscalls/statx/statx_ctime.c
> new file mode 100644
> index 000000000..10aa2aa13
> --- /dev/null
> +++ b/testcases/kernel/syscalls/statx/statx_ctime.c
> @@ -0,0 +1,88 @@
> +// SPDX-License-Identifier: GPL-2.0 or later
> +/*
> + *  Copyright (c) Zilogic Systems Pvt. Ltd., 2018
> + *  Email : code@zilogic.com
> + *
> + * This program is free software;  you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY;  without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
> + * the GNU General Public License for more details.
> + */
> +/*
> + * Test case for statx_ctime.
> + *
> + * DESCRIPTION : The time before and after the execution of the chmod
> + * 	system call is noted. It is checked whether the status change
> + * 	time returned by statx lies in this range.
> + *
> + */
> +
> +#include <stdio.h>
> +#include "tst_test.h"
> +#include "tst_timer.h"
> +#include <sys/mount.h>
> +#include "tst_safe_macros.h"
> +#include "timestamp_helper.h"
> +
> +#define MOUNT_POINT "mount_ext"
> +#define TEST_FILE MOUNT_POINT"/test_file.txt"
> +
> +static void setup(void)
> +{
> +	int test_file_fd;
> +
> +	test_file_fd = SAFE_OPEN(TEST_FILE, O_CREAT | O_RDWR, 0666);
> +	SAFE_CLOSE(test_file_fd);
> +}
> +
> +static void test_statx_ctime(void)
> +{
> +	struct statx buff;
> +	struct timespec before_time;
> +	struct timespec after_time;
> +	struct timespec statx_time;
> +
> +	clock_get_time(&before_time);
> +	clock_wait_tick();
> +	SAFE_CHMOD(TEST_FILE, 0777);
> +	clock_wait_tick();
> +	clock_get_time(&after_time);
> +
> +	TEST(statx(AT_FDCWD, TEST_FILE, 0, STATX_ALL, &buff));
> +	if (TST_RET != 0)
> +		tst_brk(TFAIL | TTERRNO,
> +			"statx(AT_FDCWD, %s, 0, STATX_ALL, &buff)", TEST_FILE);
> +
> +	statx_timestamp_to_timespec(&buff.stx_ctime, &statx_time);
> +
> +	if (tst_timespec_lt(statx_time, before_time))
> +		tst_res(TFAIL, "Status change time < before time");
> +	else if (tst_timespec_lt(after_time, statx_time))
> +		tst_res(TFAIL, "Status change time > after_time");
> +	else
> +		tst_res(TPASS, "Status change time Passed\n");
> +}
> +
> +static void cleanup(void)
> +{
> +	SAFE_UNLINK(TEST_FILE);
> +}
> +
> +static struct tst_test test = {
> +	.setup = setup,
> +	.cleanup = cleanup,
> +	.test_all = test_statx_ctime,
> +	.min_kver = "4.11",
> +	.needs_root = 1,
> +	.needs_tmpdir = 1,
> +	.mntpoint = MOUNT_POINT,
> +	.mount_device = 1,
> +	.dev_fs_type = "ext4",
> +	.dev_min_size = 512,
> +	.mnt_flags = MS_STRICTATIME,
> +};
> diff --git a/testcases/kernel/syscalls/statx/statx_mtime.c b/testcases/kernel/syscalls/statx/statx_mtime.c
> new file mode 100644
> index 000000000..9e5522dff
> --- /dev/null
> +++ b/testcases/kernel/syscalls/statx/statx_mtime.c
> @@ -0,0 +1,97 @@
> +// SPDX-License-Identifier: GPL-2.0 or later
> +/*
> + *  Copyright (c) Zilogic Systems Pvt. Ltd., 2018
> + *  Email : code@zilogic.com
> + *
> + * This program is free software;  you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY;  without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See
> + * the GNU General Public License for more details.
> + */
> +/*
> + * Test case for statx_mtime.
> + *
> + * DESCRIPTION : The time before and after the execution of the write
> + * 	system call is noted. It is checked whether the modified time
> + * 	returned by statx lies in this range.
> + *
> + */
> +
> +#include <stdio.h>
> +#include "tst_test.h"
> +#include "tst_timer.h"
> +#include <sys/mount.h>
> +#include "tst_safe_macros.h"
> +#include "timestamp_helper.h"
> +
> +#define MOUNT_POINT "mount_ext"
> +#define TEST_FILE MOUNT_POINT"/test_file.txt"
> +#define SIZE 2
> +
> +static int test_file_fd;
> +
> +static void setup(void)
> +{
> +	test_file_fd = SAFE_OPEN(TEST_FILE, O_CREAT | O_RDWR, 0666);
> +}
> +
> +static void write_file(void)
> +{
> +	char data[SIZE] = "hi";
> +
> +	SAFE_WRITE(0, test_file_fd, data, sizeof(data));
> +}
> +
> +static void test_statx_mtime(void)
> +{
> +	struct statx buff;
> +	struct timespec before_time;
> +	struct timespec after_time;
> +	struct timespec statx_time;
> +
> +
> +	clock_get_time(&before_time);
> +	clock_wait_tick();
> +	write_file();
> +	clock_wait_tick();
> +	clock_get_time(&after_time);
> +
> +	TEST(statx(AT_FDCWD, TEST_FILE, 0, STATX_ALL, &buff));
> +	if (TST_RET != 0)
> +		tst_brk(TFAIL | TTERRNO,
> +			"statx(AT_FDCWD, %s, 0, STATX_ALL, &buff)", TEST_FILE);
> +
> +	statx_timestamp_to_timespec(&buff.stx_mtime, &statx_time);
> +
> +	if (tst_timespec_lt(statx_time, before_time))
> +		tst_res(TFAIL, "Modification time < before time");
> +	else if (tst_timespec_lt(after_time, statx_time))
> +		tst_res(TFAIL, "Modification time > after_time");
> +	else
> +		tst_res(TPASS, "Modification time Passed\n");
> +}
> +
> +static void cleanup(void)
> +{
> +	SAFE_CLOSE(test_file_fd);
> +	SAFE_UNLINK(TEST_FILE);
> +}
> +
> +static struct tst_test test = {
> +	.setup = setup,
> +	.cleanup = cleanup,
> +	.test_all = test_statx_mtime,
> +	.min_kver = "4.11",
> +	.needs_root = 1,
> +	.needs_tmpdir = 1,
> +	.mntpoint = MOUNT_POINT,
> +	.mount_device = 1,
> +	.dev_fs_type = "ext4",
> +	.dev_min_size = 512,
> +	.mnt_flags = MS_STRICTATIME,
> +};
> diff --git a/testcases/kernel/syscalls/statx/timestamp_helper.c b/testcases/kernel/syscalls/statx/timestamp_helper.c
> new file mode 100644
> index 000000000..d3cca7528
> --- /dev/null
> +++ b/testcases/kernel/syscalls/statx/timestamp_helper.c
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: GPL-2.0 or later
> +/*
> + * Copyright (c) Zilogic Systems Pvt. Ltd., 2018
> + * Email: code@zilogic.com
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#define _GNU_SOURCE
Why _GNU_SOURCE?

> +#define TST_NO_DEFAULT_MAIN
> +
> +
> +#include "timestamp_helper.h"
> +
> +void clock_wait_tick(void)
> +{
> +	struct timespec res;
> +	unsigned int usecs;
> +
> +	TEST(clock_getres(CLOCK_REALTIME_COARSE, &res));
> +	if (TST_RET != 0)
> +		tst_brk(TFAIL | TTERRNO, "Failed to get clock resolution");
Maybe this would make sense to move into library as SAFE_CLOCK_GETRES().

> +
> +	usecs = ((res.tv_sec * 1000000) + (res.tv_nsec / 1000)) * 1.5;
> +
> +	usleep(usecs);
> +}
> +
> +void clock_get_time(struct timespec *time)
> +{
> +	TEST(clock_gettime(CLOCK_REALTIME_COARSE, time));
> +	if (TST_RET != 0)
> +		tst_brk(TFAIL | TTERRNO, "Failed to get clock time");
> +}
The same here, as SAFE_CLOCK_GETTIME().

> +
> +#ifndef TIMESTAMP_HELPER
> +#define TIMESTAMP_HELPER
> +
> +#include <time.h>
> +#include "lapi/stat.h"
> +#include "tst_test.h"
> +#include "tst_safe_macros.h"
> +
> +void clock_wait_tick(void);
> +void clock_get_time(struct timespec *time);
> +void statx_timestamp_to_timespec(const struct statx_timestamp *timestamp,
> +				struct timespec *timespec);
> +
> +#endif


Kind regards,
Petr

[1] https://patchwork.ozlabs.org/patch/960900/