All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH ltp] syscalls/bind03: Add version compare according to behaviour difference.
Date: Fri, 31 Aug 2018 12:39:09 +0200	[thread overview]
Message-ID: <20180831103909.GB14565@dell5510> (raw)
In-Reply-To: <20180831093700.GD16417@rei.lan>

Hi,

> > > ISSUE:
> > >   The case is designed to test the behaviour diverse caused by kernel
> > >   commit 0fb44559ffd6. And it failed for the new behaviour.

> > > ACTION:
> > >   Add a version compare to split part of the test.

> > This is actually a not-yet fixed kernel bug as the correct errno to be
> > reported in this case is EADDRINUSE at least that is what I understand
> > after reading POSIX.

> Sigh, not enough coffee I would say, the rationale is correctly written
> in the patch from Michal.

> "in general, we do not want to change return code for given testcase and
>  old error (-EINVAL) is consistent with AF_INET(6)"

> Sorry for the confusion.

> > See:

> > https://patchwork.ozlabs.org/patch/782692/

I've already merged this fix, but as Cyril pointed out it might not be what is
wanted. I'll ask David Miller and Michal Kubecek at netdev ML.


Kind regards,
Petr

      reply	other threads:[~2018-08-31 10:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31 13:24 [LTP] [PATCH ltp] syscalls/bind03: Add version compare according to behaviour difference Junchi Chen
2018-08-31  8:37 ` Petr Vorel
2018-08-31  8:42   ` Cyril Hrubis
2018-09-07 10:12     ` Petr Vorel
2018-08-31  8:48   ` Xiao Yang
2018-08-31  9:34     ` Cyril Hrubis
2018-08-31  8:41 ` Cyril Hrubis
2018-08-31  9:37   ` Cyril Hrubis
2018-08-31 10:39     ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180831103909.GB14565@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.