From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 2/2] make: Add test target
Date: Fri, 31 Aug 2018 14:37:03 +0200 [thread overview]
Message-ID: <20180831123703.GA3015@dell5510> (raw)
In-Reply-To: <20180821140547.2509-3-pvorel@suse.cz>
Hi Jan,
> ----- Original Message -----
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > Makefile | 3 +++
> > lib/tests/Makefile | 3 +++
> > lib/tests/test.sh | 32 ++++++++++++++++++++++++++++++++
> > 3 files changed, 38 insertions(+)
> > create mode 100755 lib/tests/test.sh
> > +
> > +for i in $@; do
> > + echo "=== Testing '$i' ==="
> > + case $i in
> > + tst_checkpoint_wake_timeout|tst_record_childstatus)
> > + if [ "$i" = "tst_record_childstatus" ]; then
> > + echo "NOTE: expecting fail the test"
> > + ./$i || [ $? -eq 1 ]
> > + fi
> I'd prefer we fix the tests and make them return 0 if everything goes as expected.
Agree. But I took different folder. As Cyril pointed out, tests in lib/tests/
are for legacy API. I'm going to test new ones from lib/newlib_tests/.
As Christian works on #312 "Unit testing the shell library" [1], I'd like if
both shell and C tests had the same approach of testing.
I wonder whether to keep these tests in lib/tests/. At least some of them aren't
meant to be for unit testing (due expecting failing), nobody runs them, ...
[1] https://github.com/linux-test-project/ltp/issues/312
> Regards,
> Jan
prev parent reply other threads:[~2018-08-31 12:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 14:05 [LTP] [RFC PATCH 0/2] make test: Run C API tests Petr Vorel
2018-08-21 14:05 ` [LTP] [RFC PATCH 1/2] tests: Remove tst_safe_macros.c Petr Vorel
2018-08-21 14:05 ` [LTP] [RFC PATCH 2/2] make: Add test target Petr Vorel
2018-08-23 13:22 ` Jan Stancek
2018-08-24 15:01 ` Cyril Hrubis
2018-08-31 12:37 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831123703.GA3015@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.