From: Kalle Valo <kvalo@codeaurora.org>
To: Ganapathi Bhat <gbhat@marvell.com>
Cc: <linux-wireless@vger.kernel.org>,
Brian Norris <briannorris@chromium.org>,
Cathy Luo <cluo@marvell.com>, Zhiyuan Yang <yangzy@marvell.com>,
James Cao <jcao@marvell.com>, Rakesh Parmar <rakeshp@marvell.com>,
Vidya Dharmaraju <vidyad@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>
Subject: Re: [PATCH 1/2] mwifiex: do no submit URB in suspended state
Date: Fri, 31 Aug 2018 15:47:15 +0000 (UTC) [thread overview]
Message-ID: <20180831154715.32FA66053D@smtp.codeaurora.org> (raw)
In-Reply-To: <1534837982-31206-1-git-send-email-gbhat@marvell.com>
Ganapathi Bhat <gbhat@marvell.com> wrote:
> There is a possible race between USB suspend and main thread:
>
> 1. After processing the command response, main thread will submit
> rx_cmd URB back so as to process next command response, by
> calling mwifiex_usb_submit_rx_urb.
>
> 2. During USB suspend, the suspend handler will check if rx_cmd
> URB is pending(submitted) and if true, kill this URB.
>
> There is a possible race between #1 and #2, where rx_cmd URB will
> be submitted by main thread(#1) after the suspend handler check
> in #2.
>
> To fix this, check if device is already suspended in
> mwifiex_usb_submit_rx_urb, in which case do not submit the URB.
>
> Signed-off-by: Vidya Dharmaraju <vidyad@marvell.com>
> Signed-off-by: Cathy Luo <cluo@marvell.com>
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
2 patches applied to wireless-drivers-next.git, thanks.
7bd4628c2f31 mwifiex: do no submit URB in suspended state
33a164fa8a4c mwifex: free rx_cmd skb in suspended state
--
https://patchwork.kernel.org/patch/10571161/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2018-08-31 19:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 7:53 [PATCH 1/2] mwifiex: do no submit URB in suspended state Ganapathi Bhat
2018-08-21 7:53 ` [PATCH 2/2] mwifex: free rx_cmd skb " Ganapathi Bhat
2018-08-31 15:47 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831154715.32FA66053D@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=gbhat@marvell.com \
--cc=jcao@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rakeshp@marvell.com \
--cc=vidyad@marvell.com \
--cc=yangzy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.