All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] swig: Add Config.in.host
Date: Fri, 31 Aug 2018 23:31:28 +0200	[thread overview]
Message-ID: <20180831233128.613d3ec1@windsurf> (raw)
In-Reply-To: <20180831003757.19520-1-flatmax@flatmax.org>

Hello,

On Fri, 31 Aug 2018 10:37:57 +1000, Matt Flax wrote:
> This patch make select BR2_PACKAGE_HOST_SWIG work.

Actually, "select BR2_PACKAGE_HOST_SWIG" does not need to work. If you
need host-swig from another package, add "host-swig" to this package
<pkg>_DEPENDENCIES variable. Doing a "select BR2_PACKAGE_HOST_SWIG"
will not give you anything, because it won't guarantee that host-swig
is built before your package.

But anyway, I believe that swig may be needed when doing application
development around Buildroot, so I'm fine with having a visible
menuconfig option for this. I applied your patch with a reworked commit
log.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-08-31 21:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31  0:37 [Buildroot] [PATCH 1/1] swig: Add Config.in.host Matt Flax
2018-08-31 21:31 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180831233128.613d3ec1@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.