From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] linux/linux.mk: Use '-isystem' instead of '-I' in HOST_CFLAGS
Date: Sat, 1 Sep 2018 09:55:17 +0200 [thread overview]
Message-ID: <20180901095517.6ad46a12@windsurf> (raw)
In-Reply-To: <20180830095748.30297-1-david.degrave@mind.be>
Hello,
On Thu, 30 Aug 2018 11:57:48 +0200, David De Grave (Essensium/Mind)
wrote:
> Since the last update of the DTC package, linux build breaks at some point
> with the following error:
>
> In file included from {output}/host/include/libfdt.h:54:0,
> from scripts/dtc/libfdt/fdt.c:54:
> {output}/host/include/libfdt_env.h:82:24: error: redefinition of \
> ?fdt16_to_cpu?
> static inline uint16_t fdt16_to_cpu(fdt16_t x)
> ^~~~~~~~~~~~
> In file included from scripts/dtc/libfdt/fdt.c:51:0:
> scripts/dtc/libfdt/libfdt_env.h:81:24: note: previous definition of \
> ?fdt16_to_cpu? was here
>
> This is because the HOST_CFLAGS is added before Linux's makefile add it's
> own local ones (-Iscripts/dtc/libfdt), resulting in a mix of local and host
> headers beeing used.
>
> So, to fix this the '-I' is substituted by '-isystem' to let it search for
> the headers in the right location first.
>
> Signed-off-by: David De Grave (Essensium/Mind) <david.degrave@mind.be>
> ---
> linux/linux.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I suspect this one is superseded by your new patch series
http://patchwork.ozlabs.org/project/buildroot/list/?series=63524, so
I've marked this patch as Changes Requested.
Note that
http://patchwork.ozlabs.org/project/buildroot/list/?series=63524
doesn't contain PATCH 2/3 due to a patchwork issue when associating
patches to series, but PATCH 2/3 has been recorded by patchwork.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-01 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 9:57 [Buildroot] [PATCH 1/1] linux/linux.mk: Use '-isystem' instead of '-I' in HOST_CFLAGS David De Grave
2018-09-01 7:55 ` Thomas Petazzoni [this message]
2018-09-01 19:02 ` David De Grave
2018-09-03 22:30 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180901095517.6ad46a12@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.