From: Tom Rini <trini@konsulko.com>
To: "Lu.Jiang" <lu.jiang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 5/7] wic:direct:remove same entry when updating fstab
Date: Sun, 2 Sep 2018 22:51:35 -0400 [thread overview]
Message-ID: <20180903025135.GF26633@bill-the-cat> (raw)
In-Reply-To: <ba749679-939a-8060-42e3-2aa2718f8a80@windriver.com>
On Mon, Sep 03, 2018 at 10:00:45AM +0800, Lu.Jiang wrote:
> 在 2018年08月31日 21:54, Tom Rini 写道:
> >On Fri, Aug 31, 2018 at 10:15:08AM +0800, Jiang Lu wrote:
> >
> >>Remove same mountpoint entry when updating fstab.
> >>
> >>Signed-off-by: Jiang Lu <lu.jiang@windriver.com>
> >>---
> >> meta/recipes-support/wic/files/wic/plugins/imager/direct.py | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >>diff --git a/meta/recipes-support/wic/files/wic/plugins/imager/direct.py b/meta/recipes-support/wic/files/wic/plugins/imager/direct.py
> >>index f648db4..d3ebc9c 100644
> >>--- a/meta/recipes-support/wic/files/wic/plugins/imager/direct.py
> >>+++ b/meta/recipes-support/wic/files/wic/plugins/imager/direct.py
> >>@@ -163,6 +163,9 @@ class DirectPlugin(ImagerPlugin):
> >> opts = part.fsopts if part.fsopts else "defaults"
> >> line = "\t".join([device_name, part.mountpoint, part.fstype,
> >> opts, "0", "0"]) + "\n"
> >>+ for tmpline in fstab_lines:
> >>+ if part.mountpoint in tmpline:
> >>+ fstab_lines.remove(tmpline)
> >> fstab_lines.append(line)
> >> updated = True
> >Can you explain how this happens?
> >
> The patch intend to fix a issue when running wic on target.
>
> On target, I'd like wic create a new image based on current running rootfs.
> Then the fstab from running system need remove duplicated entry.
Please put something about this in the commit message, thanks.
--
Tom
next prev parent reply other threads:[~2018-09-03 2:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 2:15 [v2] [PATCH 0/7] wic:allow wic compile as an individual package Jiang Lu
2018-08-31 2:15 ` [PATCH 1/7] wic:enable wic compile as " Jiang Lu
2018-08-31 2:15 ` [PATCH 2/7] wic:move wic src into meta/receipt-support/wic Jiang Lu
2018-08-31 13:53 ` Tom Rini
2018-09-03 1:58 ` Lu.Jiang
2018-09-03 2:50 ` Tom Rini
2018-09-03 15:14 ` Tim Orling
2018-09-04 2:10 ` Lu.Jiang
2018-08-31 2:15 ` [PATCH 3/7] image_type_wic:add wic-native into depend Jiang Lu
2018-08-31 2:15 ` [PATCH 4/7] wic:allow wic run outof bb enviroment Jiang Lu
2018-08-31 2:15 ` [PATCH 5/7] wic:direct:remove same entry when updating fstab Jiang Lu
2018-08-31 13:54 ` Tom Rini
2018-09-03 2:00 ` Lu.Jiang
2018-09-03 2:51 ` Tom Rini [this message]
2018-08-31 2:15 ` [PATCH 6/7] wic:bootimg-efi:try other place for efi Jiang Lu
2018-08-31 13:52 ` Tom Rini
2018-09-03 2:01 ` Lu.Jiang
2018-09-04 2:15 ` Lu.Jiang
2018-09-04 2:26 ` Tom Rini
2018-09-04 2:33 ` Lu.Jiang
2018-09-05 0:33 ` Tom Rini
2018-09-05 2:32 ` Lu.Jiang
2018-09-05 13:41 ` Tom Rini
2018-08-31 2:15 ` [PATCH 7/7] wic:mkefidisk:add use-uuid for all partitions Jiang Lu
2018-08-31 13:55 ` Tom Rini
2018-09-07 3:02 ` [v2] [PATCH 0/7] wic:allow wic compile as an individual package Lu.Jiang
2018-09-07 12:19 ` Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2018-08-30 10:01 Jiang Lu
2018-08-30 10:01 ` [PATCH 5/7] wic:direct:remove same entry when updating fstab Jiang Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903025135.GF26633@bill-the-cat \
--to=trini@konsulko.com \
--cc=lu.jiang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.