From: Dave Chinner <david@fromorbit.com>
To: Allison Henderson <allison.henderson@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v8 00/28] Parent Pointers v8
Date: Mon, 3 Sep 2018 15:41:00 +1000 [thread overview]
Message-ID: <20180903054100.GP5631@dastard> (raw)
In-Reply-To: <1535484161-11059-1-git-send-email-allison.henderson@oracle.com>
On Tue, Aug 28, 2018 at 12:22:13PM -0700, Allison Henderson wrote:
> Hi all,
>
> This is the 8th version of parent pointer attributes for xfs. The goal of
> this patch set is to add a parent pointer attribute to each inode. The
> attribute name containing the parent inode, generation, and directory offset,
> while the attribute value contains the file name. This feature will enable
> future optimizations for online scrub, or any other feature that could make
> use of quickly deriving an inodes path from the mount point. This set also
> introduces deferred attribute operations, though it is currently only used by
> the new parent pointer code.
Another assert failure on generic/026:
SECTION -- xfs
FSTYP -- xfs (debug)
PLATFORM -- Linux/x86_64 test1 4.19.0-rc2-dgc+
MKFS_OPTIONS -- -f -m rmapbt=1,reflink=1 -i sparse=1 -b size=1k /dev/sdc
MOUNT_OPTIONS -- /dev/sdc /mnt/scratch
(though it appears block size has nothing to do with the failure as
all my other test VMs also failed on this test, too)
[ 368.699416] run fstests generic/026 at 2018-09-03 13:46:29
[ 376.651705] XFS: Assertion failed: tp->t_ticket != NULL, file: fs/xfs/xfs_trans.c, line: 952
[ 376.653346] ------------[ cut here ]------------
[ 376.654174] kernel BUG at fs/xfs/xfs_message.c:102!
[ 376.655537] invalid opcode: 0000 [#1] PREEMPT SMP
[ 376.656545] CPU: 0 PID: 12468 Comm: chacl Not tainted 4.19.0-rc2-dgc+ #653
[ 376.657742] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.1-1 04/01/2014
[ 376.659193] RIP: 0010:assfail+0x28/0x30
[ 376.659861] Code: c3 90 0f 1f 44 00 00 48 89 f1 41 89 d0 48 c7 c6 98 50 2e 82 48 89 fa 31 ff e8 64 f9 ff ff 80 3d f5 9a 0a 01 00 75 03 0f 0b c3 <0f> 0b 66 0f 1f 44 00 00 0f 1f 44 00 00 48 63 f6 49 8a
[ 376.663050] RSP: 0018:ffffc90000babaa0 EFLAGS: 00010202
[ 376.663950] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
[ 376.665167] RDX: 00000000ffffffc0 RSI: 000000000000000a RDI: ffffffff8227a5fc
[ 376.666397] RBP: ffffffff822e68d0 R08: 0000000000000000 R09: 0000000000000000
[ 376.667618] R10: 0000000000000008 R11: f000000000000000 R12: 0000000000000000
[ 376.668841] R13: ffff88002d236000 R14: ffffffff814d6701 R15: 0000000000000025
[ 376.670075] FS: 00007fd8e35dc740(0000) GS:ffff88003ec00000(0000) knlGS:0000000000000000
[ 376.671462] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 376.672451] CR2: 000055624ed0c000 CR3: 00000000292b5000 CR4: 00000000000006f0
[ 376.673678] Call Trace:
[ 376.674136] __xfs_trans_commit+0x35c/0x370
[ 376.674870] xfs_attr_set+0x241/0x2d0
[ 376.675510] __xfs_set_acl+0xf4/0x1a0
[ 376.676146] xfs_set_acl+0xa8/0x100
[ 376.676759] ? posix_acl_valid+0xb6/0xd0
[ 376.677444] ? set_posix_acl+0xa0/0xa0
[ 376.678108] posix_acl_xattr_set+0x3f/0x90
[ 376.678833] __vfs_setxattr+0x64/0x80
[ 376.679484] __vfs_setxattr_noperm+0x69/0x1a0
[ 376.680243] ? unlazy_walk+0x4c/0xb0
[ 376.680871] vfs_setxattr+0xa0/0xb0
[ 376.681485] setxattr+0x132/0x1a0
[ 376.682088] ? __handle_mm_fault+0x95b/0x10c0
[ 376.682850] ? __mnt_want_write+0x5e/0x90
[ 376.683547] ? preempt_count_sub+0x43/0x50
[ 376.684262] path_setxattr+0xbe/0xe0
[ 376.684884] __x64_sys_setxattr+0x27/0x30
[ 376.685584] do_syscall_64+0x5a/0x180
[ 376.686236] entry_SYSCALL_64_after_hwframe+0x49/0xbe
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-09-03 9:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 19:22 [PATCH v8 00/28] Parent Pointers v8 Allison Henderson
2018-08-28 19:22 ` [PATCH v8 01/28] xfs: Move fs/xfs/xfs_attr.h to fs/xfs/libxfs/xfs_attr.h Allison Henderson
2018-08-28 19:22 ` [PATCH v8 02/28] xfs: Add helper function xfs_attr_try_sf_addname Allison Henderson
2018-08-28 19:22 ` [PATCH v8 03/28] xfs: Add attibute set and helper functions Allison Henderson
2018-08-28 19:22 ` [PATCH v8 04/28] xfs: Add attibute remove " Allison Henderson
2018-08-28 19:22 ` [PATCH v8 05/28] xfs: Hold inode locks in xfs_ialloc Allison Henderson
2018-08-28 19:22 ` [PATCH v8 06/28] xfs: Add trans toggle to attr routines Allison Henderson
2018-08-28 19:22 ` [PATCH v8 07/28] xfs: Set up infastructure for deferred attribute operations Allison Henderson
2018-08-28 19:22 ` [PATCH v8 08/28] xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred Allison Henderson
2018-08-28 19:22 ` [PATCH v8 09/28] xfs: Add xfs_has_attr and subroutines Allison Henderson
2018-08-28 19:22 ` [PATCH v8 10/28] xfs: Add attr context to log item Allison Henderson
2018-08-28 19:22 ` [PATCH v8 11/28] xfs: Roll delayed attr operations by returning EAGAIN Allison Henderson
2018-08-28 19:22 ` [PATCH v8 12/28] xfs: Remove roll_trans boolean Allison Henderson
2018-08-28 19:22 ` [PATCH v8 13/28] xfs: Remove all strlen calls in all xfs_attr_* functions for attr names Allison Henderson
2018-08-28 19:22 ` [PATCH v8 14/28] xfs: get directory offset when adding directory name Allison Henderson
2018-08-28 19:22 ` [PATCH v8 15/28] xfs: get directory offset when removing " Allison Henderson
2018-08-28 19:22 ` [PATCH v8 16/28] xfs: get directory offset when replacing a " Allison Henderson
2018-08-28 19:22 ` [PATCH v8 17/28] xfs: add parent pointer support to attribute code Allison Henderson
2018-08-28 19:22 ` [PATCH v8 18/28] xfs: define parent pointer xattr format Allison Henderson
2018-08-28 19:22 ` [PATCH v8 19/28] xfs: extent transaction reservations for parent attributes Allison Henderson
2018-08-28 19:22 ` [PATCH v8 20/28] xfs: parent pointer attribute creation Allison Henderson
2018-08-28 19:22 ` [PATCH v8 21/28] xfs: add parent attributes to link Allison Henderson
2018-08-28 19:22 ` [PATCH v8 22/28] xfs: remove parent pointers in unlink Allison Henderson
2018-08-28 19:22 ` [PATCH v8 23/28] xfs: Add parent pointers to rename Allison Henderson
2018-09-03 3:20 ` Dave Chinner
2018-09-03 5:28 ` Amir Goldstein
2018-09-04 18:31 ` Allison Henderson
2018-09-04 18:31 ` Allison Henderson
2018-08-28 19:22 ` [PATCH v8 24/28] xfs: Add the parent pointer support to the superblock version 5 Allison Henderson
2018-08-28 19:22 ` [PATCH v8 25/28] xfs: Add helper function xfs_attr_list_context_init Allison Henderson
2018-08-28 19:22 ` [PATCH v8 26/28] xfs: Increase XFS_DEFER_OPS_NR_INODES to 4 Allison Henderson
2018-08-28 19:22 ` [PATCH v8 27/28] xfs: Add parent pointer ioctl Allison Henderson
2018-08-28 19:22 ` [PATCH v8 28/28] xfs: Add delayed attributes error tag Allison Henderson
2018-09-03 1:20 ` [PATCH v8 00/28] Parent Pointers v8 Dave Chinner
2018-09-03 1:40 ` Dave Chinner
2018-09-04 18:31 ` Allison Henderson
2018-09-03 5:41 ` Dave Chinner [this message]
2018-09-04 18:32 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903054100.GP5631@dastard \
--to=david@fromorbit.com \
--cc=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.