From: Borislav Petkov <bp@alien8.de>
To: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@intel.com>
Cc: "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Neri, Ricardo" <ricardo.neri@intel.com>,
"matt@codeblueprint.co.uk" <matt@codeblueprint.co.uk>,
Lee Chun-Yi <jlee@suse.com>, Al Stone <astone@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Bhupesh Sharma <bhsharma@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH V2 2/6] x86/efi: Remove __init attribute from memory mapping functions
Date: Mon, 3 Sep 2018 09:12:07 +0200 [thread overview]
Message-ID: <20180903071207.GA10249@zn.tnic> (raw)
In-Reply-To: <FFF73D592F13FD46B8700F0A279B802F485B9142@ORSMSX114.amr.corp.intel.com>
On Mon, Sep 03, 2018 at 05:03:56AM +0000, Prakhya, Sai Praneeth wrote:
> Hmm.. thought that __efi_init might be confusing with the normal __init attribute
How would that be confusing? It has "__efi" prepended?!
All I'm saying is, if you're going to define your own function
attributes, do them generic and short. "_fixup" is too specific IMO. It
also enlarges function definitions unnecessarily.
With "__efi_init" you already denote that it is a special attribute
which has relevance in the EFI code only. What you do about it - the
*fixup* - is the thing you do with the attribute. But you don't have to
have the "what you do" in the attribute name too.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-09-03 7:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-02 9:46 [PATCH V2 0/6] Add efi page fault handler to fix/recover from Sai Praneeth Prakhya
2018-09-02 9:46 ` [PATCH V2 1/6] efi: Make efi_rts_work accessible to efi page fault handler Sai Praneeth Prakhya
2018-09-02 9:46 ` [PATCH V2 2/6] x86/efi: Remove __init attribute from memory mapping functions Sai Praneeth Prakhya
2018-09-02 10:56 ` Borislav Petkov
2018-09-03 5:03 ` Prakhya, Sai Praneeth
2018-09-03 7:12 ` Borislav Petkov [this message]
2018-09-03 8:15 ` Prakhya, Sai Praneeth
2018-09-02 9:46 ` [PATCH V2 3/6] x86/efi: Permanently save the EFI_MEMORY_MAP passed by the firmware Sai Praneeth Prakhya
2018-09-02 9:46 ` [PATCH V2 4/6] x86/efi: Add efi page fault handler to fixup/recover from page faults caused by firmware Sai Praneeth Prakhya
2018-09-03 8:58 ` Thomas Gleixner
2018-09-03 17:16 ` Prakhya, Sai Praneeth
2018-09-02 9:46 ` [PATCH V2 5/6] x86/mm: If in_atomic(), allocate pages without sleeping Sai Praneeth Prakhya
2018-09-03 8:34 ` Peter Zijlstra
2018-09-03 8:53 ` Thomas Gleixner
2018-09-03 17:07 ` Prakhya, Sai Praneeth
2018-09-02 9:46 ` [PATCH V2 6/6] x86/efi: Introduce EFI_WARN_ON_ILLEGAL_ACCESS Sai Praneeth Prakhya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903071207.GA10249@zn.tnic \
--to=bp@alien8.de \
--cc=ard.biesheuvel@linaro.org \
--cc=astone@redhat.com \
--cc=bhsharma@redhat.com \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=ricardo.neri@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.