From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: chipidea: imx: make MODULE_LICENCE and SPDX-identifier match From: Greg Kroah-Hartman Message-Id: <20180903123611.GA9660@kroah.com> Date: Mon, 3 Sep 2018 14:36:11 +0200 To: Peter Chen Cc: Marcus Folkesson , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gTW9uLCBTZXAgMDMsIDIwMTggYXQgMDQ6MTQ6NDFBTSArMDAwMCwgUGV0ZXIgQ2hlbiB3cm90 ZToKPiAgCj4gPiAKPiA+IFRoZSBTUERYLUxpY2Vuc2UtSWRlbnRpZmllciBpcyBzZXQgdG8gR1BM LTIuMCssIHdoaWNoIGNvcnJlc3BvbmQgdG8KPiA+IE1PRFVMRV9MSUNFTlNFICJHUEwiLgo+ID4g Cj4gPiBTaWduZWQtb2ZmLWJ5OiBNYXJjdXMgRm9sa2Vzc29uIDxtYXJjdXMuZm9sa2Vzc29uQGdt YWlsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvdXNiL2NoaXBpZGVhL2NpX2hkcmNfaW14LmMg fCAyICstICBkcml2ZXJzL3VzYi9jaGlwaWRlYS91c2JtaXNjX2lteC5jIHwgMiArLQo+ID4gIDIg ZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy91c2IvY2hpcGlkZWEvY2lfaGRyY19pbXguYyBiL2RyaXZlcnMv dXNiL2NoaXBpZGVhL2NpX2hkcmNfaW14LmMKPiA+IGluZGV4IDE5ZjVmNWYyYTQ4YS4uNTU1ZDM5 OGZiZmE3IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy91c2IvY2hpcGlkZWEvY2lfaGRyY19pbXgu Ywo+ID4gKysrIGIvZHJpdmVycy91c2IvY2hpcGlkZWEvY2lfaGRyY19pbXguYwo+ID4gQEAgLTQ5 Miw3ICs0OTIsNyBAQCBzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciBjaV9oZHJjX2lteF9k cml2ZXIgPQo+ID4geyAgbW9kdWxlX3BsYXRmb3JtX2RyaXZlcihjaV9oZHJjX2lteF9kcml2ZXIp Owo+ID4gCj4gPiAgTU9EVUxFX0FMSUFTKCJwbGF0Zm9ybTppbXgtdXNiIik7Cj4gPiAtTU9EVUxF X0xJQ0VOU0UoIkdQTCB2MiIpOwo+ID4gK01PRFVMRV9MSUNFTlNFKCJHUEwiKTsKPiA+ICBNT0RV TEVfREVTQ1JJUFRJT04oIkNJIEhEUkMgaS5NWCBVU0IgYmluZGluZyIpOwo+ID4gTU9EVUxFX0FV VEhPUigiTWFyZWsgVmFzdXQgPG1hcmV4QGRlbnguZGU+Iik7Cj4gPiBNT0RVTEVfQVVUSE9SKCJS aWNoYXJkIFpoYW8gPHJpY2hhcmQuemhhb0BmcmVlc2NhbGUuY29tPiIpOyBkaWZmIC0tZ2l0Cj4g PiBhL2RyaXZlcnMvdXNiL2NoaXBpZGVhL3VzYm1pc2NfaW14LmMgYi9kcml2ZXJzL3VzYi9jaGlw aWRlYS91c2JtaXNjX2lteC5jCj4gPiBpbmRleCAzNGFkNWJmOGFjZDguLmQ5Y2ZhMDBiOGE2YyAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvdXNiL2NoaXBpZGVhL3VzYm1pc2NfaW14LmMKPiA+ICsr KyBiL2RyaXZlcnMvdXNiL2NoaXBpZGVhL3VzYm1pc2NfaW14LmMKPiA+IEBAIC02MzMsNiArNjMz LDYgQEAgc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgdXNibWlzY19pbXhfZHJpdmVyID0K PiA+IHsgIG1vZHVsZV9wbGF0Zm9ybV9kcml2ZXIodXNibWlzY19pbXhfZHJpdmVyKTsKPiA+IAo+ ID4gIE1PRFVMRV9BTElBUygicGxhdGZvcm06dXNibWlzYy1pbXgiKTsKPiA+IC1NT0RVTEVfTElD RU5TRSgiR1BMIHYyIik7Cj4gPiArTU9EVUxFX0xJQ0VOU0UoIkdQTCIpOwo+ID4gIE1PRFVMRV9E RVNDUklQVElPTigiZHJpdmVyIGZvciBpbXggdXNiIG5vbi1jb3JlIHJlZ2lzdGVycyIpOwo+ID4g TU9EVUxFX0FVVEhPUigiUmljaGFyZCBaaGFvIDxyaWNoYXJkLnpoYW9AZnJlZXNjYWxlLmNvbT4i KTsKPiAKPiBHcmVnLCBkb2VzIHRoaXMgaXMgYSB1c2VmdWwgY2hhbmdlPyBJIGFtIG5vdCBzdXJl LgoKQXMgdGhlIHR3byBsaWNlbnNlcyBhcmUgbm90IG1hdGNoaW5nLCBzb21ldGhpbmcgbmVlZHMg dG8gYmUgZml4ZWQgaGVyZSwKZG9uJ3QgeW91IGFncmVlPwoKUGxlYXNlIHJlYWQgaW5jbHVkZS9s aW51eC9tb2R1bGVzLmggZm9yIHdoYXQgdGhlIHN0cmluZ3MgbWVhbiwgdGhhdApzaG91bGQgaGVs cCBleHBsYWluIHRoaW5ncyBtb3JlLgoKZ3JlZyBrLWgK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2547C43334 for ; Mon, 3 Sep 2018 12:36:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 882AF20867 for ; Mon, 3 Sep 2018 12:36:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 882AF20867 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727009AbeICQ4M (ORCPT ); Mon, 3 Sep 2018 12:56:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46806 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbeICQ4M (ORCPT ); Mon, 3 Sep 2018 12:56:12 -0400 Received: from localhost (ip-213-127-74-90.ip.prioritytelecom.net [213.127.74.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id EF0F5D30; Mon, 3 Sep 2018 12:36:13 +0000 (UTC) Date: Mon, 3 Sep 2018 14:36:11 +0200 From: Greg Kroah-Hartman To: Peter Chen Cc: Marcus Folkesson , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: chipidea: imx: make MODULE_LICENCE and SPDX-identifier match Message-ID: <20180903123611.GA9660@kroah.com> References: <20180902173650.5514-1-marcus.folkesson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 03, 2018 at 04:14:41AM +0000, Peter Chen wrote: > > > > > The SPDX-License-Identifier is set to GPL-2.0+, which correspond to > > MODULE_LICENSE "GPL". > > > > Signed-off-by: Marcus Folkesson > > --- > > drivers/usb/chipidea/ci_hdrc_imx.c | 2 +- drivers/usb/chipidea/usbmisc_imx.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c > > index 19f5f5f2a48a..555d398fbfa7 100644 > > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c > > @@ -492,7 +492,7 @@ static struct platform_driver ci_hdrc_imx_driver = > > { module_platform_driver(ci_hdrc_imx_driver); > > > > MODULE_ALIAS("platform:imx-usb"); > > -MODULE_LICENSE("GPL v2"); > > +MODULE_LICENSE("GPL"); > > MODULE_DESCRIPTION("CI HDRC i.MX USB binding"); > > MODULE_AUTHOR("Marek Vasut "); > > MODULE_AUTHOR("Richard Zhao "); diff --git > > a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c > > index 34ad5bf8acd8..d9cfa00b8a6c 100644 > > --- a/drivers/usb/chipidea/usbmisc_imx.c > > +++ b/drivers/usb/chipidea/usbmisc_imx.c > > @@ -633,6 +633,6 @@ static struct platform_driver usbmisc_imx_driver = > > { module_platform_driver(usbmisc_imx_driver); > > > > MODULE_ALIAS("platform:usbmisc-imx"); > > -MODULE_LICENSE("GPL v2"); > > +MODULE_LICENSE("GPL"); > > MODULE_DESCRIPTION("driver for imx usb non-core registers"); > > MODULE_AUTHOR("Richard Zhao "); > > Greg, does this is a useful change? I am not sure. As the two licenses are not matching, something needs to be fixed here, don't you agree? Please read include/linux/modules.h for what the strings mean, that should help explain things more. greg k-h