From: Adrian Pop <apop@bitdefender.com>
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Adrian Pop <apop@bitdefender.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
Tamas K Lengyel <tamas@tklengyel.com>,
Jan Beulich <jbeulich@suse.com>,
Sergej Proskurin <proskurin@sec.in.tum.de>,
Vlad Ioan Topan <itopan@bitdefender.com>
Subject: [PATCH v5 1/3] x86/mm: Change default value for suppress #VE in set_mem_access()
Date: Mon, 3 Sep 2018 18:48:34 +0300 [thread overview]
Message-ID: <20180903154836.25708-2-apop@bitdefender.com> (raw)
In-Reply-To: <20180903154836.25708-1-apop@bitdefender.com>
From: Vlad Ioan Topan <itopan@bitdefender.com>
The default value for the "suppress #VE" bit set by set_mem_access()
currently depends on whether the call is made from the same domain (the
bit is set when called from another domain and cleared if called from
the same domain). This patch changes that behavior to inherit the old
suppress #VE bit value if it is already set and to set it to 1
otherwise, which is safer and more reliable.
Signed-off-by: Vlad Ioan Topan <itopan@bitdefender.com>
Signed-off-by: Adrian Pop <apop@bitdefender.com>
---
xen/arch/x86/mm/mem_access.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c
index 84d260ebd8..e1522a0b75 100644
--- a/xen/arch/x86/mm/mem_access.c
+++ b/xen/arch/x86/mm/mem_access.c
@@ -284,8 +284,7 @@ int p2m_set_altp2m_mem_access(struct domain *d, struct p2m_domain *hp2m,
}
}
- return ap2m->set_entry(ap2m, gfn, mfn, PAGE_ORDER_4K, t, a,
- current->domain != d);
+ return ap2m->set_entry(ap2m, gfn, mfn, PAGE_ORDER_4K, t, a, -1);
}
static int set_mem_access(struct domain *d, struct p2m_domain *p2m,
--
2.18.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-09-03 15:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 15:48 [PATCH v5 0/3] Add hvmops for setting and getting the suppress #VE bit Adrian Pop
2018-09-03 15:48 ` Adrian Pop [this message]
2018-09-11 18:08 ` [PATCH v5 1/3] x86/mm: Change default value for suppress #VE in set_mem_access() Tamas K Lengyel
2018-09-12 4:02 ` Adrian Pop
2018-09-03 15:48 ` [PATCH v5 2/3] x86/altp2m: Add a hvmop for setting the suppress #VE bit Adrian Pop
2018-09-20 11:34 ` George Dunlap
2018-09-20 11:38 ` Razvan Cojocaru
2018-09-20 15:52 ` Razvan Cojocaru
[not found] ` <CAFLBxZY0am2E01iLpZDcboFG7a1-S47Dwnd-qjp5YqQxGAdejQ@mail.gmail.com>
2018-09-23 16:33 ` George Dunlap
2018-09-23 17:09 ` Razvan Cojocaru
2018-09-03 15:48 ` [PATCH v5 3/3] x86/altp2m: Add a hvmop for querying " Adrian Pop
2018-09-11 18:02 ` Tamas K Lengyel
2018-09-12 4:01 ` Adrian Pop
2018-09-19 14:48 ` Wei Liu
2018-09-20 7:46 ` Razvan Cojocaru
2018-09-20 7:53 ` Wei Liu
2018-09-20 8:38 ` Wei Liu
2018-09-20 12:50 ` George Dunlap
2018-09-21 13:16 ` Razvan Cojocaru
2018-09-21 13:17 ` Razvan Cojocaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903154836.25708-2-apop@bitdefender.com \
--to=apop@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=itopan@bitdefender.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=proskurin@sec.in.tum.de \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.