From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Niklas Cassel <niklas.cassel@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 6/9] soc: qcom: Remove depends on OF from QCOM_RPMH
Date: Mon, 3 Sep 2018 12:24:07 -0700 [thread overview]
Message-ID: <20180903192407.GC3456@tuxbook-pro> (raw)
In-Reply-To: <20180829075724.9095-7-niklas.cassel@linaro.org>
On Wed 29 Aug 00:57 PDT 2018, Niklas Cassel wrote:
> QCOM_RPHM already selects ARM64, which always selects OF.
Nit. "already depends on ARM64"
>
> Additionally, the rpmh driver only uses linux/of.h, which has dummy
> definitions for all functions, in order for code to to be able to
> build without CONFIG_OF set.
>
> Remove the superfluous depends on OF.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/soc/qcom/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index ac657164a136..cf4ece232897 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -94,7 +94,7 @@ config QCOM_RMTFS_MEM
>
> config QCOM_RPMH
> bool "Qualcomm RPM-Hardened (RPMH) Communication"
> - depends on ARCH_QCOM && ARM64 && OF || COMPILE_TEST
> + depends on ARCH_QCOM && ARM64 || COMPILE_TEST
> help
> Support for communication with the hardened-RPM blocks in
> Qualcomm Technologies Inc (QTI) SoCs. RPMH communication uses an
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-09-03 19:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 7:57 [PATCH v6 0/9] soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 1/9] soc: qcom: smem: Add missing include of sizes.h Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 2/9] soc: qcom: llcc-slice: " Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 3/9] soc: qcom: smp2p: Add select IRQ_DOMAIN Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 4/9] soc: qcom: smsm: " Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 5/9] soc: qcom: Remove bogus depends on OF from QCOM_SMD_RPM Niklas Cassel
2018-08-29 7:57 ` [PATCH v6 6/9] soc: qcom: Remove depends on OF from QCOM_RPMH Niklas Cassel
2018-09-03 19:24 ` Bjorn Andersson [this message]
2018-08-29 7:57 ` [PATCH v6 7/9] soc: qcom: wcnss_ctrl: Avoid string overflow Niklas Cassel
2018-09-03 19:22 ` Bjorn Andersson
2018-08-29 7:57 ` [PATCH v6 8/9] soc: qcom: apr: " Niklas Cassel
2018-09-03 19:24 ` Bjorn Andersson
2018-08-29 7:57 ` [PATCH v6 9/9] soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs Niklas Cassel
2018-09-03 19:25 ` Bjorn Andersson
2018-09-13 21:38 ` [PATCH v6 0/9] " Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903192407.GC3456@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.