From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 10/12] net: ethernet: Add helper for
 set_pauseparam for Asym Pause
Date: Mon, 3 Sep 2018 21:58:05 +0200
Message-ID: <20180903195805.GI4445@lunn.ch>
References: <1535908001-18593-1-git-send-email-andrew@lunn.ch>
 <1535908001-18593-11-git-send-email-andrew@lunn.ch>
 <d0f68efb-01ff-74d3-f655-269068df5c25@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>, maxime.chevallier@bootlin.com
To: Florian Fainelli <f.fainelli@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:51102 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728402AbeIDATv (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 3 Sep 2018 20:19:51 -0400
Content-Disposition: inline
In-Reply-To: <d0f68efb-01ff-74d3-f655-269068df5c25@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> Don't you want to go one step further and incorporate the logic that xgenet,
> tg3, gianfar and others have? That is: look at the currently advertised
> parameters, determine what changed, and re-start auto-negotiation as a
> result of it being enabled and something changed?

Hi Florian

Given the number of changes i'm making, over a so many different
drivers which i cannot test, i wanted to try to keep the changes
KISS. That way we are more likely to spot errors during review.  So i
would prefer to be done later, unless it actually makes review
simpler...

   Andrew