From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com ([134.134.136.126]:24310 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbeIDULk (ORCPT ); Tue, 4 Sep 2018 16:11:40 -0400 Date: Tue, 4 Sep 2018 08:45:53 -0700 From: Sean Christopherson To: Jarkko Sakkinen CC: Andy Shevchenko , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Platform Driver , Dave Hansen , , , , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , , , Linux Kernel Mailing List Subject: Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager Message-ID: <20180904154553.GA5412@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-10-jarkko.sakkinen@linux.intel.com> <20180904153803.GC8344@linux.intel.com> Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20180904153803.GC8344@linux.intel.com> Sender: List-ID: Return-Path: linux-sgx-owner@vger.kernel.org MIME-Version: 1.0 On Tue, Sep 04, 2018 at 06:38:03PM +0300, Jarkko Sakkinen wrote: > On Mon, Sep 03, 2018 at 10:02:16PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 27, 2018 at 9:58 PM Jarkko Sakkinen > > wrote: > > > > > > + WARN(ret < 0, "sgx: cannot free page, reclaim in-progress"); > > > + WARN(ret > 0, "sgx: EREMOVE returned %d (0x%x)", ret, ret); > > > > I'm not sure (though it's easy to check) that you need sgx: prefix > > here. WARN() might take pr_fmt() if defined. > > Sean, you took care of this one. Was it so that WARN() does not respect > pr_fmt? Yep, WARN() doesn't respect pr_fmt. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Subject: Re: [PATCH v13 09/13] x86/sgx: Enclave Page Cache (EPC) memory manager Date: Tue, 4 Sep 2018 08:45:53 -0700 Message-ID: <20180904154553.GA5412@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-10-jarkko.sakkinen@linux.intel.com> <20180904153803.GC8344@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180904153803.GC8344@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Jarkko Sakkinen Cc: Andy Shevchenko , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Platform Driver , Dave Hansen , nhorman@redhat.com, npmccallum@redhat.com, linux-sgx@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , suresh.b.siddha@intel.com, serge.ayoun@intel.com, Linux Kernel Mailing List List-Id: platform-driver-x86.vger.kernel.org On Tue, Sep 04, 2018 at 06:38:03PM +0300, Jarkko Sakkinen wrote: > On Mon, Sep 03, 2018 at 10:02:16PM +0300, Andy Shevchenko wrote: > > On Mon, Aug 27, 2018 at 9:58 PM Jarkko Sakkinen > > wrote: > > > > > > + WARN(ret < 0, "sgx: cannot free page, reclaim in-progress"); > > > + WARN(ret > 0, "sgx: EREMOVE returned %d (0x%x)", ret, ret); > > > > I'm not sure (though it's easy to check) that you need sgx: prefix > > here. WARN() might take pr_fmt() if defined. > > Sean, you took care of this one. Was it so that WARN() does not respect > pr_fmt? Yep, WARN() doesn't respect pr_fmt.