From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v5 07/16] x86/pci: add Hygon PCI vendor and northbridge support Date: Tue, 4 Sep 2018 18:03:10 +0200 Message-ID: <20180904160310.GJ32615@zn.tnic> References: <20180904145255.GI32615@zn.tnic> <5c6b1493-ee20-ed3f-a558-331c0cb65556@hygon.cn> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <5c6b1493-ee20-ed3f-a558-331c0cb65556@hygon.cn> Sender: linux-kernel-owner@vger.kernel.org To: Pu Wen Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, thomas.lendacky@amd.com, pbonzini@redhat.com, helgaas@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Tue, Sep 04, 2018 at 11:45:02PM +0800, Pu Wen wrote: > I add these definitions to indicate that there are Hygon PCI device IDs. > You are right, I can just use the AMD f17h ones here. Right, if this is a small piece where they're all together in a single compilation unit - like in this case - I don't see an issue with using the AMD ones. Later, when you start splitting functionality, you can do proper defines. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.