From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 5/5] net: dsa: b53: Add SerDes support Date: Wed, 5 Sep 2018 01:32:22 +0200 Message-ID: <20180904233222.GJ29121@lunn.ch> References: <20180904221120.13018-1-f.fainelli@gmail.com> <20180904221120.13018-6-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, vivien.didelot@savoirfairelinux.com, davem@davemloft.net To: Florian Fainelli Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:52355 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbeIED7q (ORCPT ); Tue, 4 Sep 2018 23:59:46 -0400 Content-Disposition: inline In-Reply-To: <20180904221120.13018-6-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: > +void b53_serdes_phylink_validate(struct b53_device *dev, int port, > + unsigned long *supported, > + struct phylink_link_state *state) > +{ > + u8 lane = b53_serdes_map_lane(dev, port); > + > + if (lane == B53_INVALID_LANE) > + return; > + > + switch (lane) { > + case 0: > + phylink_set(supported, 2500baseX_Full); Hi Florian Could you also use it for 2500BaseT_Full with an appropriate copper PHY? Andrew