From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v2 2/2] Embedded USB Debugger (EUD) driver Date: Wed, 5 Sep 2018 13:18:00 +0200 Message-ID: <20180905111800.GA30003@kroah.com> References: <1536096853-30473-1-git-send-email-pheragu@codeaurora.org> <1536096853-30473-3-git-send-email-pheragu@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Manu Gautam Cc: Prakruthi Deepak Heragu , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ckadabi@codeaurora.org, tsoni@codeaurora.org, rnayak@codeaurora.org, bryanh@codeaurora.org, psodagud@codeaurora.org, Satya Durga Srinivasu Prabhala List-Id: linux-arm-msm@vger.kernel.org On Wed, Sep 05, 2018 at 03:01:26PM +0530, Manu Gautam wrote: > Hi, > > > On 9/5/2018 3:04 AM, Prakruthi Deepak Heragu wrote: > > Add support for control peripheral of EUD (Embedded USB Debugger) to > > listen to events such as USB attach/detach, charger enable/disable, pet > > EUD to indicate software is functional. > > > > Signed-off-by: Satya Durga Srinivasu Prabhala > > Signed-off-by: Prakruthi Deepak Heragu > > --- > > drivers/soc/qcom/Kconfig | 12 ++ > > drivers/soc/qcom/Makefile | 1 + > > drivers/soc/qcom/eud.c | 338 ++++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 351 insertions(+) > > create mode 100644 drivers/soc/qcom/eud.c > > > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > [snip] > > + > > +#define EUD_ENABLE_CMD 1 > > +#define EUD_DISABLE_CMD 0 > > Why not use module param as boolean? I mean zero to disable and non-zero to enable? Never use module parameters on new code, as it's really hard to ever change them. It also doesn't work for multiple devices of the same type. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/2] Embedded USB Debugger (EUD) driver From: Greg Kroah-Hartman Message-Id: <20180905111800.GA30003@kroah.com> Date: Wed, 5 Sep 2018 13:18:00 +0200 To: Manu Gautam Cc: Prakruthi Deepak Heragu , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ckadabi@codeaurora.org, tsoni@codeaurora.org, rnayak@codeaurora.org, bryanh@codeaurora.org, psodagud@codeaurora.org, Satya Durga Srinivasu Prabhala List-ID: T24gV2VkLCBTZXAgMDUsIDIwMTggYXQgMDM6MDE6MjZQTSArMDUzMCwgTWFudSBHYXV0YW0gd3Jv dGU6Cj4gSGksCj4gCj4gCj4gT24gOS81LzIwMTggMzowNCBBTSwgUHJha3J1dGhpIERlZXBhayBI ZXJhZ3Ugd3JvdGU6Cj4gPiBBZGQgc3VwcG9ydCBmb3IgY29udHJvbCBwZXJpcGhlcmFsIG9mIEVV RCAoRW1iZWRkZWQgVVNCIERlYnVnZ2VyKSB0bwo+ID4gbGlzdGVuIHRvIGV2ZW50cyBzdWNoIGFz IFVTQiBhdHRhY2gvZGV0YWNoLCBjaGFyZ2VyIGVuYWJsZS9kaXNhYmxlLCBwZXQKPiA+IEVVRCB0 byBpbmRpY2F0ZSBzb2Z0d2FyZSBpcyBmdW5jdGlvbmFsLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6 IFNhdHlhIER1cmdhIFNyaW5pdmFzdSBQcmFiaGFsYSA8c2F0eWFwQGNvZGVhdXJvcmEub3JnPgo+ ID4gU2lnbmVkLW9mZi1ieTogUHJha3J1dGhpIERlZXBhayBIZXJhZ3UgPHBoZXJhZ3VAY29kZWF1 cm9yYS5vcmc+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL3NvYy9xY29tL0tjb25maWcgIHwgIDEyICsr Cj4gPiAgZHJpdmVycy9zb2MvcWNvbS9NYWtlZmlsZSB8ICAgMSArCj4gPiAgZHJpdmVycy9zb2Mv cWNvbS9ldWQuYyAgICB8IDMzOCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCAzNTEgaW5zZXJ0aW9ucygrKQo+ID4gIGNy ZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL3NvYy9xY29tL2V1ZC5jCj4gPgo+ID4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvc29jL3Fjb20vS2NvbmZpZyBiL2RyaXZlcnMvc29jL3Fjb20vS2NvbmZpZwo+ IFtzbmlwXQo+ID4gKwo+ID4gKyNkZWZpbmUgRVVEX0VOQUJMRV9DTUQgMQo+ID4gKyNkZWZpbmUg RVVEX0RJU0FCTEVfQ01EIDAKPiAKPiBXaHkgbm90IHVzZSBtb2R1bGUgcGFyYW0gYXMgYm9vbGVh bj8gSSBtZWFuIHplcm8gdG8gZGlzYWJsZSBhbmQgbm9uLXplcm8gdG8gZW5hYmxlPwoKTmV2ZXIg dXNlIG1vZHVsZSBwYXJhbWV0ZXJzIG9uIG5ldyBjb2RlLCBhcyBpdCdzIHJlYWxseSBoYXJkIHRv IGV2ZXIKY2hhbmdlIHRoZW0uICBJdCBhbHNvIGRvZXNuJ3Qgd29yayBmb3IgbXVsdGlwbGUgZGV2 aWNlcyBvZiB0aGUgc2FtZQp0eXBlLgoKdGhhbmtzLAoKZ3JlZyBrLWgK