All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ajay Gupta <ajayg@nvidia.com>
Cc: wsa@the-dreams.de, heikki.krogerus@linux.intel.com,
	linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: [v5,2/2] usb: typec: ucsi: add support for Cypress CCGx
Date: Wed, 5 Sep 2018 14:26:49 +0200	[thread overview]
Message-ID: <20180905122649.GA17160@kroah.com> (raw)

On Fri, Aug 31, 2018 at 01:22:21PM -0700, Ajay Gupta wrote:
> +	dev_info(dev, "Silicon id %2ph", data + CCGX_I2C_RAB_READ_SILICON_ID);
> +	dev_info(dev, "FW1 version %8ph\n", data + CCGX_I2C_RAB_FW1_VERSION);
> +	dev_info(dev, "FW2 version %8ph\n", data + CCGX_I2C_RAB_FW2_VERSION);

Drivers should be totally quiet when initialized, unless something goes
wrong.  Please don't spam the kernel log with this type of stuff.

You can use dev_dbg() if it helps with debugging the code, that might be
a better idea here.

Also, a pointer?  Are you sure about that?  That looks really odd...

thanks,

greg k-h

             reply	other threads:[~2018-09-05 12:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05 12:26 Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-09-05 22:31 [v5,2/2] usb: typec: ucsi: add support for Cypress CCGx Wolfram Sang
2018-09-05 22:17 Ajay Gupta
2018-09-05 18:04 Ajay Gupta
2018-09-05 12:31 Greg Kroah-Hartman
2018-08-31 20:22 Ajay Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180905122649.GA17160@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ajayg@nvidia.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.