From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] qt5location: fix build failure due to missing qt5base gui dependency
Date: Wed, 5 Sep 2018 13:53:07 +0200 [thread overview]
Message-ID: <20180905135307.051cd136@windsurf> (raw)
In-Reply-To: <20180905090307.89484-1-giulio.benetti@micronovasrl.com>
Hello,
On Wed, 5 Sep 2018 11:03:07 +0200, Giulio Benetti wrote:
> qt5location fails to build due to missing Qt5 Gui module.
> In configure.json features.opengl is referred, but it is available only
> if qt5base gui submodule is built.
>
> Add BR2_PACKAGE_QT5BASE_GUI to qt5location Config.in to assure gui
> submodule is built before qt5location.
>
> Fixes:
> http://autobuild.buildroot.org/results/1e1/1e12a819750c677c9ef204a324c8bf06212e5135/
> http://autobuild.buildroot.org/results/223/223ec6565beba1ca73d4ff488296feec53656b40/
> http://autobuild.buildroot.org/results/84f/84fe1c84e3537167ee3791e83c9fe2cc2805ccb5/
> http://autobuild.buildroot.org/results/9c9/9c96d2106222e623a379f9995bd059725eb27769/
> http://autobuild.buildroot.org/results/fa0/fa01513d28d896ca8819966c5b1ed5c35283e92f/
> http://autobuild.buildroot.org/results/5d7/5d7333470c31b83c697218382dc77f74af86c666/
> http://autobuild.buildroot.org/results/db7/db7b4c61bb41d32e0f7960c194588cd1559ff3f7/
> http://autobuild.buildroot.org/results/2b7/2b71f186b8d67c4805393c9c016d641893d46220/
> http://autobuild.buildroot.org/results/1e1/1e12a819750c677c9ef204a324c8bf06212e5135/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> Changes V1->V2:
> * add missing Fixes: list in commit log
>
> package/qt5/qt5location/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/qt5/qt5location/Config.in b/package/qt5/qt5location/Config.in
> index e1778182a0..7c39979eff 100644
> --- a/package/qt5/qt5location/Config.in
> +++ b/package/qt5/qt5location/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_QT5LOCATION
> bool "qt5location"
> select BR2_PACKAGE_QT5BASE
> + select BR2_PACKAGE_QT5BASE_GUI
To me, it looks weird that the location services need the GUI support.
Isn't it just the qt5location examples that need GUI support, or
something like that ?
Also, having BR2_PACKAGE_QT5BASE_GUI does not guarantee that OpenGL
support is available, so I'm not sure this is going to fix the error in
all cases.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-05 11:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 9:03 [Buildroot] [PATCH v2] qt5location: fix build failure due to missing qt5base gui dependency Giulio Benetti
2018-09-05 11:53 ` Thomas Petazzoni [this message]
2018-09-05 12:06 ` Giulio Benetti
2018-09-05 12:18 ` Thomas Petazzoni
2018-09-05 13:02 ` Giulio Benetti
2018-09-05 13:12 ` Giulio Benetti
2018-09-06 19:59 ` Peter Korsgaard
2018-09-18 8:12 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905135307.051cd136@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.