From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haneen Mohammed Subject: Re: [PATCH v2] drm/vkms: Fix race condition around accessing frame number Date: Wed, 5 Sep 2018 17:24:24 +0300 Message-ID: <20180905142424.GA1511@haneenDRM> References: <20180903211743.GA2773@haneenDRM> <20180905140326.GD4929@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4888A6E4DE for ; Wed, 5 Sep 2018 14:24:28 +0000 (UTC) Received: by mail-qk1-x742.google.com with SMTP id g13-v6so4967727qki.9 for ; Wed, 05 Sep 2018 07:24:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180905140326.GD4929@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: seanpaul@chromium.org, rodrigosiqueiramelo@gmail.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgMDUsIDIwMTggYXQgMDQ6MDM6MjZQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIFNlcCAwNCwgMjAxOCBhdCAxMjoxODoxN0FNICswMzAwLCBIYW5lZW4g TW9oYW1tZWQgd3JvdGU6Cj4gPiBjcnRjX3N0YXRlIGlzIGFjY2Vzc2VkIGJ5IGJvdGggdmJsYW5r X2hhbmRsZSgpIGFuZCB0aGUgb3JkZXJlZAo+ID4gd29ya19zdHJ1Y3QgaGFuZGxlIHZrbXNfY3Jj X3dvcmtfaGFuZGxlKCkgdG8gcmV0cmlldmUgYW5kIG9yIHVwZGF0ZQo+ID4gdGhlIGZyYW1lIG51 bWJlciBmb3IgY29tcHV0ZWQgQ1JDLgo+ID4gCj4gPiBTaW5jZSB3b3JrX3N0cnVjdCBjYW4gZmFp bCwgYWRkIGZyYW1lX2VuZCB0byBhY2NvdW50IGZvciBtaXNzaW5nIGZyYW1lCj4gPiBudW1iZXJz Lgo+ID4gCj4gPiBVc2UgKGZyYW1lX1tzdGFydC9lbmRdKSBmb3Igc3luY2hyb25pemF0aW9uIGJl dHdlZW4gaHJ0aW1lciBjYWxsYmFjawo+ID4gYW5kIG9yZGVyZWQgd29ya19zdHJ1Y3QgaGFuZGxl Lgo+ID4gCj4gPiBUaGlzIHBhdGNoIHBhc3NlcyB0aGUgZm9sbG93aW5nIHN1YnRlc3RzIGZyb20g aWd0IGttc19waXBlX2NyY19iYXNpYyB0ZXN0Ogo+ID4gYmFkLXNvdXJjZSwgcmVhZC1jcmMtcGlw ZS1BLCByZWFkLWNyYy1waXBlLUEtZnJhbWUtc2VxdWVuY2UsCj4gPiBub25ibG9ja2luZy1jcmMt cGlwZS1BLCBub25ibG9ja2luZy1jcmMtcGlwZS1BLWZyYW1lLXNlcXVlbmNlCj4gPiAKPiA+IFNp Z25lZC1vZmYtYnk6IEhhbmVlbiBNb2hhbW1lZCA8aGFtb2hhbW1lZC5zYUBnbWFpbC5jb20+Cj4g PiAtLS0KPiA+IHYyOgo+ID4gLSB1c2UgdTY0IHdpdGggc3BpbmxvY2sgaW5zdGVhZCBvZiBhdG9t aWNfdAo+ID4gLSBhZGQgb3V0IGxhYmVsIGZvciBjb21tb24gZXhpdCByb3V0aW5lIEB2a21zX2Ny Y193b3JrX2hhbmRsZSgpCj4gCj4gWXVwIEkgdGhpbmsgdGhhdCBsb29rcyBnb29kLCB0aGFua3Mg Zm9yIHlvdXIgcGF0Y2guIEFwcGxpZWQuCj4gCj4gYnR3LCBkbyB5b3Ugc3RpbGwgcGxhbiB0byB0 eXBlIHVwIGEgdmttcy5yc3QgZm9yIGRvY3VtZW50YXRpb24sIHNvIHRoYXQgd2UKPiBjb3VsZCBw dXQgYSBmZXcgb2YgdGhlIHRvZG8gaXRlbXMgdGhlcmU/IE9yIHNob3VsZCBJIGRvIHRoYXQ/IE5l eHQKPiBvdXRyZWFjaHkgcm91bmQgc3RhcnRzIHNvb24sIHdlIG5lZWQgdG8gZ2V0IHRoaXMgcmVh ZHkuCj4gLURhbmllbAo+IAoKSSBkaWQgcHJlcGFyZSBhIHBhdGNoIGZvciB2a21zLnJzdCBidXQg c2luY2UgbW9zdCBvZiB0aGUgdG9kb3MgSSd2ZSBzbyBmYXIgYXJlCnJlbGF0ZWQgdG8gdGhlIGN1 cnNvciBwYXRjaCwgSSBwbGFuZWQgdG8gc2VuZCBpdCBhZnRlciBJIHN1Ym1pdCB0aGUKY3Vyc29y IHBhdGNoLiBJJ2xsIHNlbmQgYm90aCBvdXQgYnkgdGhlIGVuZCBvZiB0b2RheS4KCj4gPiAKPiA+ ICBkcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2NyYy5jICB8IDM2ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKy0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19jcnRjLmMgfCAx NiArKysrKysrKysrKystLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfZHJ2LmggIHwg IDggKysrKystLQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwgNTQgaW5zZXJ0aW9ucygrKSwgNiBkZWxl dGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNf Y3JjLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmttcy92a21zX2NyYy5jCj4gPiBpbmRleCBlZDQ3ZDY3 Y2VjZDYuLjY4ZGI0MmYxNTA4NiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92a21z L3ZrbXNfY3JjLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfY3JjLmMKPiA+ IEBAIC0zNCw2ICszNCwxNSBAQCBzdGF0aWMgdWludDMyX3QgX3ZrbXNfZ2V0X2NyYyhzdHJ1Y3Qg dmttc19jcmNfZGF0YSAqY3JjX2RhdGEpCj4gPiAgCXJldHVybiBjcmM7Cj4gPiAgfQo+ID4gIAo+ ID4gKy8qKgo+ID4gKyAqIHZrbXNfY3JjX3dvcmtfaGFuZGxlIC0gb3JkZXJlZCB3b3JrX3N0cnVj dCB0byBjb21wdXRlIENSQwo+ID4gKyAqCj4gPiArICogQHdvcms6IHdvcmtfc3RydWN0Cj4gPiAr ICoKPiA+ICsgKiBXb3JrIGhhbmRsZXIgZm9yIGNvbXB1dGluZyBDUkNzLiB3b3JrX3N0cnVjdCBz Y2hlZHVsZWQgaW4KPiA+ICsgKiBhbiBvcmRlcmVkIHdvcmtxdWV1ZSB0aGF0J3MgcGVyaW9kaWNh bGx5IHNjaGVkdWxlZCB0byBydW4gYnkKPiA+ICsgKiBfdmJsYW5rX2hhbmRsZSgpIGFuZCBmbHVz aGVkIGF0IHZrbXNfYXRvbWljX2NydGNfZGVzdHJveV9zdGF0ZSgpLgo+ID4gKyAqLwo+ID4gIHZv aWQgdmttc19jcmNfd29ya19oYW5kbGUoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ID4gIHsK PiA+ICAJc3RydWN0IHZrbXNfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSA9IGNvbnRhaW5lcl9vZih3 b3JrLAo+ID4gQEAgLTQ1LDggKzU0LDE4IEBAIHZvaWQgdmttc19jcmNfd29ya19oYW5kbGUoc3Ry dWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ID4gIAkJCQkJCW91dHB1dCk7Cj4gPiAgCXN0cnVjdCB2 a21zX2NyY19kYXRhICpwcmltYXJ5X2NyYyA9IE5VTEw7Cj4gPiAgCXN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lOwo+ID4gLQo+ID4gIAl1MzIgY3JjMzIgPSAwOwo+ID4gKwl1NjQgZnJhbWVfc3RhcnQs IGZyYW1lX2VuZDsKPiA+ICsJdW5zaWduZWQgbG9uZyBmbGFnczsKPiA+ICsKPiA+ICsJc3Bpbl9s b2NrX2lycXNhdmUoJm91dC0+c3RhdGVfbG9jaywgZmxhZ3MpOwo+ID4gKwlmcmFtZV9zdGFydCA9 IGNydGNfc3RhdGUtPmZyYW1lX3N0YXJ0Owo+ID4gKwlmcmFtZV9lbmQgPSBjcnRjX3N0YXRlLT5m cmFtZV9lbmQ7Cj4gPiArCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJm91dC0+c3RhdGVfbG9jaywg ZmxhZ3MpOwo+ID4gKwo+ID4gKwkvKiBfdmJsYW5rX2hhbmRsZSgpIGhhc24ndCB1cGRhdGVkIGZy YW1lX3N0YXJ0IHlldCAqLwo+ID4gKwlpZiAoIWZyYW1lX3N0YXJ0IHx8IGZyYW1lX3N0YXJ0ID09 IGZyYW1lX2VuZCkKPiA+ICsJCWdvdG8gb3V0Owo+ID4gIAo+ID4gIAlkcm1fZm9yX2VhY2hfcGxh bmUocGxhbmUsICZ2ZGV2LT5kcm0pIHsKPiA+ICAJCXN0cnVjdCB2a21zX3BsYW5lX3N0YXRlICp2 cGxhbmVfc3RhdGU7Cj4gPiBAQCAtNjcsNyArODYsMjAgQEAgdm9pZCB2a21zX2NyY193b3JrX2hh bmRsZShzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gPiAgCWlmIChwcmltYXJ5X2NyYykKPiA+ ICAJCWNyYzMyID0gX3ZrbXNfZ2V0X2NyYyhwcmltYXJ5X2NyYyk7Cj4gPiAgCj4gPiAtCWRybV9j cnRjX2FkZF9jcmNfZW50cnkoY3J0YywgdHJ1ZSwgY3J0Y19zdGF0ZS0+bl9mcmFtZSwgJmNyYzMy KTsKPiA+ICsJZnJhbWVfZW5kID0gZHJtX2NydGNfYWNjdXJhdGVfdmJsYW5rX2NvdW50KGNydGMp Owo+ID4gKwo+ID4gKwkvKiBxdWV1ZV93b3JrIGNhbiBmYWlsIHRvIHNjaGVkdWxlIGNyY193b3Jr OyBhZGQgY3JjIGZvcgo+ID4gKwkgKiBtaXNzaW5nIGZyYW1lcwo+ID4gKwkgKi8KPiA+ICsJd2hp bGUgKGZyYW1lX3N0YXJ0IDw9IGZyYW1lX2VuZCkKPiA+ICsJCWRybV9jcnRjX2FkZF9jcmNfZW50 cnkoY3J0YywgdHJ1ZSwgZnJhbWVfc3RhcnQrKywgJmNyYzMyKTsKPiA+ICsKPiA+ICtvdXQ6Cj4g PiArCS8qIHRvIGF2b2lkIHVzaW5nIHRoZSBzYW1lIHZhbHVlIGZvciBmcmFtZSBudW1iZXIgYWdh aW4gKi8KPiA+ICsJc3Bpbl9sb2NrX2lycXNhdmUoJm91dC0+c3RhdGVfbG9jaywgZmxhZ3MpOwo+ ID4gKwljcnRjX3N0YXRlLT5mcmFtZV9lbmQgPSBmcmFtZV9lbmQ7Cj4gPiArCWNydGNfc3RhdGUt PmZyYW1lX3N0YXJ0ID0gMDsKPiA+ICsJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmb3V0LT5zdGF0 ZV9sb2NrLCBmbGFncyk7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyBpbnQgdmttc19jcmNfcGFy c2Vfc291cmNlKGNvbnN0IGNoYXIgKnNyY19uYW1lLCBib29sICplbmFibGVkKQo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJt L3ZrbXMvdmttc19jcnRjLmMKPiA+IGluZGV4IDlkMGIxYTMyNWE3OC4uMTc3YmJjYjM4MzA2IDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19jcnRjLmMKPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfY3J0Yy5jCj4gPiBAQCAtMjIsOCArMjIsMTkgQEAg c3RhdGljIHZvaWQgX3ZibGFua19oYW5kbGUoc3RydWN0IHZrbXNfb3V0cHV0ICpvdXRwdXQpCj4g PiAgCQlEUk1fRVJST1IoInZrbXMgZmFpbHVyZSBvbiBoYW5kbGluZyB2YmxhbmsiKTsKPiA+ICAK PiA+ICAJaWYgKHN0YXRlICYmIG91dHB1dC0+Y3JjX2VuYWJsZWQpIHsKPiA+IC0JCXN0YXRlLT5u X2ZyYW1lID0gZHJtX2NydGNfYWNjdXJhdGVfdmJsYW5rX2NvdW50KGNydGMpOwo+ID4gLQkJcXVl dWVfd29yayhvdXRwdXQtPmNyY193b3JrcSwgJnN0YXRlLT5jcmNfd29yayk7Cj4gPiArCQl1NjQg ZnJhbWUgPSBkcm1fY3J0Y19hY2N1cmF0ZV92YmxhbmtfY291bnQoY3J0Yyk7Cj4gPiArCj4gPiAr CQkvKiB1cGRhdGUgZnJhbWVfc3RhcnQgb25seSBpZiBhIHF1ZXVlZCB2a21zX2NyY193b3JrX2hh bmRsZSgpCj4gPiArCQkgKiBoYXMgcmVhZCB0aGUgZGF0YQo+ID4gKwkJICovCj4gPiArCQlzcGlu X2xvY2soJm91dHB1dC0+c3RhdGVfbG9jayk7Cj4gPiArCQlpZiAoIXN0YXRlLT5mcmFtZV9zdGFy dCkKPiA+ICsJCQlzdGF0ZS0+ZnJhbWVfc3RhcnQgPSBmcmFtZTsKPiA+ICsJCXNwaW5fdW5sb2Nr KCZvdXRwdXQtPnN0YXRlX2xvY2spOwo+ID4gKwo+ID4gKwkJcmV0ID0gcXVldWVfd29yayhvdXRw dXQtPmNyY193b3JrcSwgJnN0YXRlLT5jcmNfd29yayk7Cj4gPiArCQlpZiAoIXJldCkKPiA+ICsJ CQlEUk1fV0FSTigiZmFpbGVkIHRvIHF1ZXVlIHZrbXNfY3JjX3dvcmtfaGFuZGxlIik7Cj4gPiAg CX0KPiA+ICAKPiA+ICAJc3Bpbl91bmxvY2soJm91dHB1dC0+bG9jayk7Cj4gPiBAQCAtMjExLDYg KzIyMiw3IEBAIGludCB2a21zX2NydGNfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1 Y3QgZHJtX2NydGMgKmNydGMsCj4gPiAgCWRybV9jcnRjX2hlbHBlcl9hZGQoY3J0YywgJnZrbXNf Y3J0Y19oZWxwZXJfZnVuY3MpOwo+ID4gIAo+ID4gIAlzcGluX2xvY2tfaW5pdCgmdmttc19vdXQt PmxvY2spOwo+ID4gKwlzcGluX2xvY2tfaW5pdCgmdmttc19vdXQtPnN0YXRlX2xvY2spOwo+ID4g IAo+ID4gIAl2a21zX291dC0+Y3JjX3dvcmtxID0gYWxsb2Nfb3JkZXJlZF93b3JrcXVldWUoInZr bXNfY3JjX3dvcmtxIiwgMCk7Cj4gPiAgCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L3ZrbXMvdmttc19kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfZHJ2LmgKPiA+IGlu ZGV4IDIwMTdhMmNjYzQzZC4uODBhZjZkM2E2NWU3IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL3ZrbXMvdmttc19kcnYuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmtt c19kcnYuaAo+ID4gQEAgLTM5LDEyICszOSwxNCBAQCBzdHJ1Y3Qgdmttc19wbGFuZV9zdGF0ZSB7 Cj4gPiAgICogdmttc19jcnRjX3N0YXRlIC0gRHJpdmVyIHNwZWNpZmljIENSVEMgc3RhdGUKPiA+ ICAgKiBAYmFzZTogYmFzZSBDUlRDIHN0YXRlCj4gPiAgICogQGNyY193b3JrOiB3b3JrIHN0cnVj dCB0byBjb21wdXRlIGFuZCBhZGQgQ1JDIGVudHJpZXMKPiA+IC0gKiBAbl9mcmFtZTogZnJhbWUg bnVtYmVyIGZvciBjb21wdXRlZCBDUkMKPiA+ICsgKiBAbl9mcmFtZV9zdGFydDogc3RhcnQgZnJh bWUgbnVtYmVyIGZvciBjb21wdXRlZCBDUkMKPiA+ICsgKiBAbl9mcmFtZV9lbmQ6IGVuZCBmcmFt ZSBudW1iZXIgZm9yIGNvbXB1dGVkIENSQwo+ID4gICAqLwo+ID4gIHN0cnVjdCB2a21zX2NydGNf c3RhdGUgewo+ID4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgYmFzZTsKPiA+ICAJc3RydWN0IHdv cmtfc3RydWN0IGNyY193b3JrOwo+ID4gLQl1bnNpZ25lZCBpbnQgbl9mcmFtZTsKPiA+ICsJdTY0 IGZyYW1lX3N0YXJ0Owo+ID4gKwl1NjQgZnJhbWVfZW5kOwo+ID4gIH07Cj4gPiAgCj4gPiAgc3Ry dWN0IHZrbXNfb3V0cHV0IHsKPiA+IEBAIC01OSw2ICs2MSw4IEBAIHN0cnVjdCB2a21zX291dHB1 dCB7Cj4gPiAgCXN0cnVjdCB3b3JrcXVldWVfc3RydWN0ICpjcmNfd29ya3E7Cj4gPiAgCS8qIHBy b3RlY3RzIGNvbmN1cnJlbnQgYWNjZXNzIHRvIGNyY19kYXRhICovCj4gPiAgCXNwaW5sb2NrX3Qg bG9jazsKPiA+ICsJLyogcHJvdGVjdHMgY29uY3VycmVudCBhY2Nlc3MgdG8gY3J0Y19zdGF0ZSAq Lwo+ID4gKwlzcGlubG9ja190IHN0YXRlX2xvY2s7Cj4gPiAgfTsKPiA+ICAKPiA+ICBzdHJ1Y3Qg dmttc19kZXZpY2Ugewo+ID4gLS0gCj4gPiAyLjE3LjEKPiA+IAo+IAo+IC0tIAo+IERhbmllbCBW ZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiBodHRwOi8vYmxv Zy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK