From: Olaf Hering <olaf@aepfle.de>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] xen: avoid crash in disable_hotplug_cpu
Date: Wed, 5 Sep 2018 16:47:19 +0200 [thread overview]
Message-ID: <20180905164719.52e02256.olaf@aepfle.de> (raw)
In-Reply-To: <7630aac8-8588-6e42-0807-f98b66ce37b5@suse.com>
[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]
Am Wed, 5 Sep 2018 12:55:58 +0200
schrieb Juergen Gross <jgross@suse.com>:
> Instead of trying to fight the symptoms, I think avoiding to offline
> the last cpu would make more sense.
Well, apparently the fix is to leave cpu#0 online because of a backtrace like that:
WARNING: CPU: 0 PID: 83 at kernel/sched/cpudeadline.c:159 cpudl_clear+0xa5/0xb0
Workqueue: events cpuset_hotplug_workfn
RIP: e030:cpudl_clear+0xa5/0xb0
Code: 8b 43 48 c7 44 28 0c ff ff ff ff e8 d5 fd ff ff 48 8d 43 08 f0 4c 0f ab 20 4c 89 ee 48 89 df 5b 5d 41 5c 41 5d e9 0b 3b 79 00 <0f> 0b e9 76 ff ff ff 0f 1f 40 00 66 66 66 66 90 41 56 49 89 d6 41
RSP: e02b:ffffc900411cbc40 EFLAGS: 00010086
RAX: ffffffff810d09a0 RBX: ffff880106f1a100 RCX: 0000000000000000
RDX: 0000000000000000 RSI: 0000000000000000 RDI: ffff880106f1a100
RBP: 0000000000000000 R08: 0000000000000000 R09: ffff8801068989b0
R10: ffff8801068989d0 R11: 0000000000000008 R12: 0000000000000000
R13: ffff8801f3800200 R14: 0000000000000001 R15: ffff8801f3823240
FS: 00007fd40d7f08c0(0000) GS:ffff8801f3800000(0000) knlGS:0000000000000000
CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055eff60fe098 CR3: 00000001edf24000 CR4: 0000000000002660
Call Trace:
rq_offline_dl+0x36/0x80
set_rq_offline+0x31/0x60
rq_attach_root+0x98/0xc0
cpu_attach_domain+0x107/0x320
partition_sched_domains+0x117/0x347
? cpus_read_lock+0x2d/0x50
rebuild_sched_domains_locked+0xe4/0x4e0
? __switch_to_asm+0x40/0x70
? xen_mc_flush+0x102/0x210
rebuild_sched_domains+0x16/0x30
cpuset_hotplug_workfn+0x45e/0xef0
? _raw_spin_unlock_irq+0x22/0x40
? finish_task_switch+0x75/0x250
process_one_work+0x1fd/0x3e0
worker_thread+0x2d/0x3d0
? rescuer_thread+0x340/0x340
kthread+0x112/0x130
? kthread_create_worker_on_cpu+0x40/0x40
ret_from_fork+0x3a/0x50
Initially I did not spot it because the kernel was booted with 'quiet'.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2018-09-05 14:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 10:40 [PATCH v1] xen: avoid crash in disable_hotplug_cpu Olaf Hering
2018-09-05 10:40 ` Olaf Hering
2018-09-05 10:55 ` Juergen Gross
2018-09-05 10:55 ` Juergen Gross
2018-09-05 11:50 ` Olaf Hering
2018-09-05 12:04 ` Juergen Gross
2018-09-05 12:04 ` Juergen Gross
2018-09-05 11:50 ` Olaf Hering
2018-09-05 14:47 ` Olaf Hering [this message]
2018-09-05 15:14 ` Juergen Gross
2018-09-05 15:27 ` Olaf Hering
2018-09-05 15:27 ` Olaf Hering
2018-09-05 15:14 ` Juergen Gross
2018-09-05 14:47 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905164719.52e02256.olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.