From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] firmware/dmc/icl: Add MODULE_FIRMWARE()
Date: Wed, 5 Sep 2018 16:10:21 -0700 [thread overview]
Message-ID: <20180905231021.GA2686@intel.com> (raw)
In-Reply-To: <1536177035-28877-1-git-send-email-anusha.srivatsa@intel.com>
On Wed, Sep 05, 2018 at 12:50:35PM -0700, Anusha Srivatsa wrote:
> Add missing MODULE_FIRMWARE while loading DMC on Icelake.
>
> Rebased on top of https://patchwork.freedesktop.org/patch/246153/
What about a Fixes after the patch gets pushed?
so with message removed or replaced by a proper fixes
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
> drivers/gpu/drm/i915/intel_csr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 4aa8f3d..d48186e 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -35,6 +35,7 @@
> */
>
> #define I915_CSR_ICL "i915/icl_dmc_ver1_07.bin"
> +MODULE_FIRMWARE(I915_CSR_ICL);
> #define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
>
> #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-09-05 23:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 19:50 [PATCH] firmware/dmc/icl: Add MODULE_FIRMWARE() Anusha Srivatsa
2018-09-05 20:39 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-09-05 23:10 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905231021.GA2686@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.