From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 04/14] drm: add helper to implement legacy dirtyfb Date: Thu, 6 Sep 2018 10:21:22 +0200 Message-ID: <20180906082122.GQ4929@phenom.ffwll.local> References: <20180905233901.2321-1-drawat@vmware.com> <20180905233901.2321-5-drawat@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id A0C226E113 for ; Thu, 6 Sep 2018 08:21:26 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id d8-v6so8219017edv.0 for ; Thu, 06 Sep 2018 01:21:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180905233901.2321-5-drawat@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Deepak Rawat Cc: thellstrom@vmware.com, dri-devel@lists.freedesktop.org, linux-graphics-maintainer@vmware.com, lukasz.spintzyk@displaylink.com List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgMDUsIDIwMTggYXQgMDQ6Mzg6NTFQTSAtMDcwMCwgRGVlcGFrIFJhd2F0IHdy b3RlOgo+IEZyb206IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4KPiAKPiBBZGQgYW4g YXRvbWljIGhlbHBlciB0byBpbXBsZW1lbnQgZGlydHlmYiBzdXBwb3J0LiAgVGhpcyBpcyBuZWVk ZWQgdG8KPiBzdXBwb3J0IERTSSBjb21tYW5kLW1vZGUgcGFuZWxzIHdpdGggeDExIHVzZXJzcGFj ZSAoaWUuIHdoZW4gd2UgY2FuJ3QKPiByZWx5IG9uIHBhZ2VmbGlwcyB0byB0cmlnZ2VyIGEgZmx1 c2ggdG8gdGhlIHBhbmVsKS4KPiAKPiB2MjogTW9kaWZpZWQgdGhlIGhlbHBlciB0byB1c2UgcGxh bmUgZmJfZGFtYWdlX2NsaXBzIHByb3BlcnR5IGFuZAo+IHJlbW92ZWQgcGxhbmVfc3RhdGU6OmRp cnR5IGZsYWcuCj4gCj4gU2lnbmVkLW9mZi1ieTogUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwu Y29tPgo+IFNpZ25lZC1vZmYtYnk6IERlZXBhayBSYXdhdCA8ZHJhd2F0QHZtd2FyZS5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZGFtYWdlX2hlbHBlci5jIHwgMTE2ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9kcm0vZHJtX2RhbWFnZV9oZWxwZXIuaCAg ICAgfCAgIDQgKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDEyMCBpbnNlcnRpb25zKCspCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGFtYWdlX2hlbHBlci5jIGIvZHJpdmVycy9n cHUvZHJtL2RybV9kYW1hZ2VfaGVscGVyLmMKPiBpbmRleCA3ZDcwZjYwMDE4ODkuLmIwMTZlYzM3 NTI5NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RhbWFnZV9oZWxwZXIuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZGFtYWdlX2hlbHBlci5jCj4gQEAgLTI2LDYgKzI2 LDcgQEAKPiAgICoKPiAgICogQXV0aG9yczoKPiAgICogRGVlcGFrIFJhd2F0IDxkcmF3YXRAdm13 YXJlLmNvbT4KPiArICogUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPgo+ICAgKgo+ICAg KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKiovCj4gIAo+IEBAIC04MSw2ICs4MiwyMSBAQCBzdGF0aWMgaW50IGNv bnZlcnRfZml4ZWRfdG9fMzIoaW50IGZpeGVkKQo+ICAJcmV0dXJuICgoZml4ZWQgPj4gMTUpICYg MSkgKyAoZml4ZWQgPj4gMTYpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBjb252ZXJ0X2NsaXBf cmVjdF90b19yZWN0KGNvbnN0IHN0cnVjdCBkcm1fY2xpcF9yZWN0ICpzcmMsCj4gKwkJCQkgICAg ICBzdHJ1Y3QgZHJtX3JlY3QgKmRlc3QsCj4gKwkJCQkgICAgICB1aW50MzJfdCBudW1fY2xpcHMp CgpJIHRoaW5rIHdlIG5lZWQgdG8gdXNlIGRybV9tb2RlX3JlY3QgaGVyZSwgYmVjYXVzZSBpdCdz IGVzc2VudGlhbGx5IHRoZQp1YXBpIG9uZS4KCj4gK3sKPiArCXdoaWxlIChudW1fY2xpcHMgPiAw KSB7Cj4gKwkJZGVzdC0+eDEgPSBzcmMtPngxOwo+ICsJCWRlc3QtPnkxID0gc3JjLT55MTsKPiAr CQlkZXN0LT54MiA9IHNyYy0+eDI7Cj4gKwkJZGVzdC0+eTIgPSBzcmMtPnkyOwo+ICsJCXNyYysr Owo+ICsJCWRlc3QrKzsKPiArCQludW1fY2xpcHMtLTsKPiArCX0KPiArfQo+ICsKPiAgLyoqCj4g ICAqIGRybV9wbGFuZV9lbmFibGVfZmJfZGFtYWdlX2NsaXBzIC0gZW5hYmxlcyBwbGFuZSBmYiBk YW1hZ2UgY2xpcHMgcHJvcGVydHkKPiAgICogQHBsYW5lOiBwbGFuZSBvbiB3aGljaCB0byBlbmFi bGUgZGFtYWdlIGNsaXBzIHByb3BlcnR5Cj4gQEAgLTE4MywzICsxOTksMTAzIEBAIGRybV9hdG9t aWNfaGVscGVyX2RhbWFnZV9pdGVyX25leHQoc3RydWN0IGRybV9hdG9taWNfaGVscGVyX2RhbWFn ZV9pdGVyICppdGVyLAo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9h dG9taWNfaGVscGVyX2RhbWFnZV9pdGVyX25leHQpOwo+ICsKPiArLyoqCj4gKyAqIGRybV9hdG9t aWNfaGVscGVyX2RpcnR5ZmIgLSBoZWxwZXIgZm9yIGRpcnR5ZmIKPiArICogQGZiOiBEUk0gZnJh bWVidWZmZXIKPiArICogQGZpbGVfcHJpdjogZHJtIGZpbGUgZm9yIHRoZSBpb2N0bCBjYWxsCj4g KyAqIEBmbGFnczogZGlydHkgZmIgYW5ub3RhdGUgZmxhZ3MKPiArICogQGNvbG9yOiBjb2xvciBm b3IgYW5ub3RhdGUgZmlsbAo+ICsgKiBAY2xpcHM6IGRpcnR5IHJlZ2lvbgo+ICsgKiBAbnVtX2Ns aXBzOiBjb3VudCBvZiBjbGlwIGluIGNsaXBzCj4gKyAqCj4gKyAqIEEgaGVscGVyIHRvIGltcGxl bWVudCBkcm1fZnJhbWVidWZmZXJfZnVuY3M6OmRpcnR5LiBUaGlzIGhlbHBlciB3aWxsIGRvIGEK PiArICogZnVsbCB1cGRhdGUgaW4gY2FzZSBvZiBhbm5vdGF0ZSBmbGFncy4KPiArICoKPiArICog UmV0dXJuczogWmVybyBvbiBzdWNjZXNzLCBuZWdhdGl2ZSBlcnJubyBvbiBmYWlsdXJlLgo+ICsg Ki8KPiAraW50IGRybV9hdG9taWNfaGVscGVyX2RpcnR5ZmIoc3RydWN0IGRybV9mcmFtZWJ1ZmZl ciAqZmIsCj4gKwkJCSAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2LCB1bnNpZ25lZCBm bGFncywKPiArCQkJICAgICAgdW5zaWduZWQgY29sb3IsIHN0cnVjdCBkcm1fY2xpcF9yZWN0ICpj bGlwcywKPiArCQkJICAgICAgdW5zaWduZWQgbnVtX2NsaXBzKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJt X21vZGVzZXRfYWNxdWlyZV9jdHggY3R4Owo+ICsJc3RydWN0IGRybV9wcm9wZXJ0eV9ibG9iICpk YW1hZ2UgPSBOVUxMOwo+ICsJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwo+ICsJc3Ry dWN0IGRybV9wbGFuZSAqcGxhbmU7Cj4gKwlzdHJ1Y3QgZHJtX3JlY3QgKnJlY3RzID0gTlVMTDsK PiArCWludCByZXQgPSAwOwo+ICsKPiArCS8qCj4gKwkgKiBXaGVuIGNhbGxlZCBmcm9tIGlvY3Rs LCB3ZSBhcmUgaW50ZXJydXB0YWJsZSwgYnV0IG5vdCB3aGVuIGNhbGxlZAo+ICsJICogaW50ZXJu YWxseSAoaWUuIGRlZmlvIHdvcmtlcikKPiArCSAqLwo+ICsJZHJtX21vZGVzZXRfYWNxdWlyZV9p bml0KCZjdHgsCj4gKwkJZmlsZV9wcml2ID8gRFJNX01PREVTRVRfQUNRVUlSRV9JTlRFUlJVUFRJ QkxFIDogMCk7Cj4gKwo+ICsJc3RhdGUgPSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKGZiLT5kZXYp Owo+ICsJaWYgKCFzdGF0ZSkgewo+ICsJCXJldCA9IC1FTk9NRU07Cj4gKwkJZ290byBvdXQ7Cj4g Kwl9Cj4gKwlzdGF0ZS0+YWNxdWlyZV9jdHggPSAmY3R4Owo+ICsKPiArCVdBUk5fT05DRShmbGFn cyAmIERSTV9NT0RFX0ZCX0RJUlRZX0ZMQUdTLAo+ICsJCSAgIkZ1bGwgdXBkYXRlIGZvciBkaXJ0 eWZiIHdpdGggRFJNX01PREVfRkJfRElSVFlfRkxBR1NcbiIpOwoKVXNlci10cmlnZ2VyYWJsZSBi YWNrdHJhY2UgaXNuJ3QgZ29vZC4gSSB0aGluayB5b3UganVzdCBuZWVkIHRvIGhhbmRsZSB0aGUK RklMTC9DT1BZIG1lYW5pbmcuCgpGb3IgQ09QWSB3ZSBuZWVkIHRvIGlnbm9yZSBhbGwgdGhlIG9k ZCByZWN0cyAoaWlyYyB0aG9zZSBhcmUgdGhlIHNvdXJjZXMpLgpGSUxMIHdlIGNhbiBqdXN0IGhh bmRsZS4gU2VlIGUuZy4gd2hhdCB0aW55ZHJtX21lcmdlX2NsaXBzIGRvZXMuCgpPdGhlcndpc2Ug SSB0aGluayB0aGlzIGxvb2tzIGdvb2QuCi1EYW5pZWwKCj4gKwo+ICsJaWYgKCEoZmxhZ3MgJiBE Uk1fTU9ERV9GQl9ESVJUWV9GTEFHUykpIHsKPiArCQlyZWN0cyA9IGtjYWxsb2MobnVtX2NsaXBz LCBzaXplb2YoKnJlY3RzKSwgR0ZQX0tFUk5FTCk7Cj4gKwkJaWYgKCFyZWN0cykgewo+ICsJCQly ZXQgPSAtRU5PTUVNOwo+ICsJCQlnb3RvIG91dDsKPiArCQl9Cj4gKwo+ICsJCWNvbnZlcnRfY2xp cF9yZWN0X3RvX3JlY3QoY2xpcHMsIHJlY3RzLCBudW1fY2xpcHMpOwo+ICsJCWRhbWFnZSA9IGRy bV9wcm9wZXJ0eV9jcmVhdGVfYmxvYihmYi0+ZGV2LAo+ICsJCQkJCQkgIG51bV9jbGlwcyAqIHNp emVvZigqcmVjdHMpLAo+ICsJCQkJCQkgIHJlY3RzKTsKPiArCQlpZiAoSVNfRVJSKGRhbWFnZSkp IHsKPiArCQkJcmV0ID0gUFRSX0VSUihkYW1hZ2UpOwo+ICsJCQlkYW1hZ2UgPSBOVUxMOwo+ICsJ CQlnb3RvIG91dDsKPiArCQl9Cj4gKwl9Cj4gKwo+ICtyZXRyeToKPiArCWRybV9mb3JfZWFjaF9w bGFuZShwbGFuZSwgZmItPmRldikgewo+ICsJCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnBsYW5l X3N0YXRlOwo+ICsKPiArCQlpZiAocGxhbmUtPnN0YXRlLT5mYiAhPSBmYikKPiArCQkJY29udGlu dWU7Cj4gKwo+ICsJCXBsYW5lX3N0YXRlID0gZHJtX2F0b21pY19nZXRfcGxhbmVfc3RhdGUoc3Rh dGUsIHBsYW5lKTsKPiArCQlpZiAoSVNfRVJSKHBsYW5lX3N0YXRlKSkgewo+ICsJCQlyZXQgPSBQ VFJfRVJSKHBsYW5lX3N0YXRlKTsKPiArCQkJZ290byBvdXQ7Cj4gKwkJfQo+ICsKPiArCQlkcm1f cHJvcGVydHlfcmVwbGFjZV9ibG9iKCZwbGFuZV9zdGF0ZS0+ZmJfZGFtYWdlX2NsaXBzLAo+ICsJ CQkJCSAgZGFtYWdlKTsKPiArCX0KPiArCj4gKwlyZXQgPSBkcm1fYXRvbWljX2NvbW1pdChzdGF0 ZSk7Cj4gKwo+ICtvdXQ6Cj4gKwlpZiAocmV0ID09IC1FREVBRExLKSB7Cj4gKwkJZHJtX2F0b21p Y19zdGF0ZV9jbGVhcihzdGF0ZSk7Cj4gKwkJcmV0ID0gZHJtX21vZGVzZXRfYmFja29mZigmY3R4 KTsKPiArCQlpZiAoIXJldCkKPiArCQkJZ290byByZXRyeTsKPiArCX0KPiArCj4gKwlkcm1fcHJv cGVydHlfYmxvYl9wdXQoZGFtYWdlKTsKPiArCWtmcmVlKHJlY3RzKTsKPiArCWRybV9hdG9taWNf c3RhdGVfcHV0KHN0YXRlKTsKPiArCj4gKwlkcm1fbW9kZXNldF9kcm9wX2xvY2tzKCZjdHgpOwo+ ICsJZHJtX21vZGVzZXRfYWNxdWlyZV9maW5pKCZjdHgpOwo+ICsKPiArCXJldHVybiByZXQ7Cj4g Kwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2F0b21pY19oZWxwZXJfZGlydHlmYik7Cj4gZGlm ZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9kYW1hZ2VfaGVscGVyLmggYi9pbmNsdWRlL2RybS9k cm1fZGFtYWdlX2hlbHBlci5oCj4gaW5kZXggMWY5ODhmN2ZkZDcyLi45ZDVjOTQ0NDc2MWIgMTAw NjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2RhbWFnZV9oZWxwZXIuaAo+ICsrKyBiL2luY2x1 ZGUvZHJtL2RybV9kYW1hZ2VfaGVscGVyLmgKPiBAQCAtODksNSArODksOSBAQCBkcm1fYXRvbWlj X2hlbHBlcl9kYW1hZ2VfaXRlcl9pbml0KHN0cnVjdCBkcm1fYXRvbWljX2hlbHBlcl9kYW1hZ2Vf aXRlciAqaXRlciwKPiAgYm9vbAo+ICBkcm1fYXRvbWljX2hlbHBlcl9kYW1hZ2VfaXRlcl9uZXh0 KHN0cnVjdCBkcm1fYXRvbWljX2hlbHBlcl9kYW1hZ2VfaXRlciAqaXRlciwKPiAgCQkJCSAgIHN0 cnVjdCBkcm1fcmVjdCAqcmVjdCk7Cj4gK2ludCBkcm1fYXRvbWljX2hlbHBlcl9kaXJ0eWZiKHN0 cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICsJCQkgICAgICBzdHJ1Y3QgZHJtX2ZpbGUgKmZp bGVfcHJpdiwgdW5zaWduZWQgZmxhZ3MsCj4gKwkJCSAgICAgIHVuc2lnbmVkIGNvbG9yLCBzdHJ1 Y3QgZHJtX2NsaXBfcmVjdCAqY2xpcHMsCj4gKwkJCSAgICAgIHVuc2lnbmVkIG51bV9jbGlwcyk7 Cj4gIAo+ICAjZW5kaWYKPiAtLSAKPiAyLjE3LjEKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3 YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK