From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: dts: add support for SolidRun Clearfog GT 8K
Date: Thu, 6 Sep 2018 14:53:00 +0200 [thread overview]
Message-ID: <20180906125300.GA22121@lunn.ch> (raw)
In-Reply-To: <a8f5114101ac62622a8b8152ba5415f39e52f05b.1536232787.git.baruch@tkos.co.il>
> v2:
> * Add SATA node
>
> * Set front button code to KEY_WPS_BUTTON
>
> * Use LEDs labels more aligned to conversion
Hi Baruch
It would be good to say why you did not make it fully aligned to
convention. What is wrong with "clearfog-gt-8k:green:led0"
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + switch0phy0: switch0phy0 at 11 {
> + reg = <0x11>;
> + };
> + switch0phy1: switch0phy1 at 12 {
> + reg = <0x12>;
> + };
> + switch0phy2: switch0phy2 at 13 {
> + reg = <0x13>;
> + };
> + switch0phy3: switch0phy3 at 14 {
> + reg = <0x14>;
> + };
> + };
It would be nice to add a black line after each child node.
Otherwise, this looks good.
Andrew
next prev parent reply other threads:[~2018-09-06 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 11:19 [PATCH v2] arm64: dts: add support for SolidRun Clearfog GT 8K Baruch Siach
2018-09-06 12:53 ` Andrew Lunn [this message]
2018-09-06 15:13 ` Baruch Siach
2018-09-21 11:05 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180906125300.GA22121@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.