From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Wu Subject: [PATCH v2 0/4] bochs fixes and fb-helper documentation updates Date: Fri, 7 Sep 2018 00:18:06 +0200 Message-ID: <20180906221810.20170-1-peter@lekensteyn.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.lekensteyn.nl (mail.lekensteyn.nl [IPv6:2a02:2308::360:1:25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E23C6E77E for ; Thu, 6 Sep 2018 22:18:18 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gerd Hoffmann Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org List-Id: dri-devel@lists.freedesktop.org SGksCgpUaGVzZSBzZXJpZXMgdHJpZXMgdG8gaW1wcm92ZSB0aGUgYm9jaHMgZHJpdmVyIGFuZCB1 cGRhdGUgZG9jdW1lbnRhdGlvbiBiYXNlZCBvbgpteSBicmllZiBleHBlcmllbmNlIHdpdGggdGhl IGZiLWhlbHBlciBBUEkuIFRoYW5rIHlvdSBEYW5pZWwgYW5kIEdlcmQgZm9yIHlvdXIKcHJldmlv dXMgZmVlZGJhY2sgYW5kIGhlbHBmdWwgc3VnZ2VzdGlvbnMuCgpQYXRjaCAyIHdhcyBwcmV2aW91 c2x5IHBvc3RlZCBhbmQgaXMgdW5tb2RpZmllZCBleGNlcHQgZm9yIGFja2VkLWJ5ICsgcmViYXNl IG9uCmRybS1taXNjLW5leHQgKDlhMDlhNDIzNjlhNGEzN2E5NTljMDUxZDhlMWExZjk0OGMxNTI5 YTQpLiBQYXRjaCAxIGlzIGEgdHJpdmlhbAooYnVpbGQpIGZpeCB0aGF0IHdhcyBtaXNzaW5nIGxh c3QgdGltZS4KClBhdGNoIDMgY29udmVydHMgZnJvbSB0aGUgbGVnYWN5IEFQSSB0byB0aGUgbW9k ZXJuIGRybV9kZXZfcmVnaXN0ZXIgYXBwcm9hY2guClRoaXMgc2VlbXMgcmVxdWlyZWQgZm9yIHRo ZSAiZ2VuZXJpYyIgZmJkZXYgQVBJIGFzIHN1Z2dlc3RlZCBieSBEYW5pZWwsIGJ1dCBhcwpib2No cyBkb2VzIG5vdCBpbXBsZW1lbnQgdGhlIHJlcXVpcmVkICJnZW1fcHJpbWVfdm1hcCIgZnVuY3Rp b24sIHRoZSBjb252ZXJzaW9uCmNhbm5vdCBiZSBjb21wbGV0ZWQgZm9yIG5vdy4KClBhdGNoIDQg aW5jbHVkZXMgc29tZSBkb2N1bWVudGF0aW9uIHVwZGF0ZXMgdGhhdCB3b3VsZCBoYXZlIGhlbHBl ZCBtZSBkdXJpbmcKcXhsL2JvY2hzIGRldmVsb3BtZW50IGFuZCBhIHdhcm5pbmcgdGhhdCBtYWRl IG1lIHJlYWxpemUgdGhhdCAiYSB2aXJ0dWFsIGFkZHJlc3MKYW5kIHRoYXQgY2FuIGJlIG1tYXAn ZWQiIGluIHRoZSBkb2N1bWVudGF0aW9uIHJlZmVycmVkIHRvICJnZW1fcHJpbWVfdm1hcCIuIEl0 CmlzIHRvIG15IGJlc3Qgb2YgdW5kZXJzdGFuZGluZywgc28gcGxlYXNlIGNvcnJlY3QgbWUgaWYg SSBhbSB3cm9uZy4KClNpZGUgbm90ZTogSSBvcmlnaW5hbGx5IHRyaWVkIHRvIGZpeCB0aGUgdW5i aW5kL3JlbW92ZSBjcmFzaCBpbiBRWEwgYW5kIHRoZW4KdHVybmVkIHRvIGJvY2hzIGFzIGl0IHNl ZW1lZCBzaW1wbGVyIHRvIGxlYXJuIGhvdyB0byB3b3JrIG9uIERSTSBkcml2ZXJzLgpIb3BlZnVs bHkgSSBtYW5hZ2UgdG8gZXZlbnR1YWxseSBmaWd1cmUgb3V0IGhvdyB0byBmaXggUVhMLiBRWEwg aXMgYSBiaXQKc3RyYW5nZSwgaXQgYWR2ZXJ0aXNlcyBQUklNRSAic3VwcG9ydCIgYnV0IGl0IG9u bHkgaGFzIHN0dWIgZnVuY3Rpb25zIChpbmNsdWRpbmcKYSBzdHViIGdlbV9wcmltZV92bWFwKS4K CkFmdGVyIG15IHJlY2VudCBwYXRjaCAoInF4bDogZml4IG51bGwtcG9pbnRlciBjcmFzaCBkdXJp bmcgc3VzcGVuZCIpIHF4bCBjYW4Kc3VzcGVuZC9yZXN1bWUgaW4gdGhlIG5vcm1hbCBzaXR1YXRp b24sIGJ1dCBkb2luZyBhbnl0aGluZyAoc3VzcGVuZCBvciB1bmxvYWQpCmFmdGVyIHVuYmluZGlu ZyBqdXN0IGZhaWxzIChzdXNwZW5kIHRoZW4gZmFpbHMgd2l0aCAiZmFpbGVkIHRvIHdhaXQgb24g cmVsZWFzZQoyMyBhZnRlciBzcGluY291bnQgMzAxIiwgdW5sb2FkIHRyaWdnZXJzIGEgdXNlLWFm dGVyLWZyZWUgYWNjb3JkaW5nIHRvIEtBU0FOKS4KT24gdGhlIG90aGVyIGhhbmQsIGJvY2hzIHBh c3NlcyB0aGVzZSB0ZXN0czoKCiAgICAjIDEuIHMvciB3aXRoIHVuYm91bmQgY29uc29sZQogICAg bW9kcHJvYmUgYm9jaHNfZHJtCiAgICBlY2hvIDAgPiAvc3lzL2NsYXNzL3Z0Y29uc29sZS92dGNv bjEvYmluZAogICAgcnRjd2FrZSAtcyAxIC1tIG1lbQogICAgIyAyLiBzL3IgaW4gbm9ybWFsIHNp dGF0aW9uCiAgICBlY2hvIDEgPiAvc3lzL2NsYXNzL3Z0Y29uc29sZS92dGNvbjEvYmluZAogICAg cnRjd2FrZSAtcyAxIC1tIG1lbQogICAgIyAzLiB1bmxvYWQgbW9kdWxlIChhbmQgcy9yIGZvciBn b29kIG1lYXN1cmUpCiAgICBlY2hvIDAgPiAvc3lzL2NsYXNzL3Z0Y29uc29sZS92dGNvbjEvYmlu ZAogICAgcm1tb2QgYm9jaHNfZHJtCiAgICBydGN3YWtlIC1zIDEgLW0gbWVtCgpLaW5kIHJlZ2Fy ZHMsClBldGVyCgpQZXRlciBXdSAoNCk6CiAgYm9jaHM6IHVzZSBkcm1fZmJfaGVscGVyX3NldF9z dXNwZW5kX3VubG9ja2VkIGluIHN1c3BlbmQvcmVzdW1lCiAgYm9jaHM6IGNvbnZlcnQgdG8gZHJt X2ZiX2hlbHBlcl9mYmRldl9zZXR1cC90ZWFyZG93bgogIGJvY2hzOiBjb252ZXJ0IHRvIGRybV9k ZXZfcmVnaXN0ZXIKICBkcm0vZmItaGVscGVyOiBpbXByb3ZlIGRvY3VtZW50YXRpb24gYW5kIHBy aW50IHdhcm5pbmdzCgogZHJpdmVycy9ncHUvZHJtL2JvY2hzL2JvY2hzLmggICAgICAgfCAyMSAr Ky0tLS0tLQogZHJpdmVycy9ncHUvZHJtL2JvY2hzL2JvY2hzX2Rydi5jICAgfCA0NiArKysrKysr KysrKy0tLS0tLQogZHJpdmVycy9ncHUvZHJtL2JvY2hzL2JvY2hzX2ZiZGV2LmMgfCA3OSArKysr KysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogZHJpdmVycy9ncHUvZHJtL2JvY2hzL2JvY2hzX2h3 LmMgICAgfCAgMiArLQogZHJpdmVycy9ncHUvZHJtL2JvY2hzL2JvY2hzX2ttcy5jICAgfCAgNyAr LS0KIGRyaXZlcnMvZ3B1L2RybS9ib2Nocy9ib2Noc19tbS5jICAgIHwgNzQgLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCiBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jICAgICB8IDI1 ICsrKysrKy0tLQogNyBmaWxlcyBjaGFuZ2VkLCA3MyBpbnNlcnRpb25zKCspLCAxODEgZGVsZXRp b25zKC0pCgotLSAKMi4xOC4wCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0100EC433F5 for ; Thu, 6 Sep 2018 22:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE411206BA for ; Thu, 6 Sep 2018 22:18:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lekensteyn.nl header.i=@lekensteyn.nl header.b="QdS5rn3W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE411206BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lekensteyn.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728410AbeIGCzy (ORCPT ); Thu, 6 Sep 2018 22:55:54 -0400 Received: from lekensteyn.nl ([178.21.112.251]:37687 "EHLO lekensteyn.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727618AbeIGCzy (ORCPT ); Thu, 6 Sep 2018 22:55:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lekensteyn.nl; s=s2048-2015-q1; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From; bh=Azoeh7ONZW4pASwk57naKlFdhZ4qoJqyNyxU05h63Qs=; b=QdS5rn3WAdjRrNK+FdLw1R/4M1xbPIJVC6S/aWLm4RQ1zZUycM838XnLSP6GDRMy6UepFlSSjdzrVj8jjJzjLq9kDLn4HtPsDa0o48UIK4y1xHqxIwsPaBjX58+bfPxxRwaWa5VlNKidGuu9GtppkwmyVBSwYArDccTe3M94NyX0ue6klSKD+YV4Mp1gkkDneh/LfpKYJzB2Z4iHPOfCD1F6D2LzTIUHexRcpOnBxvHyKZJUoHVBvaZzc+ppwkDTyo9eCd8PCWzBHpt7V78Pyn36KJIcCWWI1LFMllcNUizomC2O0A3nR+7MnfMXvdRZuDUiT9VJo1aq+XxlbIwblA==; Received: by lekensteyn.nl with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1fy2bK-0005Us-PS; Fri, 07 Sep 2018 00:18:12 +0200 From: Peter Wu To: Gerd Hoffmann Cc: virtualization@lists.linux-foundation.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= Subject: [PATCH v2 0/4] bochs fixes and fb-helper documentation updates Date: Fri, 7 Sep 2018 00:18:06 +0200 Message-Id: <20180906221810.20170-1-peter@lekensteyn.nl> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, These series tries to improve the bochs driver and update documentation based on my brief experience with the fb-helper API. Thank you Daniel and Gerd for your previous feedback and helpful suggestions. Patch 2 was previously posted and is unmodified except for acked-by + rebase on drm-misc-next (9a09a42369a4a37a959c051d8e1a1f948c1529a4). Patch 1 is a trivial (build) fix that was missing last time. Patch 3 converts from the legacy API to the modern drm_dev_register approach. This seems required for the "generic" fbdev API as suggested by Daniel, but as bochs does not implement the required "gem_prime_vmap" function, the conversion cannot be completed for now. Patch 4 includes some documentation updates that would have helped me during qxl/bochs development and a warning that made me realize that "a virtual address and that can be mmap'ed" in the documentation referred to "gem_prime_vmap". It is to my best of understanding, so please correct me if I am wrong. Side note: I originally tried to fix the unbind/remove crash in QXL and then turned to bochs as it seemed simpler to learn how to work on DRM drivers. Hopefully I manage to eventually figure out how to fix QXL. QXL is a bit strange, it advertises PRIME "support" but it only has stub functions (including a stub gem_prime_vmap). After my recent patch ("qxl: fix null-pointer crash during suspend") qxl can suspend/resume in the normal situation, but doing anything (suspend or unload) after unbinding just fails (suspend then fails with "failed to wait on release 23 after spincount 301", unload triggers a use-after-free according to KASAN). On the other hand, bochs passes these tests: # 1. s/r with unbound console modprobe bochs_drm echo 0 > /sys/class/vtconsole/vtcon1/bind rtcwake -s 1 -m mem # 2. s/r in normal sitation echo 1 > /sys/class/vtconsole/vtcon1/bind rtcwake -s 1 -m mem # 3. unload module (and s/r for good measure) echo 0 > /sys/class/vtconsole/vtcon1/bind rmmod bochs_drm rtcwake -s 1 -m mem Kind regards, Peter Peter Wu (4): bochs: use drm_fb_helper_set_suspend_unlocked in suspend/resume bochs: convert to drm_fb_helper_fbdev_setup/teardown bochs: convert to drm_dev_register drm/fb-helper: improve documentation and print warnings drivers/gpu/drm/bochs/bochs.h | 21 ++------ drivers/gpu/drm/bochs/bochs_drv.c | 46 +++++++++++------ drivers/gpu/drm/bochs/bochs_fbdev.c | 79 +++++++---------------------- drivers/gpu/drm/bochs/bochs_hw.c | 2 +- drivers/gpu/drm/bochs/bochs_kms.c | 7 +-- drivers/gpu/drm/bochs/bochs_mm.c | 74 --------------------------- drivers/gpu/drm/drm_fb_helper.c | 25 ++++++--- 7 files changed, 73 insertions(+), 181 deletions(-) -- 2.18.0