All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next] libusbgx: fix build with glibc-2.28
Date: Thu, 6 Sep 2018 23:41:49 +0200	[thread overview]
Message-ID: <20180906234149.3af458dc@windsurf.home> (raw)
In-Reply-To: <20180822135234.20670-1-gwenj@trabucayre.com>

Hello,

On Wed, 22 Aug 2018 15:52:34 +0200, Gwenhael Goavec-Merou wrote:

> diff --git a/package/libusbgx/0001-Add-include-of-sys-sysmacro.h.patch b/package/libusbgx/0001-Add-include-of-sys-sysmacro.h.patch
> new file mode 100644
> index 0000000000..997cbf9a12
> --- /dev/null
> +++ b/package/libusbgx/0001-Add-include-of-sys-sysmacro.h.patch
> @@ -0,0 +1,94 @@
> +Add include of sys/sysmacro.h.
> +
> +Without sys/sysmacros.h and with glibc build fails with error like:
> +
> +libusbgx-libusbgx-v0.2.0/src/.libs/libusbgx.so: undefined reference to `minor'
> +libusbgx-libusbgx-v0.2.0/src/.libs/libusbgx.so: undefined reference to `major'
> +libusbgx-libusbgx-v0.2.0/src/.libs/libusbgx.so: undefined reference to `makedev'
> +
> +Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> +Signed-off-by: Sid Spry <R030t1@gmail.com>

The order of the SoB should be the opposite: first the original author,
then you.

Also, please use a Git-formatted patch.

Could you submit a new version with those minor nits fixed?

Also, could you submit a new pull request upstream, because it seems
that Sid Spry is not going to resubmit a proper patch that takes into
account the comments made by upstream.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-09-06 21:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22 13:52 [Buildroot] [PATCH next] libusbgx: fix build with glibc-2.28 Gwenhael Goavec-Merou
2018-09-06 21:41 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180906234149.3af458dc@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.