From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v2] usb: xhci: fix interrupt transfer error happened on MTK platforms Date: Fri, 7 Sep 2018 09:42:51 +0200 Message-ID: <20180907074251.GA2079@kroah.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Chunfeng Yun Cc: Mathias Nyman , Felipe Balbi , Matthias Brugger , Sean Wang , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org On Fri, Sep 07, 2018 at 03:29:12PM +0800, Chunfeng Yun wrote: > The MTK xHCI controller use some reserved bytes in endpoint context for > bandwidth scheduling, so need keep them in xhci_endpoint_copy(); If they are "reserved" shouldn't they be properly named? And by using reserved bytes, isn't that a spec violation? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] usb: xhci: fix interrupt transfer error happened on MTK platforms From: Greg Kroah-Hartman Message-Id: <20180907074251.GA2079@kroah.com> Date: Fri, 7 Sep 2018 09:42:51 +0200 To: Chunfeng Yun Cc: Mathias Nyman , Felipe Balbi , Matthias Brugger , Sean Wang , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org List-ID: T24gRnJpLCBTZXAgMDcsIDIwMTggYXQgMDM6Mjk6MTJQTSArMDgwMCwgQ2h1bmZlbmcgWXVuIHdy b3RlOgo+IFRoZSBNVEsgeEhDSSBjb250cm9sbGVyIHVzZSBzb21lIHJlc2VydmVkIGJ5dGVzIGlu IGVuZHBvaW50IGNvbnRleHQgZm9yCj4gYmFuZHdpZHRoIHNjaGVkdWxpbmcsIHNvIG5lZWQga2Vl cCB0aGVtIGluIHhoY2lfZW5kcG9pbnRfY29weSgpOwoKSWYgdGhleSBhcmUgInJlc2VydmVkIiBz aG91bGRuJ3QgdGhleSBiZSBwcm9wZXJseSBuYW1lZD8gIEFuZCBieSB1c2luZwpyZXNlcnZlZCBi eXRlcywgaXNuJ3QgdGhhdCBhIHNwZWMgdmlvbGF0aW9uPwoKdGhhbmtzLAoKZ3JlZyBrLWgK From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Fri, 7 Sep 2018 09:42:51 +0200 Subject: [PATCH v2] usb: xhci: fix interrupt transfer error happened on MTK platforms In-Reply-To: References: Message-ID: <20180907074251.GA2079@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Sep 07, 2018 at 03:29:12PM +0800, Chunfeng Yun wrote: > The MTK xHCI controller use some reserved bytes in endpoint context for > bandwidth scheduling, so need keep them in xhci_endpoint_copy(); If they are "reserved" shouldn't they be properly named? And by using reserved bytes, isn't that a spec violation? thanks, greg k-h