All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Juergen Gross <jgross@suse.com>,
	x86@kernel.org, virtualization@lists.linux-foundation.org
Subject: [PATCH] x86/paravirt: Get rid of patch_site label
Date: Fri,  7 Sep 2018 12:49:17 +0200	[thread overview]
Message-ID: <20180907104917.12502-1-bp@alien8.de> (raw)

From: Borislav Petkov <bp@suse.de>

When CONFIG_PARAVIRT_SPINLOCKS=n, it fires

  arch/x86/kernel/paravirt_patch_64.c: In function ‘native_patch’:
  arch/x86/kernel/paravirt_patch_64.c:89:1: warning: label ‘patch_site’ defined but not used [-Wunused-label]
   patch_site:

but that label can simply be removed by directly calling
paravirt_patch_insns() there.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Juergen Gross <jgross@suse.com>
Cc: x86@kernel.org
Cc: virtualization@lists.linux-foundation.org
---
 arch/x86/kernel/paravirt_patch_64.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/paravirt_patch_64.c b/arch/x86/kernel/paravirt_patch_64.c
index 5ad5bcda9dc6..f09d264cbd2d 100644
--- a/arch/x86/kernel/paravirt_patch_64.c
+++ b/arch/x86/kernel/paravirt_patch_64.c
@@ -76,7 +76,8 @@ unsigned native_patch(u8 type, void *ibuf, unsigned long addr, unsigned len)
 			if (pv_is_native_vcpu_is_preempted()) {
 				start = start_lock_vcpu_is_preempted;
 				end   = end_lock_vcpu_is_preempted;
-				goto patch_site;
+
+				return paravirt_patch_insns(ibuf, len, start, end);
 			}
 			goto patch_default;
 #endif
@@ -86,7 +87,6 @@ patch_default: __maybe_unused
 		ret = paravirt_patch_default(type, ibuf, addr, len);
 		break;
 
-patch_site:
 		ret = paravirt_patch_insns(ibuf, len, start, end);
 		break;
 	}
-- 
2.17.0.582.gccdcbd54c


             reply	other threads:[~2018-09-07 10:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 10:49 Borislav Petkov [this message]
2018-09-07 10:51 ` [PATCH] x86/paravirt: Get rid of patch_site label Borislav Petkov
2018-09-07 10:51 ` Borislav Petkov
2018-09-07 20:10   ` [PATCH v2] x86/paravirt: Get rid of patch_site and patch_default labels Borislav Petkov
2018-09-08  5:45     ` Juergen Gross
2018-09-08  5:45       ` Juergen Gross
2018-09-08 15:28       ` [PATCH] x86/paravirt: Cleanup native_patch() Borislav Petkov
2018-09-08 15:28         ` Borislav Petkov
2018-09-10  6:54         ` Juergen Gross
2018-09-10  7:01           ` Borislav Petkov
2018-09-10  8:33             ` Juergen Gross
2018-09-10  8:33             ` Juergen Gross
2018-09-11  9:15               ` [PATCH v2] " Borislav Petkov
2018-09-11  9:44                 ` Juergen Gross
2018-09-11  9:44                 ` Juergen Gross
2018-09-11 15:34                 ` [tip:x86/paravirt] x86/paravirt: Clean up native_patch() tip-bot for Borislav Petkov
2018-09-11  9:15               ` [PATCH v2] x86/paravirt: Cleanup native_patch() Borislav Petkov
2018-09-10  7:01           ` [PATCH] " Borislav Petkov
2018-09-10  6:54         ` Juergen Gross
2018-09-07 20:10   ` [PATCH v2] x86/paravirt: Get rid of patch_site and patch_default labels Borislav Petkov
  -- strict thread matches above, loose matches on Subject: below --
2018-09-07 10:49 [PATCH] x86/paravirt: Get rid of patch_site label Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180907104917.12502-1-bp@alien8.de \
    --to=bp@alien8.de \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.