From: Olaf Hering <olaf@aepfle.de>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] xen: avoid crash in disable_hotplug_cpu
Date: Fri, 7 Sep 2018 11:24:51 +0200 [thread overview]
Message-ID: <20180907112451.442b46fe.olaf@aepfle.de> (raw)
In-Reply-To: <c26bfbe1-9032-468c-d4d0-c05eda8af762@suse.com>
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
Am Fri, 7 Sep 2018 09:48:28 +0200
schrieb Juergen Gross <jgross@suse.com>:
> On 07/09/18 08:30, Olaf Hering wrote:
> > + if (cpu_online(cpu))
> > + return;
> > if (cpu_present(cpu))
> > xen_arch_unregister_cpu(cpu);
> Could you merge the two if conditions?
> if (!cpu_online(cpu) && cpu_present(cpu))
> xen_arch_unregister_cpu(cpu);
Is that any different, beside being wrong, from what the patch actually does?
It would still clear the present bit later on.
Olaf
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2018-09-07 9:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 6:30 [PATCH v3] xen: avoid crash in disable_hotplug_cpu Olaf Hering
2018-09-07 7:48 ` Juergen Gross
2018-09-07 9:24 ` Olaf Hering [this message]
2018-09-07 9:50 ` Juergen Gross
2018-09-07 9:50 ` Juergen Gross
2018-09-07 9:24 ` Olaf Hering
2018-09-07 7:48 ` Juergen Gross
2018-09-07 13:33 ` Boris Ostrovsky
2018-09-07 13:33 ` Boris Ostrovsky
2018-09-07 13:39 ` Olaf Hering
2018-09-07 13:39 ` Olaf Hering
2018-09-11 11:25 ` Juergen Gross
2018-09-11 11:25 ` Juergen Gross
2018-09-11 14:29 ` Boris Ostrovsky
2018-09-11 14:29 ` Boris Ostrovsky
2018-09-11 14:29 ` Juergen Gross
2018-09-11 14:29 ` Juergen Gross
-- strict thread matches above, loose matches on Subject: below --
2018-09-07 6:30 Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907112451.442b46fe.olaf@aepfle.de \
--to=olaf@aepfle.de \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.