From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: [RFC] drm/i915: GEM_WARN_ON considered harmful Date: Fri, 7 Sep 2018 12:53:51 +0100 Message-ID: <20180907115351.31644-1-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24FD46E8E5 for ; Fri, 7 Sep 2018 11:53:58 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id j25-v6so18980242wmc.1 for ; Fri, 07 Sep 2018 04:53:58 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Intel-gfx@lists.freedesktop.org Cc: Matthew Auld , Mika Kuoppala List-Id: intel-gfx@lists.freedesktop.org RnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KCkdFTV9XQVJO X09OIGN1cnJlbnRseSBoYXMgZGFuZ2Vyb3VzIHNlbWFudGljcyB3aGVyZSBpdCBpcyBjb21wbGV0 ZWx5CmNvbXBpbGVkIG91dCBvbiAhR0VNX0RFQlVHIGJ1aWxkcy4gVGhpcyBjYW4gbGVhdmUgdXNl cnMgd2hvIGV4cGVjdCBpdCB0bwpiZSBtb3JlIGxpa2UgYSBXQVJOX09OLCBqdXN0IHdpdGhvdXQg YSB3YXJuaW5nIGluIG5vbi1kZWJ1ZyBidWlsZHMsIGluCmNvbXBsZXRlIGlnbm9yYW5jZS4KCkFu b3RoZXIgZ290Y2hhIHdpdGggaXQgaXMgdGhhdCBpdCBjYW5ub3QgYmUgdXNlZCBhcyBhIHN0YXRl bWVudC4gV2hpY2ggaXMKYWdhaW4gZGlmZmVyZW50IGZyb20gYSBzdGFuZGFyZCBrZXJuZWwgV0FS Tl9PTi4KClRoaXMgcGF0Y2ggZml4ZXMgYm90aCBwcm9ibGVtcyBieSBtYWtpbmcgaXQgYmVoYXZl IGFzIG9uZSB3b3VsZCBleHBlY3QuCgpJdCBjYW4gbm93IGJlIHVzZWQgYm90aCBhcyBhbiBleHBy ZXNzaW9uIGFuZCBhcyBzdGF0ZW1lbnQsIGFuZCBhbHNvIHRoZQpjb25kaXRpb24gZXZhbHVhdGVz IHByb3Blcmx5IGluIGFsbCBidWlsZHMgLSBjb2RlIHVuZGVyIHRoZSBjb25kaXRpb25hbAp3aWxs IHRoZXJlZm9yZSBub3QgdW5leHBlY3RlZGx5IGRpc2FwcGVhci4KClRvIHNhdGlzZnkgY2FsbCBz aXRlcyB3aGljaCByZWFsbHkgd2FudCB0aGUgY29kZSB1bmRlciB0aGUgY29uZGl0aW9uYWwgdG8K Y29tcGxldGVseSBkaXNhcHBlYXIsIHdlIGFkZCBHRU1fREVCVUdfV0FSTl9PTiBhbmQgY29udmVy dCBzb21lIG9mIHRoZQpjYWxsZXJzIHRvIGl0LiBUaGlzIG9uZSBjYW4gYWxzbyBiZSB1c2VkIGFz IGJvdGggZXhwcmVzc2lvbiBhbmQgc3RhdGVtZW50LgoKRnJvbSB0aGUgYWJvdmUgaXQgZm9sbG93 cyBHRU1fREVCVUdfV0FSTl9PTiBzaG91bGQgYmUgdXNlZCBpbiBzaXR1YXRpb25zCndoZXJlIHdl IGFyZSBjZXJ0YWluIHRoZSBjb25kaXRpb24gd2lsbCBiZSBoaXQgZHVyaW5nIGRldmVsb3BtZW50 LCBidXQgYXQKYSBwbGFjZSBpbiBjb2RlIHdoZXJlIGVycm9yIGNhbiBiZSBoYW5kbGVkIHRvIHRo ZSBiZW5lZml0IG9mIG5vdCBjcmFzaGluZwp0aGUgbWFjaGluZS4KCkdFTV9XQVJOX09OIG9uIHRo ZSBvdGhlciBoYW5kIHNob3VsZCBiZSB1c2VkIHdoZXJlIGNvbmRpdGlvbiBtYXkgaGFwcGVuIGlu CnByb2R1Y3Rpb24gYW5kIHdlIGp1c3Qgd2FudCB0byBkaXN0aW5ndWlzaCB0aGUgbGV2ZWwgb2Yg ZGVidWdnaW5nIG91dHB1dAplbWl0dGVkIGJldHdlZW4gdGhlIHByb2R1Y3Rpb24gYW5kIGRlYnVn IGJ1aWxkLgoKU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGlu dGVsLmNvbT4KQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgpDYzog Sm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgpDYzogTWF0 dGhldyBBdWxkIDxtYXR0aGV3LmF1bGRAaW50ZWwuY29tPgpDYzogTWlrYSBLdW9wcGFsYSA8bWlr YS5rdW9wcGFsYUBpbnRlbC5jb20+Ci0tLQpRdWlja2x5IHB1dCB0b2dldGhlciBhbmQgY29tcGls ZSB0ZXN0ZWQgb25seSEKLS0tCiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5oICAgICAg ICAgIHwgNCArKystCiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3ZtYS5jICAgICAgICAgIHwg OCArKysrLS0tLQogZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMgICB8IDgg KysrKy0tLS0KIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jICAgICAgICAgfCA4ICsr KystLS0tCiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93b3JrYXJvdW5kcy5jIHwgMiArLQog NSBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5oIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uaAppbmRleCA1OTljNGY2ZWIxZWEuLmIwZTRiOTc2ODgwYyAxMDA2NDQK LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uaAorKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5oCkBAIC00NywxNyArNDcsMTkgQEAgc3RydWN0IGRybV9pOTE1X3By aXZhdGU7CiAjZGVmaW5lIEdFTV9ERUJVR19ERUNMKHZhcikgdmFyCiAjZGVmaW5lIEdFTV9ERUJV R19FWEVDKGV4cHIpIGV4cHIKICNkZWZpbmUgR0VNX0RFQlVHX0JVR19PTihleHByKSBHRU1fQlVH X09OKGV4cHIpCisjZGVmaW5lIEdFTV9ERUJVR19XQVJOX09OKGV4cHIpIEdFTV9XQVJOX09OKGV4 cHIpCiAKICNlbHNlCiAKICNkZWZpbmUgR0VNX1NIT1dfREVCVUcoKSAoMCkKIAogI2RlZmluZSBH RU1fQlVHX09OKGV4cHIpIEJVSUxEX0JVR19PTl9JTlZBTElEKGV4cHIpCi0jZGVmaW5lIEdFTV9X QVJOX09OKGV4cHIpIChCVUlMRF9CVUdfT05fSU5WQUxJRChleHByKSwgMCkKKyNkZWZpbmUgR0VN X1dBUk5fT04oZXhwcikgKHsgdW5saWtlbHkoISEoZXhwcikpOyB9KQogCiAjZGVmaW5lIEdFTV9E RUJVR19ERUNMKHZhcikKICNkZWZpbmUgR0VNX0RFQlVHX0VYRUMoZXhwcikgZG8geyB9IHdoaWxl ICgwKQogI2RlZmluZSBHRU1fREVCVUdfQlVHX09OKGV4cHIpCisjZGVmaW5lIEdFTV9ERUJVR19X QVJOX09OKGV4cHIpICh7IEJVSUxEX0JVR19PTl9JTlZBTElEKGV4cHIpOyAwOyB9KQogI2VuZGlm CiAKICNpZiBJU19FTkFCTEVEKENPTkZJR19EUk1fSTkxNV9UUkFDRV9HRU0pCmRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3ZtYS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV92bWEuYwppbmRleCAzMWVmYzk3MWEzYTguLjgyNjUyYzNkMWJlZCAxMDA2NDQKLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV92bWEuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3ZtYS5jCkBAIC0zMDUsMTIgKzMwNSwxMiBAQCBpbnQgaTkxNV92bWFfYmluZChzdHJ1 Y3QgaTkxNV92bWEgKnZtYSwgZW51bSBpOTE1X2NhY2hlX2xldmVsIGNhY2hlX2xldmVsLAogCUdF TV9CVUdfT04oIWRybV9tbV9ub2RlX2FsbG9jYXRlZCgmdm1hLT5ub2RlKSk7CiAJR0VNX0JVR19P Tih2bWEtPnNpemUgPiB2bWEtPm5vZGUuc2l6ZSk7CiAKLQlpZiAoR0VNX1dBUk5fT04ocmFuZ2Vf b3ZlcmZsb3dzKHZtYS0+bm9kZS5zdGFydCwKLQkJCQkJdm1hLT5ub2RlLnNpemUsCi0JCQkJCXZt YS0+dm0tPnRvdGFsKSkpCisJaWYgKEdFTV9ERUJVR19XQVJOX09OKHJhbmdlX292ZXJmbG93cyh2 bWEtPm5vZGUuc3RhcnQsCisJCQkJCSAgICAgIHZtYS0+bm9kZS5zaXplLAorCQkJCQkgICAgICB2 bWEtPnZtLT50b3RhbCkpKQogCQlyZXR1cm4gLUVOT0RFVjsKIAotCWlmIChHRU1fV0FSTl9PTigh ZmxhZ3MpKQorCWlmIChHRU1fREVCVUdfV0FSTl9PTighZmxhZ3MpKQogCQlyZXR1cm4gLUVJTlZB TDsKIAogCWJpbmRfZmxhZ3MgPSAwOwpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZW5naW5lX2NzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3Mu YwppbmRleCAxMGNkMDUxYmEyOWUuLjhkYmRiMThiMjY2OCAxMDA2NDQKLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZW5naW5lX2NzLmMKQEAgLTI3MywxMyArMjczLDEzIEBAIGludGVsX2VuZ2luZV9zZXR1 cChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCiAJQlVJTERfQlVHX09OKE1BWF9F TkdJTkVfQ0xBU1MgPj0gQklUKEdFTjExX0VOR0lORV9DTEFTU19XSURUSCkpOwogCUJVSUxEX0JV R19PTihNQVhfRU5HSU5FX0lOU1RBTkNFID49IEJJVChHRU4xMV9FTkdJTkVfSU5TVEFOQ0VfV0lE VEgpKTsKIAotCWlmIChHRU1fV0FSTl9PTihpbmZvLT5jbGFzcyA+IE1BWF9FTkdJTkVfQ0xBU1Mp KQorCWlmIChHRU1fREVCVUdfV0FSTl9PTihpbmZvLT5jbGFzcyA+IE1BWF9FTkdJTkVfQ0xBU1Mp KQogCQlyZXR1cm4gLUVJTlZBTDsKIAotCWlmIChHRU1fV0FSTl9PTihpbmZvLT5pbnN0YW5jZSA+ IE1BWF9FTkdJTkVfSU5TVEFOQ0UpKQorCWlmIChHRU1fREVCVUdfV0FSTl9PTihpbmZvLT5pbnN0 YW5jZSA+IE1BWF9FTkdJTkVfSU5TVEFOQ0UpKQogCQlyZXR1cm4gLUVJTlZBTDsKIAotCWlmIChH RU1fV0FSTl9PTihkZXZfcHJpdi0+ZW5naW5lX2NsYXNzW2luZm8tPmNsYXNzXVtpbmZvLT5pbnN0 YW5jZV0pKQorCWlmIChHRU1fREVCVUdfV0FSTl9PTihkZXZfcHJpdi0+ZW5naW5lX2NsYXNzW2lu Zm8tPmNsYXNzXVtpbmZvLT5pbnN0YW5jZV0pKQogCQlyZXR1cm4gLUVJTlZBTDsKIAogCUdFTV9C VUdfT04oZGV2X3ByaXYtPmVuZ2luZVtpZF0pOwpAQCAtMzk5LDcgKzM5OSw3IEBAIGludCBpbnRl bF9lbmdpbmVzX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQogCQllcnIg PSAtRUlOVkFMOwogCQllcnJfaWQgPSBpZDsKIAotCQlpZiAoR0VNX1dBUk5fT04oIWluaXQpKQor CQlpZiAoR0VNX0RFQlVHX1dBUk5fT04oIWluaXQpKQogCQkJZ290byBjbGVhbnVwOwogCiAJCWVy ciA9IGluaXQoZW5naW5lKTsKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKaW5kZXggMTljOWM0NjMw OGU1Li5hMjc0Y2M2OTVmYTIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2xyYy5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCkBAIC0xNjgxLDcg KzE2ODEsNyBAQCBzdGF0aWMgaW50IGludGVsX2luaXRfd29ya2Fyb3VuZF9iYihzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmUpCiAJdW5zaWduZWQgaW50IGk7CiAJaW50IHJldDsKIAotCWlm IChHRU1fV0FSTl9PTihlbmdpbmUtPmlkICE9IFJDUykpCisJaWYgKEdFTV9ERUJVR19XQVJOX09O KGVuZ2luZS0+aWQgIT0gUkNTKSkKIAkJcmV0dXJuIC1FSU5WQUw7CiAKIAlzd2l0Y2ggKElOVEVM X0dFTihlbmdpbmUtPmk5MTUpKSB7CkBAIC0xNzIwLDggKzE3MjAsOCBAQCBzdGF0aWMgaW50IGlu dGVsX2luaXRfd29ya2Fyb3VuZF9iYihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCiAJ ICovCiAJZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUod2FfYmJfZm4pOyBpKyspIHsKIAkJd2Ff YmJbaV0tPm9mZnNldCA9IGJhdGNoX3B0ciAtIGJhdGNoOwotCQlpZiAoR0VNX1dBUk5fT04oIUlT X0FMSUdORUQod2FfYmJbaV0tPm9mZnNldCwKLQkJCQkJICAgIENBQ0hFTElORV9CWVRFUykpKSB7 CisJCWlmIChHRU1fREVCVUdfV0FSTl9PTighSVNfQUxJR05FRCh3YV9iYltpXS0+b2Zmc2V0LAor CQkJCQkJICBDQUNIRUxJTkVfQllURVMpKSkgewogCQkJcmV0ID0gLUVJTlZBTDsKIAkJCWJyZWFr OwogCQl9CkBAIC0xNzMwLDcgKzE3MzAsNyBAQCBzdGF0aWMgaW50IGludGVsX2luaXRfd29ya2Fy b3VuZF9iYihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCiAJCXdhX2JiW2ldLT5zaXpl ID0gYmF0Y2hfcHRyIC0gKGJhdGNoICsgd2FfYmJbaV0tPm9mZnNldCk7CiAJfQogCi0JQlVHX09O KGJhdGNoX3B0ciAtIGJhdGNoID4gQ1RYX1dBX0JCX09CSl9TSVpFKTsKKwlHRU1fQlVHX09OKGJh dGNoX3B0ciAtIGJhdGNoID4gQ1RYX1dBX0JCX09CSl9TSVpFKTsKIAogCWt1bm1hcF9hdG9taWMo YmF0Y2gpOwogCWlmIChyZXQpCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF93b3JrYXJvdW5kcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd29ya2Fyb3VuZHMu YwppbmRleCA0YmNkZWFmOGQ5OGYuLmZiNzQ2YzRiN2MzOCAxMDA2NDQKLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfd29ya2Fyb3VuZHMuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF93b3JrYXJvdW5kcy5jCkBAIC05NDEsNyArOTQxLDcgQEAgc3RydWN0IHdoaXRlbGlz dCB7CiAKIHN0YXRpYyB2b2lkIHdoaXRlbGlzdF9yZWcoc3RydWN0IHdoaXRlbGlzdCAqdywgaTkx NV9yZWdfdCByZWcpCiB7Ci0JaWYgKEdFTV9XQVJOX09OKHctPmNvdW50ID49IFJJTkdfTUFYX05P TlBSSVZfU0xPVFMpKQorCWlmIChHRU1fREVCVUdfV0FSTl9PTih3LT5jb3VudCA+PSBSSU5HX01B WF9OT05QUklWX1NMT1RTKSkKIAkJcmV0dXJuOwogCiAJdy0+cmVnW3ctPmNvdW50KytdID0gcmVn OwotLSAKMi4xNy4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK